loophp\phptree\Node\TrieNode

Complexity

Total Complexity

7

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	append()	0	12	3
A	add()	0	27	4

<?php

/**
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

declare(strict_types=1);

namespace loophp\phptree\Node;

use Exception;

/**
 * Class TrieNode.
 */
class TrieNode extends KeyValueNode
{
    public function add(NodeInterface ...$nodes): NodeInterface
    {
        foreach ($nodes as $node) {
            $data = $node->getValue();

The method getValue() does not exist on loophp\phptree\Node\NodeInterface. It seems like you code against a sub-type of loophp\phptree\Node\NodeInterface such as loophp\phptree\Node\ValueNodeInterface or loophp\phptree\Node\ValueNode or loophp\phptree\Node\ValueNode.

            $hash = hash('sha256', $node->getKey() . $data);

The method getKey() does not exist on loophp\phptree\Node\NodeInterface. It seems like you code against a sub-type of loophp\phptree\Node\NodeInterface such as loophp\phptree\Node\KeyValueNode or loophp\phptree\Node\KeyValueNodeInterface or loophp\phptree\Node\KeyValueNode or loophp\phptree\Node\KeyValueNode.

            $node = new self($hash, substr($data, 0, 1));
            $parent = $this->append($node);

            $dataWithoutFirstLetter = substr($data, 1);

            if ('' < $dataWithoutFirstLetter) {
                $parent->add(new self($hash, $dataWithoutFirstLetter));
            } else {
                $nodes = [$node->getValue()];

                /** @var KeyValueNodeInterface $ancestor */
                foreach ($node->getAncestors() as $ancestor) {
                    $nodes[] = $ancestor->getValue();
                }
                array_pop($nodes);
                $node->append(new self($hash, strrev(implode('', $nodes))));
            }
        }

        return $this;
    }

    /**
     * @throws Exception
     *
     * @return NodeInterface|ValueNodeInterface
     */
    private function append(ValueNodeInterface $node)
    {
        /** @var ValueNodeInterface $child */
        foreach ($this->children() as $child) {
            if ($node->getValue() === $child->getValue()) {
                return $child;

The expression return $child returns the type loophp\phptree\Node\NodeInterface[] which is incompatible with the documented return type loophp\phptree\Node\NodeInterface|loophp\phptree\Node\ValueNodeInterface.

            }
        }

        parent::add($node);

        return $node;
    }
}