Lookyman\NetteOAuth2Server\Storage\Doctrine\Client\ClientRepository

Complexity

Total Complexity

8

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
B	getClientEntity()	0	11	5
A	createQuery()	0	4	1

<?php
declare(strict_types=1);

namespace Lookyman\NetteOAuth2Server\Storage\Doctrine\Client;

use Kdyby\Doctrine\EntityManager;
use Kdyby\Doctrine\EntityRepository;
use Kdyby\Doctrine\QueryObject;
use League\OAuth2\Server\Entities\ClientEntityInterface;
use League\OAuth2\Server\Repositories\ClientRepositoryInterface;

class ClientRepository implements ClientRepositoryInterface
{
	/**
	 * @var EntityManager
	 */
	private $entityManager;

	/**
	 * @var EntityRepository
	 */
	private $repository;

	/**
	 * @var callable
	 */
	private $secretValidator;

	/**
	 * @param EntityManager $entityManager
	 * @param callable|null $secretValidator
	 */
	public function __construct(EntityManager $entityManager, callable $secretValidator = null)

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

	{
		$this->entityManager = $entityManager;
		$this->repository = $entityManager->getRepository(ClientEntity::class);
		$this->secretValidator = $secretValidator ?: function ($expected, $actual) { return hash_equals($expected, $actual); };
	}

	/**
	 * @param string $clientIdentifier
	 * @param string $grantType
	 * @param string|null $clientSecret
	 * @param bool $mustValidateSecret
	 * @return ClientEntityInterface|null
	 */
	public function getClientEntity($clientIdentifier, $grantType, $clientSecret = null, $mustValidateSecret = true)
	{
		/** @var ClientEntity|null $client */
		$client = $this->repository->fetchOne($this->createQuery()->byIdentifier($clientIdentifier));
		return $client
			&& $client->getSecret()

The expression $client->getSecret() of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

			&& $mustValidateSecret
			&& !call_user_func($this->secretValidator, $client->getSecret(), $clientSecret)
			? null
			: $client;
	}

	/**
	 * @return QueryObject
	 */
	protected function createQuery(): QueryObject
	{
		return new ClientQuery();
	}
}