UserSettings - Code Metrics - log-oscon/redmine-embed - Measure and Improve Code Quality continuously with Scrutinizer

UserSettings A
last analyzed 2016-02-19 15:02 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	6
c	3
b	0
f	0
lcom	1
cbo	1
dl	0
loc	79
ccs	0
cts	34
cp	0
rs	10

3 Methods

Rating	Name	Size	Complexity
A	__construct()	3	1
B	show_user_profile()	36	3
A	edit_user_profile_update()	9	2

<?php

/**
 * The dashboard-specific functionality of the plugin.
 *
 * @link       https://log.pt
 * @since      1.0.0
 *
 * @package    RedmineEmbed
 * @subpackage RedmineEmbed/Admin
 */

namespace logoscon\WP\RedmineEmbed\Admin;

use logoscon\WP\RedmineEmbed\Plugin;

/**
 * The dashboard-specific functionality of the plugin.
 *
 * Defines the plugin name, version, and two examples hooks for how to
 * enqueue the dashboard-specific stylesheet and JavaScript.
 *
 * @package    RedmineEmbed
 * @subpackage RedmineEmbed/Admin
 * @author     log.OSCON, Lda. <[email protected]>
 */
class UserSettings {

	/**
	 * The plugin's instance.
	 *
	 * @since  1.0.0
	 * @access private
	 * @var    Plugin $plugin This plugin's instance.
	 */
	private $plugin;

	/**
	 * Initialize the class and set its properties.
	 *
	 * @since 1.0.0
	 *
	 * @param Plugin $plugin This plugin's instance.
	 */
	public function __construct( Plugin $plugin ) {
		$this->plugin = $plugin;
	}

	/**
	 * Display the user profile form field.
	 *
	 * @param  \WP_User $user User instance.
	 */
	public function show_user_profile( \WP_User $user ) {
		$url = $this->plugin->get_option( 'root_url', '' );

		if ( empty( $url ) ) {
			return;
		}

		if ( ! \current_user_can( 'edit_user', $user->ID ) ) {
			return;
		}

		$api_key = \get_user_option( 'redmine_embed_api_key', $user->ID );

		?>
		<h3><?php \_e( 'Redmine', 'redmine-embed' ); ?></h3>
		<table class="form-table">
			<tr>
				<th><label for="redmine_embed_api_key"><?php
					\_e( 'API Key', 'redmine-embed' );
				?></label></th>
				<td>
					<input type="text" name="redmine_embed_api_key"
						id="redmine_embed_api_key" class="regular-text"
						value="<?php echo \esc_attr( $api_key ); ?>">
					<br>
					<span class="description"><?php
						printf(
							\__( 'Enter your API key for the Redmine install at %s. It may be found on the right-hand pane of your account page.', 'redmine-embed' ),
							\esc_url( $url )
						);
					?></span>
				</td>
			</tr>
		</table>
		<?php
	}

	/**
	 * Update saved fields on the edited user profile.
	 * @param int $user_id Edited user ID.
	 */
	public function edit_user_profile_update( $user_id ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		if ( ! \current_user_can( 'edit_user', $user_id ) ) {
			return;
		}

		$api_key = \sanitize_key( $_POST['redmine_embed_api_key'] );

		\update_user_option( $user_id, 'redmine_embed_api_key', $api_key );
	}

}


1			<?php
2
3			/**
4			* The dashboard-specific functionality of the plugin.
5			*
6			* @link https://log.pt
7			* @since 1.0.0
8			*
9			* @package RedmineEmbed
10			* @subpackage RedmineEmbed/Admin
11			*/
12
13			namespace logoscon\WP\RedmineEmbed\Admin;
14
15			use logoscon\WP\RedmineEmbed\Plugin;
16
17			/**
18			* The dashboard-specific functionality of the plugin.
19			*
20			* Defines the plugin name, version, and two examples hooks for how to
21			* enqueue the dashboard-specific stylesheet and JavaScript.
22			*
23			* @package RedmineEmbed
24			* @subpackage RedmineEmbed/Admin
25			* @author log.OSCON, Lda. <[email protected]>
26			*/
27			class UserSettings {
28
29			/**
30			* The plugin's instance.
31			*
32			* @since 1.0.0
33			* @access private
34			* @var Plugin $plugin This plugin's instance.
35			*/
36			private $plugin;
37
38			/**
39			* Initialize the class and set its properties.
40			*
41			* @since 1.0.0
42			*
43			* @param Plugin $plugin This plugin's instance.
44			*/
45			public function __construct( Plugin $plugin ) {
46			$this->plugin = $plugin;
47			}
48
49			/**
50			* Display the user profile form field.
51			*
52			* @param \WP_User $user User instance.
53			*/
54			public function show_user_profile( \WP_User $user ) {
55			$url = $this->plugin->get_option( 'root_url', '' );
56
57			if ( empty( $url ) ) {
58			return;
59			}
60
61			if ( ! \current_user_can( 'edit_user', $user->ID ) ) {
62			return;
63			}
64
65			$api_key = \get_user_option( 'redmine_embed_api_key', $user->ID );
66
67			?>
68			<h3><?php \_e( 'Redmine', 'redmine-embed' ); ?></h3>
69			<table class="form-table">
70			<tr>
71			<th><label for="redmine_embed_api_key"><?php
72			\_e( 'API Key', 'redmine-embed' );
73			?></label></th>
74			<td>
75			<input type="text" name="redmine_embed_api_key"
76			id="redmine_embed_api_key" class="regular-text"
77			value="<?php echo \esc_attr( $api_key ); ?>">
78			<br>
79			<span class="description"><?php
80			printf(
81			\__( 'Enter your API key for the Redmine install at %s. It may be found on the right-hand pane of your account page.', 'redmine-embed' ),
82			\esc_url( $url )
83			);
84			?></span>
85			</td>
86			</tr>
87			</table>
88			<?php
89			}
90
91			/**
92			* Update saved fields on the edited user profile.
93			* @param int $user_id Edited user ID.
94			*/
95			public function edit_user_profile_update( $user_id ) {
			0 ignored issues – show Coding Style introduced 2016-02-18 21:00 UTC by Report Bug Copy Issue Report `edit_user_profile_update` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
96			if ( ! \current_user_can( 'edit_user', $user_id ) ) {
97			return;
98			}
99
100			$api_key = \sanitize_key( $_POST['redmine_embed_api_key'] );
101
102			\update_user_option( $user_id, 'redmine_embed_api_key', $api_key );
103			}
104
105			}
106

log-oscon / redmine-embed

UserSettings A last analyzed 2016-02-19 15:02 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

UserSettings A
last analyzed 2016-02-19 15:02 UTC