CountryMappingController::updateResponse() - Code Metrics - Inspection of "coding..." - loevgaard/pakkelabels-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e0d2a4...2983b4 )

by Joachim

created 2017-10-23 08:31 UTC

CountryMappingController::updateResponse() A

↳ Parent: CountryMappingController

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	2

<?php

namespace Loevgaard\DandomainAltapayBundle\Controller;

use Loevgaard\DandomainAltapayBundle\Form\CountryMappingType;
use Loevgaard\PakkelabelsBundle\Entity\CountryMapping;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Form\Form;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * @Route("/country-mapping")
 */
class CountryMappingController extends Controller
{
    /**
     * @Method("GET")
     * @Route("", name="loevgaard_pakkelabels_country_mapping_index")
     *
     * @param Request $request
     *
     * @return Response
     */
    public function indexAction(Request $request)

    {
        /** @var CountryMapping[] $countryMappings */
        $countryMappings = $this->get('doctrine')
            ->getManager()
            ->getRepository('LoevgaardPakkelabelsBundle:CountryMapping')
            ->findAll();

        return $this->render('@LoevgaardPakkelabels/country_mapping/index.html.twig', [
            'countryMappings' => $countryMappings,
        ]);
    }

    /**
     * @Method("GET")
     * @Route("/{id}/show", name="loevgaard_pakkelabels_country_mapping_show")
     *
     * @param CountryMapping $countryMapping
     *
     * @return Response
     */
    public function showAction(CountryMapping $countryMapping)
    {
        return $this->render('@LoevgaardPakkelabels/country_mapping/show.html.twig', [
            'countryMapping' => $countryMapping,
        ]);
    }

    /**
     * @Method({"GET", "POST"})
     * @Route("/new", name="loevgaard_pakkelabels_country_mapping_new")
     *
     * @param Request $request
     *
     * @return Response
     */
    public function newAction(Request $request)

    {
        $countryMapping = new CountryMapping();
        $form = $this->getForm($countryMapping);
        $res = $this->handleUpdate($form, $countryMapping, $request);
        if($res) {
            return $res;
        }

        return $this->updateResponse($countryMapping, $form);
    }

    /**
     * @Method({"GET", "POST"})
     * @Route("/{id}/edit", name="loevgaard_pakkelabels_country_mapping_edit")
     *
     * @param CountryMapping $countryMapping
     * @param Request $request
     *
     * @return Response
     */
    public function editAction(CountryMapping $countryMapping, Request $request)

    {
        $form = $this->getForm($countryMapping);
        $res = $this->handleUpdate($form, $countryMapping, $request);
        if($res) {
            return $res;
        }

        return $this->updateResponse($countryMapping, $form);
    }

    /**
     * @param Form $form
     * @param CountryMapping $countryMapping
     * @param Request $request
     * @return null|RedirectResponse
     */
    private function handleUpdate(Form $form, CountryMapping $countryMapping, Request $request)
    {
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            $new = is_null($countryMapping->getId());

            $em = $this->getDoctrine()->getManager();
            $em->persist($countryMapping);
            $em->flush();

            $translator = $this->get('translator');

            $this->addFlash(
                'success',
                $new ?
                    $translator->trans('country_mapping.new.created', [], 'LoevgaardPakkelabelsBundle') :
                    $translator->trans('country_mapping.edit.updated', [], 'LoevgaardPakkelabelsBundle')
            );

            return $this->redirectToRoute('loevgaard_pakkelabels_country_mapping_edit', [
                'id' => $countryMapping->getId()
            ]);
        }

        return null;
    }

    /**
     * @param CountryMapping $countryMapping
     * @param Form $form
     * @return Response
     */
    private function updateResponse(CountryMapping $countryMapping, Form $form) : Response
    {
        return $this->render('@LoevgaardPakkelabels/country_mapping/edit.html.twig', [
            'countryMapping' => $countryMapping,
            'form' => $form
        ]);
    }

    /**
     * @param CountryMapping $countryMapping
     * @return Form
     */
    private function getForm(CountryMapping $countryMapping) : Form
    {
        return $form = $this->createForm(CountryMappingType::class, $countryMapping);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

}


1		<?php
2
3		namespace Loevgaard\DandomainAltapayBundle\Controller;
4
5		use Loevgaard\DandomainAltapayBundle\Form\CountryMappingType;
6		use Loevgaard\PakkelabelsBundle\Entity\CountryMapping;
7		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
8		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
10		use Symfony\Component\Form\Form;
11		use Symfony\Component\HttpFoundation\RedirectResponse;
12		use Symfony\Component\HttpFoundation\Request;
13		use Symfony\Component\HttpFoundation\Response;
14
15		/**
16		* @Route("/country-mapping")
17		*/
18		class CountryMappingController extends Controller
19		{
20		/**
21		* @Method("GET")
22		* @Route("", name="loevgaard_pakkelabels_country_mapping_index")
23		*
24		* @param Request $request
25		*
26		* @return Response
27		*/
28		public function indexAction(Request $request)
		0 ignored issues – show Unused Code introduced 2017-10-23 08:46 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
29		{
30		/** @var CountryMapping[] $countryMappings */
31		$countryMappings = $this->get('doctrine')
32		->getManager()
33		->getRepository('LoevgaardPakkelabelsBundle:CountryMapping')
34		->findAll();
35
36		return $this->render('@LoevgaardPakkelabels/country_mapping/index.html.twig', [
37		'countryMappings' => $countryMappings,
38		]);
39		}
40
41		/**
42		* @Method("GET")
43		* @Route("/{id}/show", name="loevgaard_pakkelabels_country_mapping_show")
44		*
45		* @param CountryMapping $countryMapping
46		*
47		* @return Response
48		*/
49		public function showAction(CountryMapping $countryMapping)
50		{
51		return $this->render('@LoevgaardPakkelabels/country_mapping/show.html.twig', [
52		'countryMapping' => $countryMapping,
53		]);
54		}
55
56		/**
57		* @Method({"GET", "POST"})
58		* @Route("/new", name="loevgaard_pakkelabels_country_mapping_new")
59		*
60		* @param Request $request
61		*
62		* @return Response
63		*/
64	View Code Duplication	public function newAction(Request $request)
		0 ignored issues – show Duplication introduced 2017-10-23 08:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		{
66		$countryMapping = new CountryMapping();
67		$form = $this->getForm($countryMapping);
68		$res = $this->handleUpdate($form, $countryMapping, $request);
69		if($res) {
70		return $res;
71		}
72
73		return $this->updateResponse($countryMapping, $form);
74		}
75
76		/**
77		* @Method({"GET", "POST"})
78		* @Route("/{id}/edit", name="loevgaard_pakkelabels_country_mapping_edit")
79		*
80		* @param CountryMapping $countryMapping
81		* @param Request $request
82		*
83		* @return Response
84		*/
85	View Code Duplication	public function editAction(CountryMapping $countryMapping, Request $request)
		0 ignored issues – show Duplication introduced 2017-10-23 08:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86		{
87		$form = $this->getForm($countryMapping);
88		$res = $this->handleUpdate($form, $countryMapping, $request);
89		if($res) {
90		return $res;
91		}
92
93		return $this->updateResponse($countryMapping, $form);
94		}
95
96		/**
97		* @param Form $form
98		* @param CountryMapping $countryMapping
99		* @param Request $request
100		* @return null\|RedirectResponse
101		*/
102		private function handleUpdate(Form $form, CountryMapping $countryMapping, Request $request)
103		{
104		$form->handleRequest($request);
105
106		if ($form->isSubmitted() && $form->isValid()) {
107		$new = is_null($countryMapping->getId());
108
109		$em = $this->getDoctrine()->getManager();
110		$em->persist($countryMapping);
111		$em->flush();
112
113		$translator = $this->get('translator');
114
115		$this->addFlash(
116		'success',
117		$new ?
118		$translator->trans('country_mapping.new.created', [], 'LoevgaardPakkelabelsBundle') :
119		$translator->trans('country_mapping.edit.updated', [], 'LoevgaardPakkelabelsBundle')
120		);
121
122		return $this->redirectToRoute('loevgaard_pakkelabels_country_mapping_edit', [
123		'id' => $countryMapping->getId()
124		]);
125		}
126
127		return null;
128		}
129
130		/**
131		* @param CountryMapping $countryMapping
132		* @param Form $form
133		* @return Response
134		*/
135		private function updateResponse(CountryMapping $countryMapping, Form $form) : Response
136		{
137		return $this->render('@LoevgaardPakkelabels/country_mapping/edit.html.twig', [
138		'countryMapping' => $countryMapping,
139		'form' => $form
140		]);
141		}
142
143		/**
144		* @param CountryMapping $countryMapping
145		* @return Form
146		*/
147		private function getForm(CountryMapping $countryMapping) : Form
148		{
149		return $form = $this->createForm(CountryMappingType::class, $countryMapping);
		0 ignored issues – show Unused Code introduced 2017-10-23 08:46 UTC by Report Bug Copy Issue Report `$form` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
150		}
151
152		}
153

loevgaard / pakkelabels-bundle

Push — master ( e0d2a4...2983b4 )

CountryMappingController::updateResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like