Message::length() - Code Metrics - Inspection of "refactored a LOT" - loevgaard/linkmobility-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8f139f...a8687a )

by Joachim

created 2018-02-01 22:53 UTC

Message::length() A

↳ Parent: Message

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	0
cts	14
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	9
nc	4
nop	0
crap	20

<?php declare(strict_types = 1);
namespace Loevgaard\Linkmobility\ValueObject;

use Loevgaard\Linkmobility\GSM7\GSM7;

class Message extends StringValueObject
{
    /**
     * @var bool
     */
    private $gsm7;

    public function chunkCount() : int
    {
        $length = $this->length();
        $lengthThreshold = $this->isGsm7() ? 160 : 70;

        if ($length > $lengthThreshold) {
            $chunkDivisor = $this->isGsm7() ? 153 : 67;
            return (int)ceil($length / $chunkDivisor);
        }

        return 1;
    }

    public function length() : int
    {
        $length = mb_strlen($this->value);

        if (!$this->isGsm7()) {
            return $length;
        }

        $doubles = GSM7::DOUBLES;

        for ($i = 0; $i < $length; $i++) {
            if (in_array($this->value[$i], $doubles)) {
                $length++;
            }
        }

        return $length;
    }

    public function isGsm7() : bool
    {
        if (is_null($this->gsm7)) {
            $this->gsm7 = GSM7::isGSM7($this->value);
        }

        return $this->gsm7;
    }
}


1			<?php declare(strict_types = 1);
2			namespace Loevgaard\Linkmobility\ValueObject;
3
4			use Loevgaard\Linkmobility\GSM7\GSM7;
5
6			class Message extends StringValueObject
7			{
8			/**
9			* @var bool
10			*/
11			private $gsm7;
12
13			public function chunkCount() : int
14			{
15			$length = $this->length();
16			$lengthThreshold = $this->isGsm7() ? 160 : 70;
17
18			if ($length > $lengthThreshold) {
19			$chunkDivisor = $this->isGsm7() ? 153 : 67;
20			return (int)ceil($length / $chunkDivisor);
21			}
22
23			return 1;
24			}
25
26			public function length() : int
27			{
28			$length = mb_strlen($this->value);
29
30			if (!$this->isGsm7()) {
31			return $length;
32			}
33
34			$doubles = GSM7::DOUBLES;
35
36			for ($i = 0; $i < $length; $i++) {
37			if (in_array($this->value[$i], $doubles)) {
38			$length++;
39			}
40			}
41
42			return $length;
43			}
44
45			public function isGsm7() : bool
46			{
47			if (is_null($this->gsm7)) {
48			$this->gsm7 = GSM7::isGSM7($this->value);
49			}
50
51			return $this->gsm7;
52			}
53			}
54

loevgaard / linkmobility-php-sdk

Push — master ( 8f139f...a8687a )

Message::length() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like