ConsignmentService::configureOptions() - Code Metrics - Inspection of "simplified options configuration" - loevgaard/dandomain-consignment-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e17e1f...f6fd3a )

by Joachim

created 2018-03-14 11:46 UTC

ConsignmentService::configureOptions() A

↳ Parent: ConsignmentService

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	0
cts	17
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	13
nc	1
nop	1
crap	2

<?php

declare(strict_types=1);

namespace Loevgaard\DandomainConsignmentBundle\ConsignmentService;

use Doctrine\Common\Persistence\ManagerRegistry;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\OptimisticLockException;
use Doctrine\ORM\ORMException;
use Doctrine\ORM\QueryBuilder;
use Loevgaard\DandomainConsignment\Entity\Generated\ReportInterface;
use Loevgaard\DandomainConsignment\Entity\Report;
use Loevgaard\DandomainConsignment\Repository\ReportRepository;
use Loevgaard\DandomainConsignmentBundle\Exception\InvalidBarCodeException;
use Loevgaard\DandomainConsignmentBundle\Exception\InvalidVendorNumberException;
use Loevgaard\DandomainFoundation\Entity\Generated\ManufacturerInterface;
use Loevgaard\DandomainStock\Entity\Generated\StockMovementInterface;
use Loevgaard\DandomainStock\Entity\StockMovement;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;
use Symfony\Component\OptionsResolver\OptionsResolver;

abstract class ConsignmentService implements ConsignmentServiceInterface
{
    /**
     * @var EntityManager
     */
    protected $entityManager;

    /**
     * @var ReportRepository
     */
    protected $reportRepository;

    /**
     * The directory where report files will be saved.
     *
     * @var string
     */
    protected $reportDir;

    /**
     * @var LoggerInterface
     */
    protected $logger;

    /**
     * @var ManufacturerInterface
     */
    protected $manufacturer;

    /**
     * Contains the included product ids.
     *
     * @var array
     */
    protected $includedProductIds;

    /**
     * Contains the excluded product ids.
     *
     * @var array
     */
    protected $excludedProductIds;

    public function __construct(ManagerRegistry $managerRegistry, ReportRepository $reportRepository, string $reportDir)
    {
        $this->entityManager = $managerRegistry->getManager();
        $this->reportRepository = $reportRepository;
        $this->reportDir = rtrim($reportDir, '/');
        $this->logger = new NullLogger();

        if (!is_dir($this->reportDir)) {
            throw new \InvalidArgumentException('The report dir given is not a directory');
        }

        if (!is_writable($this->reportDir)) {
            throw new \InvalidArgumentException('The report dir given is not writable');
        }
    }

    /**
     * @param array $options
     *
     * @return ReportInterface
     *
     * @throws ORMException
     */
    public function generateReport(array $options = []): ReportInterface
    {
        // resolve options
        $resolver = new OptionsResolver();
        $this->configureOptions($resolver);
        $options = $resolver->resolve($options);

        $report = new Report();
        $report->setManufacturer($this->manufacturer);

        $this->reportRepository->persist($report);

        try {
            if ($options['valid_bar_codes']) {
                $this->validateBarCodes();
            }

            if ($options['valid_vendor_numbers']) {
                $this->validateVendorNumbers();
            }

            $qb = $this->queryBuilder($options);

            /** @var StockMovementInterface[] $stockMovements */
            $stockMovements = $qb->getQuery()->getResult();

            if (!count($stockMovements)) {
                throw new \Exception('No stock movements applicable for this report');
            }

            $lastStockMovement = null;
            foreach ($stockMovements as $stockMovement) {
                $report->addStockMovement($stockMovement);

                $lastStockMovement = $stockMovement;
            }

            if ($lastStockMovement && $options['update_last_stock_movement']) {
                $this->manufacturer->setConsignmentLastStockMovement($lastStockMovement);
            }

            $report->markAsSuccess();
        } catch (\Exception $e) {
            $report->markAsError($e->getMessage());
        }

        $this->reportRepository->flush();

        return $report;
    }

    /**
     * @param ReportInterface $report
     * @param array           $options
     *
     * @return \SplFileObject
     *
     * @throws ORMException
     * @throws OptimisticLockException
     */
    public function generateReportFile(ReportInterface $report, array $options = []): \SplFileObject
    {
        $file = $this->getFile();

        foreach ($report->getStockMovements() as $stockMovement) {
            $file->fputcsv([
                $stockMovement->getQuantity(),
                $stockMovement->getProduct()->getBarCodeNumber(),
            ]);
        }

        $report->setFile($file);

        $this->reportRepository->flush();

        return $file;
    }

    /**
     * @param ReportInterface $report
     * @param array           $options
     *
     * @return bool
     *
     * @throws ORMException
     * @throws OptimisticLockException
     */
    public function deliverReport(ReportInterface $report, array $options = []): bool
    {
        if (!$report->isDeliverable()) {
            return false;
        }

        $file = $report->getFile();
        if (!$file || !$file->isFile()) {
            $file = $this->generateReportFile($report);
        }

        $this->logger->info('File has been delivered to: '.$file->getPathname());

        /*

        Example of mailing the report
        -------
        $recipients = ['[email protected]'];

        $attachment = \Swift_Attachment::fromPath($file->getPathname());
        $attachment->setFilename('report-'.$report->getId().'.csv');

        $message = \Swift_Message::newInstance()
            ->attach($attachment)
            ->setSubject('Consignment report (id: '.$report->getId().')')
            ->setFrom('[email protected]', 'Your Business')
            ->setTo($recipients)
            ->setBody('See the attached file.', 'text/plain')
        ;

        $this->mailer->send($message);
        */

        return true;
    }

    public function queryBuilder(array $options = [], string $alias = 's'): QueryBuilder
    {
        // resolve options
        $resolver = new OptionsResolver();
        $this->configureOptions($resolver);
        $options = $resolver->resolve($options);

        $includedProductIds = $this->getIncludedProductIds();

        if (!count($includedProductIds)) {
            throw new \RuntimeException('No included product ids. Something is wrong');
        }

        $qb = $this->entityManager->createQueryBuilder();
        $qb->select('s, p')
            ->from('Loevgaard\DandomainStock\Entity\StockMovement', 's')
            ->join('s.product', 'p')
            ->andWhere($qb->expr()->in('p.id', ':includedProductIds'))
            ->andWhere($qb->expr()->in('s.type', ':stockMovementTypes'))
            ->addOrderBy('s.id', 'asc')
            ->setParameters([
                'includedProductIds' => $includedProductIds,
                'stockMovementTypes' => $options['stock_movement_types'],
            ]);

        if (!$options['include_complaints']) {
            $qb->andWhere('s.complaint = 0');
        }

        if ($options['use_last_stock_movement'] && $this->manufacturer->getConsignmentLastStockMovement()) {
            $qb->andWhere($qb->expr()->gt('s.id', ':lastStockMovementId'))
                ->setParameter('lastStockMovementId', $this->manufacturer->getConsignmentLastStockMovement()->getId());
        }

        if ($options['start_date']) {
            $qb->andWhere($qb->expr()->gte('s.createdAt', ':startDate'))
                ->setParameter('startDate', $options['start_date']);
        }

        if ($options['end_date']) {
            $qb->andWhere($qb->expr()->lte('s.createdAt', ':endDate'))
                ->setParameter('endDate', $options['end_date']);
        }

        return $qb;
    }

    public function getProductQueryBuilder(string $alias = 'p'): QueryBuilder
    {
        $excludedProductIds = $this->getExcludedProductIds();

        $qb = $this->entityManager->createQueryBuilder();
        $qb->select($alias)
            ->from('Loevgaard\DandomainFoundation\Entity\Product', $alias)
            ->where($qb->expr()->isMemberOf(':manufacturer', $alias.'.manufacturers'))
            ->setParameter('manufacturer', $this->manufacturer);

        if (!empty($excludedProductIds)) {
            $qb->andWhere($qb->expr()->notIn($alias.'.id', ':excluded'))
                ->setParameter('excluded', $excludedProductIds);
        }

        return $qb;
    }

    /**
     * @param LoggerInterface $logger
     *
     * @return ConsignmentServiceInterface
     */
    public function setLogger(LoggerInterface $logger): ConsignmentServiceInterface
    {
        $this->logger = $logger;

        return $this;
    }

    /**
     * @param ManufacturerInterface $manufacturer
     *
     * @return ConsignmentServiceInterface
     */
    public function setManufacturer(ManufacturerInterface $manufacturer): ConsignmentServiceInterface
    {
        $this->manufacturer = $manufacturer;

        return $this;
    }

    /**
     * This method should return an array of included product ids
     * It excludes the excluded product ids, by using the getProductQueryBuilder method.
     *
     * @return array
     */
    protected function getIncludedProductIds(): array
    {
        if (!$this->includedProductIds) {

            $qb = $this->getProductQueryBuilder();
            $qb->select('p.id');

            $res = $qb->getQuery()->getArrayResult();

            $this->includedProductIds = array_map(function ($elm) {
                return array_values($elm)[0];
            }, $res);
        }

        return $this->includedProductIds;
    }

    /**
     * This method should return an array of excluded product ids.
     *
     * @return array
     */
    protected function getExcludedProductIds(): array
    {
        return [];
    }

    /**
     * This is a helper method which takes an array of product numbers and returns their respective product ids.
     *
     * @param array $numbers
     *
     * @return array
     */
    protected function getProductIdsFromProductNumbers(array $numbers): array
    {
        $qb = $this->entityManager->createQueryBuilder();
        $qb->select('p.id')
            ->from('Loevgaard\DandomainFoundation\Entity\Product', 'p')
            ->where($qb->expr()->in('p.number', ':numbers'))
            ->setParameter('numbers', $numbers);

        $res = $qb->getQuery()->getArrayResult();

        return array_map(function ($elm) {
            return array_values($elm)[0];
        }, $res);
    }

    /**
     * @throws InvalidBarCodeException
     */
    protected function validateBarCodes(): void
    {
        $qb = $this->queryBuilder();
        $qb->andWhere('p.validBarCode = 0');

        /** @var StockMovementInterface[] $stockMovements */
        $stockMovements = $qb->getQuery()->getResult();

        $c = count($stockMovements);

        if ($c) {

            $this->logger->emergency('There are '.$c.' stock movements with invalid bar codes');
            $productNumbers = [];
            foreach ($stockMovements as $stockMovement) {
                $productNumbers[] = $stockMovement->getProduct()->getNumber();
            }

            throw new InvalidBarCodeException('Products with invalid bar codes: '.join(', ', $productNumbers), $productNumbers);
        }
    }

    /**
     * @throws InvalidVendorNumberException
     */
    protected function validateVendorNumbers(): void
    {
        $qb = $this->queryBuilder();
        $qb->andWhere($qb->expr()->orX(
            $qb->expr()->eq('p.vendorNumber', ':empty'),
            $qb->expr()->isNull('p.vendorNumber')
        ))->setParameter(':empty', '');

        /** @var StockMovementInterface[] $stockMovements */
        $stockMovements = $qb->getQuery()->getResult();

        $c = count($stockMovements);

        if ($c) {

            $this->logger->critical('There are '.$c.' stock movements with invalid vendor numbers');
            $productNumbers = [];
            foreach ($stockMovements as $stockMovement) {
                $productNumbers[] = $stockMovement->getProduct()->getNumber();
            }

            throw new InvalidVendorNumberException('Products with invalid vendor numbers: '.join($productNumbers), $productNumbers);
        }
    }

    protected function getFile(string $extension = 'csv'): \SplFileObject
    {
        do {
            $filename = $this->reportDir.'/'.uniqid('consignment-', true).'.'.$extension;
        } while (file_exists($filename));

        return new \SplFileObject($filename, 'w+');
    }

    protected function configureOptions(OptionsResolver $resolver): void
    {
        $resolver->setDefaults([
            'valid_bar_codes' => false,
            'valid_vendor_numbers' => false,
            'update_last_stock_movement' => true,
            'stock_movement_types' => [
                StockMovement::TYPE_RETURN,
                StockMovement::TYPE_SALE,
                StockMovement::TYPE_REGULATION,
            ],
            'include_complaints' => false,
            'use_last_stock_movement' => true,
            'start_date' => null,
            'end_date' => null,
        ]);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Loevgaard\DandomainConsignmentBundle\ConsignmentService;
6
7		use Doctrine\Common\Persistence\ManagerRegistry;
8		use Doctrine\ORM\EntityManager;
9		use Doctrine\ORM\OptimisticLockException;
10		use Doctrine\ORM\ORMException;
11		use Doctrine\ORM\QueryBuilder;
12		use Loevgaard\DandomainConsignment\Entity\Generated\ReportInterface;
13		use Loevgaard\DandomainConsignment\Entity\Report;
14		use Loevgaard\DandomainConsignment\Repository\ReportRepository;
15		use Loevgaard\DandomainConsignmentBundle\Exception\InvalidBarCodeException;
16		use Loevgaard\DandomainConsignmentBundle\Exception\InvalidVendorNumberException;
17		use Loevgaard\DandomainFoundation\Entity\Generated\ManufacturerInterface;
18		use Loevgaard\DandomainStock\Entity\Generated\StockMovementInterface;
19		use Loevgaard\DandomainStock\Entity\StockMovement;
20		use Psr\Log\LoggerInterface;
21		use Psr\Log\NullLogger;
22		use Symfony\Component\OptionsResolver\OptionsResolver;
23
24		abstract class ConsignmentService implements ConsignmentServiceInterface
25		{
26		/**
27		* @var EntityManager
28		*/
29		protected $entityManager;
30
31		/**
32		* @var ReportRepository
33		*/
34		protected $reportRepository;
35
36		/**
37		* The directory where report files will be saved.
38		*
39		* @var string
40		*/
41		protected $reportDir;
42
43		/**
44		* @var LoggerInterface
45		*/
46		protected $logger;
47
48		/**
49		* @var ManufacturerInterface
50		*/
51		protected $manufacturer;
52
53		/**
54		* Contains the included product ids.
55		*
56		* @var array
57		*/
58		protected $includedProductIds;
59
60		/**
61		* Contains the excluded product ids.
62		*
63		* @var array
64		*/
65		protected $excludedProductIds;
66
67		public function __construct(ManagerRegistry $managerRegistry, ReportRepository $reportRepository, string $reportDir)
68		{
69		$this->entityManager = $managerRegistry->getManager();
70		$this->reportRepository = $reportRepository;
71		$this->reportDir = rtrim($reportDir, '/');
72		$this->logger = new NullLogger();
73
74		if (!is_dir($this->reportDir)) {
75		throw new \InvalidArgumentException('The report dir given is not a directory');
76		}
77
78		if (!is_writable($this->reportDir)) {
79		throw new \InvalidArgumentException('The report dir given is not writable');
80		}
81		}
82
83		/**
84		* @param array $options
85		*
86		* @return ReportInterface
87		*
88		* @throws ORMException
89		*/
90		public function generateReport(array $options = []): ReportInterface
91		{
92		// resolve options
93		$resolver = new OptionsResolver();
94		$this->configureOptions($resolver);
95		$options = $resolver->resolve($options);
96
97		$report = new Report();
98		$report->setManufacturer($this->manufacturer);
99
100		$this->reportRepository->persist($report);
101
102		try {
103		if ($options['valid_bar_codes']) {
104		$this->validateBarCodes();
105		}
106
107		if ($options['valid_vendor_numbers']) {
108		$this->validateVendorNumbers();
109		}
110
111		$qb = $this->queryBuilder($options);
112
113		/** @var StockMovementInterface[] $stockMovements */
114		$stockMovements = $qb->getQuery()->getResult();
115
116		if (!count($stockMovements)) {
117		throw new \Exception('No stock movements applicable for this report');
118		}
119
120		$lastStockMovement = null;
121		foreach ($stockMovements as $stockMovement) {
122		$report->addStockMovement($stockMovement);
123
124		$lastStockMovement = $stockMovement;
125		}
126
127		if ($lastStockMovement && $options['update_last_stock_movement']) {
128		$this->manufacturer->setConsignmentLastStockMovement($lastStockMovement);
129		}
130
131		$report->markAsSuccess();
132		} catch (\Exception $e) {
133		$report->markAsError($e->getMessage());
134		}
135
136		$this->reportRepository->flush();
137
138		return $report;
139		}
140
141		/**
142		* @param ReportInterface $report
143		* @param array $options
144		*
145		* @return \SplFileObject
146		*
147		* @throws ORMException
148		* @throws OptimisticLockException
149		*/
150		public function generateReportFile(ReportInterface $report, array $options = []): \SplFileObject
151		{
152		$file = $this->getFile();
153
154		foreach ($report->getStockMovements() as $stockMovement) {
155		$file->fputcsv([
156		$stockMovement->getQuantity(),
157		$stockMovement->getProduct()->getBarCodeNumber(),
158		]);
159		}
160
161		$report->setFile($file);
162
163		$this->reportRepository->flush();
164
165		return $file;
166		}
167
168		/**
169		* @param ReportInterface $report
170		* @param array $options
171		*
172		* @return bool
173		*
174		* @throws ORMException
175		* @throws OptimisticLockException
176		*/
177		public function deliverReport(ReportInterface $report, array $options = []): bool
178		{
179		if (!$report->isDeliverable()) {
180		return false;
181		}
182
183		$file = $report->getFile();
184		if (!$file \|\| !$file->isFile()) {
185		$file = $this->generateReportFile($report);
186		}
187
188		$this->logger->info('File has been delivered to: '.$file->getPathname());
189
190		/*
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-02-21 13:12 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
191		Example of mailing the report
192		-------
193		$recipients = ['[email protected]'];
194
195		$attachment = \Swift_Attachment::fromPath($file->getPathname());
196		$attachment->setFilename('report-'.$report->getId().'.csv');
197
198		$message = \Swift_Message::newInstance()
199		->attach($attachment)
200		->setSubject('Consignment report (id: '.$report->getId().')')
201		->setFrom('[email protected]', 'Your Business')
202		->setTo($recipients)
203		->setBody('See the attached file.', 'text/plain')
204		;
205
206		$this->mailer->send($message);
207		*/
208
209		return true;
210		}
211
212		public function queryBuilder(array $options = [], string $alias = 's'): QueryBuilder
213		{
214		// resolve options
215		$resolver = new OptionsResolver();
216		$this->configureOptions($resolver);
217		$options = $resolver->resolve($options);
218
219		$includedProductIds = $this->getIncludedProductIds();
220
221		if (!count($includedProductIds)) {
222		throw new \RuntimeException('No included product ids. Something is wrong');
223		}
224
225		$qb = $this->entityManager->createQueryBuilder();
226		$qb->select('s, p')
227		->from('Loevgaard\DandomainStock\Entity\StockMovement', 's')
228		->join('s.product', 'p')
229		->andWhere($qb->expr()->in('p.id', ':includedProductIds'))
230		->andWhere($qb->expr()->in('s.type', ':stockMovementTypes'))
231		->addOrderBy('s.id', 'asc')
232		->setParameters([
233		'includedProductIds' => $includedProductIds,
234		'stockMovementTypes' => $options['stock_movement_types'],
235		]);
236
237		if (!$options['include_complaints']) {
238		$qb->andWhere('s.complaint = 0');
239		}
240
241		if ($options['use_last_stock_movement'] && $this->manufacturer->getConsignmentLastStockMovement()) {
242		$qb->andWhere($qb->expr()->gt('s.id', ':lastStockMovementId'))
243		->setParameter('lastStockMovementId', $this->manufacturer->getConsignmentLastStockMovement()->getId());
244		}
245
246		if ($options['start_date']) {
247		$qb->andWhere($qb->expr()->gte('s.createdAt', ':startDate'))
248		->setParameter('startDate', $options['start_date']);
249		}
250
251		if ($options['end_date']) {
252		$qb->andWhere($qb->expr()->lte('s.createdAt', ':endDate'))
253		->setParameter('endDate', $options['end_date']);
254		}
255
256		return $qb;
257		}
258
259		public function getProductQueryBuilder(string $alias = 'p'): QueryBuilder
260		{
261		$excludedProductIds = $this->getExcludedProductIds();
262
263		$qb = $this->entityManager->createQueryBuilder();
264		$qb->select($alias)
265		->from('Loevgaard\DandomainFoundation\Entity\Product', $alias)
266		->where($qb->expr()->isMemberOf(':manufacturer', $alias.'.manufacturers'))
267		->setParameter('manufacturer', $this->manufacturer);
268
269		if (!empty($excludedProductIds)) {
270		$qb->andWhere($qb->expr()->notIn($alias.'.id', ':excluded'))
271		->setParameter('excluded', $excludedProductIds);
272		}
273
274		return $qb;
275		}
276
277		/**
278		* @param LoggerInterface $logger
279		*
280		* @return ConsignmentServiceInterface
281		*/
282		public function setLogger(LoggerInterface $logger): ConsignmentServiceInterface
283		{
284		$this->logger = $logger;
285
286		return $this;
287		}
288
289		/**
290		* @param ManufacturerInterface $manufacturer
291		*
292		* @return ConsignmentServiceInterface
293		*/
294		public function setManufacturer(ManufacturerInterface $manufacturer): ConsignmentServiceInterface
295		{
296		$this->manufacturer = $manufacturer;
297
298		return $this;
299		}
300
301		/**
302		* This method should return an array of included product ids
303		* It excludes the excluded product ids, by using the getProductQueryBuilder method.
304		*
305		* @return array
306		*/
307		protected function getIncludedProductIds(): array
308		{
309		if (!$this->includedProductIds) {
		0 ignored issues – show Bug Best Practice introduced 2018-02-21 13:12 UTC by Report Bug Copy Issue Report The expression `$this->includedProductIds` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
310		$qb = $this->getProductQueryBuilder();
311		$qb->select('p.id');
312
313		$res = $qb->getQuery()->getArrayResult();
314
315		$this->includedProductIds = array_map(function ($elm) {
316		return array_values($elm)[0];
317		}, $res);
318		}
319
320		return $this->includedProductIds;
321		}
322
323		/**
324		* This method should return an array of excluded product ids.
325		*
326		* @return array
327		*/
328		protected function getExcludedProductIds(): array
329		{
330		return [];
331		}
332
333		/**
334		* This is a helper method which takes an array of product numbers and returns their respective product ids.
335		*
336		* @param array $numbers
337		*
338		* @return array
339		*/
340		protected function getProductIdsFromProductNumbers(array $numbers): array
341		{
342		$qb = $this->entityManager->createQueryBuilder();
343		$qb->select('p.id')
344		->from('Loevgaard\DandomainFoundation\Entity\Product', 'p')
345		->where($qb->expr()->in('p.number', ':numbers'))
346		->setParameter('numbers', $numbers);
347
348		$res = $qb->getQuery()->getArrayResult();
349
350		return array_map(function ($elm) {
351		return array_values($elm)[0];
352		}, $res);
353		}
354
355		/**
356		* @throws InvalidBarCodeException
357		*/
358		protected function validateBarCodes(): void
359		{
360		$qb = $this->queryBuilder();
361		$qb->andWhere('p.validBarCode = 0');
362
363		/** @var StockMovementInterface[] $stockMovements */
364		$stockMovements = $qb->getQuery()->getResult();
365
366		$c = count($stockMovements);
367
368	View Code Duplication	if ($c) {
		0 ignored issues – show Duplication introduced 2018-02-21 13:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
369		$this->logger->emergency('There are '.$c.' stock movements with invalid bar codes');
370		$productNumbers = [];
371		foreach ($stockMovements as $stockMovement) {
372		$productNumbers[] = $stockMovement->getProduct()->getNumber();
373		}
374
375		throw new InvalidBarCodeException('Products with invalid bar codes: '.join(', ', $productNumbers), $productNumbers);
376		}
377		}
378
379		/**
380		* @throws InvalidVendorNumberException
381		*/
382		protected function validateVendorNumbers(): void
383		{
384		$qb = $this->queryBuilder();
385		$qb->andWhere($qb->expr()->orX(
386		$qb->expr()->eq('p.vendorNumber', ':empty'),
387		$qb->expr()->isNull('p.vendorNumber')
388		))->setParameter(':empty', '');
389
390		/** @var StockMovementInterface[] $stockMovements */
391		$stockMovements = $qb->getQuery()->getResult();
392
393		$c = count($stockMovements);
394
395	View Code Duplication	if ($c) {
		0 ignored issues – show Duplication introduced 2018-02-21 13:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
396		$this->logger->critical('There are '.$c.' stock movements with invalid vendor numbers');
397		$productNumbers = [];
398		foreach ($stockMovements as $stockMovement) {
399		$productNumbers[] = $stockMovement->getProduct()->getNumber();
400		}
401
402		throw new InvalidVendorNumberException('Products with invalid vendor numbers: '.join($productNumbers), $productNumbers);
403		}
404		}
405
406		protected function getFile(string $extension = 'csv'): \SplFileObject
407		{
408		do {
409		$filename = $this->reportDir.'/'.uniqid('consignment-', true).'.'.$extension;
410		} while (file_exists($filename));
411
412		return new \SplFileObject($filename, 'w+');
413		}
414
415		protected function configureOptions(OptionsResolver $resolver): void
416		{
417		$resolver->setDefaults([
418		'valid_bar_codes' => false,
419		'valid_vendor_numbers' => false,
420		'update_last_stock_movement' => true,
421		'stock_movement_types' => [
422		StockMovement::TYPE_RETURN,
423		StockMovement::TYPE_SALE,
424		StockMovement::TYPE_REGULATION,
425		],
426		'include_complaints' => false,
427		'use_last_stock_movement' => true,
428		'start_date' => null,
429		'end_date' => null,
430		]);
431		}
432		}
433

loevgaard / dandomain-consignment-bundle

Push — master ( e17e1f...f6fd3a )

ConsignmentService::configureOptions() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like