Issues in SiteSettingController.php (master) - Issues in master - loevgaard/dandomain-altapay-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (143)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/SiteSettingController.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Loevgaard\DandomainAltapayBundle\Controller;

use Loevgaard\DandomainAltapayBundle\Entity\SiteSetting;
use Loevgaard\DandomainAltapayBundle\Form\SiteSettingType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * @Route("/site-setting")
 */
class SiteSettingController extends Controller
{
    /**
     * @Method("GET")
     * @Route("", name="loevgaard_dandomain_altapay_site_setting_index")
     *
     * @param Request $request
     *
     * @return Response
     */
    public function indexAction(Request $request)

    {
        $repos = $this->get('loevgaard_dandomain_altapay.site_setting_repository');
        $siteSettings = $repos->findAllWithPaging($request->query->getInt('page', 1));

        return $this->render('@LoevgaardDandomainAltapay/site_setting/index.html.twig', [
            'siteSettings' => $siteSettings,
        ]);
    }

    /**
     * @Method("GET")
     * @Route("/{id}/show", name="loevgaard_dandomain_altapay_site_setting_show")
     *
     * @param SiteSetting $siteSetting
     *
     * @return Response
     */
    public function showAction(SiteSetting $siteSetting)
    {
        return $this->render('@LoevgaardDandomainAltapay/site_setting/show.html.twig', [
            'siteSetting' => $siteSetting,
        ]);
    }

    /**
     * @Method({"GET", "POST"})
     * @Route("/new", name="loevgaard_dandomain_altapay_site_setting_new")
     *
     * @param Request $request
     *
     * @return Response
     */
    public function newAction(Request $request)

    {
        $siteSetting = new SiteSetting();
        $form = $this->getForm($siteSetting);
        $res = $this->handleUpdate($form, $siteSetting, $request);
        if ($res) {
            return $res;
        }

        return $this->updateResponse($siteSetting, $form);
    }

    /**
     * @Method({"GET", "POST"})
     * @Route("/{id}/edit", name="loevgaard_dandomain_altapay_site_setting_edit")
     *
     * @param SiteSetting $siteSetting
     * @param Request     $request
     *
     * @return Response
     */
    public function editAction(SiteSetting $siteSetting, Request $request)

    {
        $form = $this->getForm($siteSetting);
        $res = $this->handleUpdate($form, $siteSetting, $request);
        if ($res) {
            return $res;
        }

        return $this->updateResponse($siteSetting, $form);
    }

    /**
     * @param FormInterface $form
     * @param SiteSetting   $siteSetting
     * @param Request       $request
     *
     * @return null|RedirectResponse
     */
    private function handleUpdate(FormInterface $form, SiteSetting $siteSetting, Request $request)
    {
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $em->persist($siteSetting);
            $em->flush();

            $translator = $this->get('translator');

            $this->addFlash('success', $translator->trans('site_setting.edit.updated', [], 'LoevgaardDandomainAltapayBundle'));

            return $this->redirectToRoute('loevgaard_dandomain_altapay_site_setting_edit', [
                'id' => $siteSetting->getId(),
            ]);
        }

        return null;
    }

    /**
     * @param SiteSetting   $siteSetting
     * @param FormInterface $form
     *
     * @return Response
     */
    private function updateResponse(SiteSetting $siteSetting, FormInterface $form): Response
    {
        return $this->render('@LoevgaardDandomainAltapay/site_setting/edit.html.twig', [
            'siteSetting' => $siteSetting,
            'form' => $form->createView(),
        ]);
    }

    /**
     * @param SiteSetting $siteSetting
     *
     * @return FormInterface
     */
    private function getForm(SiteSetting $siteSetting): FormInterface
    {
        return $form = $this->createForm(SiteSettingType::class, $siteSetting);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1		<?php
2
3		namespace Loevgaard\DandomainAltapayBundle\Controller;
4
5		use Loevgaard\DandomainAltapayBundle\Entity\SiteSetting;
6		use Loevgaard\DandomainAltapayBundle\Form\SiteSettingType;
7		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
8		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
10		use Symfony\Component\Form\FormInterface;
11		use Symfony\Component\HttpFoundation\RedirectResponse;
12		use Symfony\Component\HttpFoundation\Request;
13		use Symfony\Component\HttpFoundation\Response;
14
15		/**
16		* @Route("/site-setting")
17		*/
18		class SiteSettingController extends Controller
19		{
20		/**
21		* @Method("GET")
22		* @Route("", name="loevgaard_dandomain_altapay_site_setting_index")
23		*
24		* @param Request $request
25		*
26		* @return Response
27		*/
28	View Code Duplication	public function indexAction(Request $request)
		0 ignored issues – show Duplication introduced 2017-11-01 09:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		$repos = $this->get('loevgaard_dandomain_altapay.site_setting_repository');
31		$siteSettings = $repos->findAllWithPaging($request->query->getInt('page', 1));
32
33		return $this->render('@LoevgaardDandomainAltapay/site_setting/index.html.twig', [
34		'siteSettings' => $siteSettings,
35		]);
36		}
37
38		/**
39		* @Method("GET")
40		* @Route("/{id}/show", name="loevgaard_dandomain_altapay_site_setting_show")
41		*
42		* @param SiteSetting $siteSetting
43		*
44		* @return Response
45		*/
46		public function showAction(SiteSetting $siteSetting)
47		{
48		return $this->render('@LoevgaardDandomainAltapay/site_setting/show.html.twig', [
49		'siteSetting' => $siteSetting,
50		]);
51		}
52
53		/**
54		* @Method({"GET", "POST"})
55		* @Route("/new", name="loevgaard_dandomain_altapay_site_setting_new")
56		*
57		* @param Request $request
58		*
59		* @return Response
60		*/
61	View Code Duplication	public function newAction(Request $request)
		0 ignored issues – show Duplication introduced 2017-10-27 14:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		$siteSetting = new SiteSetting();
64		$form = $this->getForm($siteSetting);
65		$res = $this->handleUpdate($form, $siteSetting, $request);
66		if ($res) {
67		return $res;
68		}
69
70		return $this->updateResponse($siteSetting, $form);
71		}
72
73		/**
74		* @Method({"GET", "POST"})
75		* @Route("/{id}/edit", name="loevgaard_dandomain_altapay_site_setting_edit")
76		*
77		* @param SiteSetting $siteSetting
78		* @param Request $request
79		*
80		* @return Response
81		*/
82	View Code Duplication	public function editAction(SiteSetting $siteSetting, Request $request)
		0 ignored issues – show Duplication introduced 2017-10-27 14:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
83		{
84		$form = $this->getForm($siteSetting);
85		$res = $this->handleUpdate($form, $siteSetting, $request);
86		if ($res) {
87		return $res;
88		}
89
90		return $this->updateResponse($siteSetting, $form);
91		}
92
93		/**
94		* @param FormInterface $form
95		* @param SiteSetting $siteSetting
96		* @param Request $request
97		*
98		* @return null\|RedirectResponse
99		*/
100		private function handleUpdate(FormInterface $form, SiteSetting $siteSetting, Request $request)
101		{
102		$form->handleRequest($request);
103
104		if ($form->isSubmitted() && $form->isValid()) {
105		$em = $this->getDoctrine()->getManager();
106		$em->persist($siteSetting);
107		$em->flush();
108
109		$translator = $this->get('translator');
110
111		$this->addFlash('success', $translator->trans('site_setting.edit.updated', [], 'LoevgaardDandomainAltapayBundle'));
112
113		return $this->redirectToRoute('loevgaard_dandomain_altapay_site_setting_edit', [
114		'id' => $siteSetting->getId(),
115		]);
116		}
117
118		return null;
119		}
120
121		/**
122		* @param SiteSetting $siteSetting
123		* @param FormInterface $form
124		*
125		* @return Response
126		*/
127		private function updateResponse(SiteSetting $siteSetting, FormInterface $form): Response
128		{
129		return $this->render('@LoevgaardDandomainAltapay/site_setting/edit.html.twig', [
130		'siteSetting' => $siteSetting,
131		'form' => $form->createView(),
132		]);
133		}
134
135		/**
136		* @param SiteSetting $siteSetting
137		*
138		* @return FormInterface
139		*/
140		private function getForm(SiteSetting $siteSetting): FormInterface
141		{
142		return $form = $this->createForm(SiteSettingType::class, $siteSetting);
		0 ignored issues – show Unused Code introduced 2017-10-27 14:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$form` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
143		}
144		}
145

loevgaard / dandomain-altapay-bundle

Issues (143)

Security Analysis not enabled

Controller/SiteSettingController.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like