PaymentRepository::findByOrderIdOrAltapayId() - Code Metrics - Inspection of "added bulk operations" - loevgaard/dandomain-altapay-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dfcd91...38e980 )

by Joachim

created 2017-12-06 14:26 UTC

PaymentRepository::findByOrderIdOrAltapayId() A

↳ Parent: PaymentRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	16
rs	9.4285
cc	2
eloc	7
nc	2
nop	1

<?php

namespace Loevgaard\DandomainAltapayBundle\Entity;

class PaymentRepository extends EntityRepository
{
    /**
     * @param $id
     *
     * @return null|Payment
     */
    public function findByOrderIdOrAltapayId($id): ?Payment
    {
        /** @var Payment $payment */
        $payment = $this->findOneBy([
            'orderId' => $id,
        ]);

        if (!$payment) {
            /** @var Payment $payment */
            $payment = $this->findOneBy([
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                'altapayId' => $id,
            ]);
        }

        return $payment;
    }

    /**
     * @param array $ids
     * @return array|Payment[]
     */
    public function findByIds(array $ids) : array
    {
        $qb = $this->getQueryBuilder('p');
        $qb->where($qb->expr()->in('p.id', ':ids'));
        $qb->setParameter('ids', $ids);

        return $qb->getQuery()->getResult();
    }
}


1			<?php
2
3			namespace Loevgaard\DandomainAltapayBundle\Entity;
4
5			class PaymentRepository extends EntityRepository
6			{
7			/**
8			* @param $id
9			*
10			* @return null\|Payment
11			*/
12			public function findByOrderIdOrAltapayId($id): ?Payment
13			{
14			/** @var Payment $payment */
15			$payment = $this->findOneBy([
16			'orderId' => $id,
17			]);
18
19			if (!$payment) {
20			/** @var Payment $payment */
21			$payment = $this->findOneBy([
			0 ignored issues – show Bug introduced 2017-11-01 09:55 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$payment` is correct as `$this->findOneBy(array('altapayId' => $id))` (which targets `Loevgaard\DandomainAltap...Repository::findOneBy()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
22			'altapayId' => $id,
23			]);
24			}
25
26			return $payment;
27			}
28
29			/**
30			* @param array $ids
31			* @return array\|Payment[]
32			*/
33			public function findByIds(array $ids) : array
34			{
35			$qb = $this->getQueryBuilder('p');
36			$qb->where($qb->expr()->in('p.id', ':ids'));
37			$qb->setParameter('ids', $ids);
38
39			return $qb->getQuery()->getResult();
40			}
41			}
42

loevgaard / dandomain-altapay-bundle

Push — master ( dfcd91...38e980 )

PaymentRepository::findByOrderIdOrAltapayId() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like