PaymentRequestPayloadGeneratorTest::getTerminal() - Code Metrics - Inspection of "creating more tests" - loevgaard/dandomain-altapay-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( afa46a...04583c )

by Joachim

created 2017-10-25 12:18 UTC

PaymentRequestPayloadGeneratorTest::getTerminal() A

↳ Parent: PaymentRequestPayloadGeneratorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0

<?php

namespace Loevgaard\DandomainAltapayBundle\Tests\PayloadGenerator;

use Loevgaard\AltaPay\Payload\OrderLine as OrderLinePayload;
use Loevgaard\AltaPay\Payload\PaymentRequest\Config as ConfigPayload;
use Loevgaard\AltaPay\Payload\PaymentRequest\CustomerInfo as CustomerInfoPayload;
use Loevgaard\Dandomain\Pay\Handler;
use Loevgaard\Dandomain\Pay\PaymentRequest as DandomainPaymentRequest;
use Loevgaard\DandomainAltapayBundle\Entity\Payment;
use Loevgaard\DandomainAltapayBundle\Entity\TerminalInterface;
use Loevgaard\DandomainAltapayBundle\Tests\PayloadGenerator\Fixture\Gateway;
use PHPUnit\Framework\TestCase;
use Psr\Http\Message\ServerRequestInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

final class PaymentRequestPayloadGeneratorTest extends TestCase
{
    public function testCreateOrderLine()
    {
        $generator = $this->getGenerator();

        $description = 'description';
        $itemId = 'itemid';
        $quantity = 1.0;
        $unitPrice = 99.95;

        // without optional parameters
        $payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice);
        $this->assertInstanceOf(OrderLinePayload::class, $payload);
        $this->assertSame($description, $payload->getDescription());
        $this->assertSame($itemId, $payload->getItemId());
        $this->assertSame($quantity, $payload->getQuantity());
        $this->assertSame($unitPrice, $payload->getUnitPrice());

        // with tax percent
        $taxPercent = 25.0;
        $payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice, $taxPercent);
        $this->assertInstanceOf(OrderLinePayload::class, $payload);
        $this->assertSame($description, $payload->getDescription());
        $this->assertSame($itemId, $payload->getItemId());
        $this->assertSame($quantity, $payload->getQuantity());
        $this->assertSame($unitPrice, $payload->getUnitPrice());
        $this->assertSame($taxPercent, $payload->getTaxPercent());

        // with goods type
        $goodsType = OrderLinePayload::GOODS_TYPE_ITEM;
        $payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice, null, $goodsType);
        $this->assertInstanceOf(OrderLinePayload::class, $payload);
        $this->assertSame($description, $payload->getDescription());
        $this->assertSame($itemId, $payload->getItemId());
        $this->assertSame($quantity, $payload->getQuantity());
        $this->assertSame($unitPrice, $payload->getUnitPrice());
        $this->assertSame($goodsType, $payload->getGoodsType());
    }

    public function testCreateCustomerInfo()
    {
        $generator = $this->getGenerator();

        $billingFirstName = 'billingfirstname';
        $billingLastName = 'billinglastname';
        $billingAddress = 'billingaddress';
        $billingPostal = 'billingpostal';
        $billingCity = 'billingcity';
        $billingCountry = 'billingcountry';
        $shippingFirstName = 'shippingfirstname';
        $shippingLastName = 'shippinglastname';
        $shippingAddress = 'shippingaddress';
        $shippingPostal = 'shippingpostal';
        $shippingCity = 'shippingcity';
        $shippingCountry = 'shippingcountry';

        // without optional parameters
        $payload = $generator->createCustomerInfo($billingFirstName, $billingLastName, $billingAddress, $billingPostal, $billingCity, $billingCountry, $shippingFirstName, $shippingLastName, $shippingAddress, $shippingPostal, $shippingCity, $shippingCountry);
        $this->assertInstanceOf(CustomerInfoPayload::class, $payload);
        $this->assertSame($billingFirstName, $payload->getBillingFirstName());
        $this->assertSame($billingLastName, $payload->getBillingLastName());
        $this->assertSame($billingAddress, $payload->getBillingAddress());
        $this->assertSame($billingPostal, $payload->getBillingPostal());
        $this->assertSame($billingCity, $payload->getBillingCity());
        $this->assertSame($billingCountry, $payload->getBillingCountry());
        $this->assertSame($shippingFirstName, $payload->getShippingFirstName());
        $this->assertSame($shippingLastName, $payload->getShippingLastName());
        $this->assertSame($shippingAddress, $payload->getShippingAddress());
        $this->assertSame($shippingPostal, $payload->getShippingPostal());
        $this->assertSame($shippingCity, $payload->getShippingCity());
        $this->assertSame($shippingCountry, $payload->getShippingCountry());
    }

    public function testCreateConfig()
    {
        $generator = $this->getGenerator();

        $callbackForm = 'form';
        $callbackOk = 'ok';
        $callbackFail = 'fail';
        $callbackRedirect = 'redirect';
        $callbackOpen = 'open';
        $callbackNotification = 'notification';

        // without optional parameters
        $payload = $generator->createConfig($callbackForm, $callbackOk, $callbackFail, $callbackRedirect, $callbackOpen, $callbackNotification);
        $this->assertInstanceOf(ConfigPayload::class, $payload);
        $this->assertSame($callbackForm, $payload->getCallbackForm());
        $this->assertSame($callbackOk, $payload->getCallbackOk());
        $this->assertSame($callbackFail, $payload->getCallbackFail());
        $this->assertSame($callbackRedirect, $payload->getCallbackRedirect());
        $this->assertSame($callbackOpen, $payload->getCallbackOpen());
        $this->assertSame($callbackNotification, $payload->getCallbackNotification());
    }

    private function getGenerator()
    {
        $container = $this->getContainer();
        $paymentRequest = $this->getPaymentRequest();
        $terminal = $this->getTerminal();
        $payment = $this->getPayment();
        $handler = $this->getHandler();

        $generator = new Gateway($container, $paymentRequest, $terminal, $payment, $handler);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        return $generator;
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|ContainerInterface
     */
    private function getContainer()
    {
        $container = $this->getMockForAbstractClass(ContainerInterface::class);

        return $container;
    }

    private function getPaymentRequest()
    {
        $paymentRequest = new DandomainPaymentRequest();

        return $paymentRequest;
    }

    /**
     * @return TerminalInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private function getTerminal()
    {
        $terminal = $this->getMockForAbstractClass(TerminalInterface::class);

        return $terminal;
    }

    /**
     * @return Payment|\PHPUnit_Framework_MockObject_MockObject
     */
    private function getPayment()
    {
        $payment = $this->getMockForAbstractClass(Payment::class);

        return $payment;
    }

    private function getHandler()
    {
        $request = $this->getMockForAbstractClass(ServerRequestInterface::class);
        $handler = new Handler($request, 'sharedkey1', 'sharedkey2');

        return $handler;
    }
}


1			<?php
2
3			namespace Loevgaard\DandomainAltapayBundle\Tests\PayloadGenerator;
4
5			use Loevgaard\AltaPay\Payload\OrderLine as OrderLinePayload;
6			use Loevgaard\AltaPay\Payload\PaymentRequest\Config as ConfigPayload;
7			use Loevgaard\AltaPay\Payload\PaymentRequest\CustomerInfo as CustomerInfoPayload;
8			use Loevgaard\Dandomain\Pay\Handler;
9			use Loevgaard\Dandomain\Pay\PaymentRequest as DandomainPaymentRequest;
10			use Loevgaard\DandomainAltapayBundle\Entity\Payment;
11			use Loevgaard\DandomainAltapayBundle\Entity\TerminalInterface;
12			use Loevgaard\DandomainAltapayBundle\Tests\PayloadGenerator\Fixture\Gateway;
13			use PHPUnit\Framework\TestCase;
14			use Psr\Http\Message\ServerRequestInterface;
15			use Symfony\Component\DependencyInjection\ContainerInterface;
16
17			final class PaymentRequestPayloadGeneratorTest extends TestCase
18			{
19			public function testCreateOrderLine()
20			{
21			$generator = $this->getGenerator();
22
23			$description = 'description';
24			$itemId = 'itemid';
25			$quantity = 1.0;
26			$unitPrice = 99.95;
27
28			// without optional parameters
29			$payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice);
30			$this->assertInstanceOf(OrderLinePayload::class, $payload);
31			$this->assertSame($description, $payload->getDescription());
32			$this->assertSame($itemId, $payload->getItemId());
33			$this->assertSame($quantity, $payload->getQuantity());
34			$this->assertSame($unitPrice, $payload->getUnitPrice());
35
36			// with tax percent
37			$taxPercent = 25.0;
38			$payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice, $taxPercent);
39			$this->assertInstanceOf(OrderLinePayload::class, $payload);
40			$this->assertSame($description, $payload->getDescription());
41			$this->assertSame($itemId, $payload->getItemId());
42			$this->assertSame($quantity, $payload->getQuantity());
43			$this->assertSame($unitPrice, $payload->getUnitPrice());
44			$this->assertSame($taxPercent, $payload->getTaxPercent());
45
46			// with goods type
47			$goodsType = OrderLinePayload::GOODS_TYPE_ITEM;
48			$payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice, null, $goodsType);
49			$this->assertInstanceOf(OrderLinePayload::class, $payload);
50			$this->assertSame($description, $payload->getDescription());
51			$this->assertSame($itemId, $payload->getItemId());
52			$this->assertSame($quantity, $payload->getQuantity());
53			$this->assertSame($unitPrice, $payload->getUnitPrice());
54			$this->assertSame($goodsType, $payload->getGoodsType());
55			}
56
57			public function testCreateCustomerInfo()
58			{
59			$generator = $this->getGenerator();
60
61			$billingFirstName = 'billingfirstname';
62			$billingLastName = 'billinglastname';
63			$billingAddress = 'billingaddress';
64			$billingPostal = 'billingpostal';
65			$billingCity = 'billingcity';
66			$billingCountry = 'billingcountry';
67			$shippingFirstName = 'shippingfirstname';
68			$shippingLastName = 'shippinglastname';
69			$shippingAddress = 'shippingaddress';
70			$shippingPostal = 'shippingpostal';
71			$shippingCity = 'shippingcity';
72			$shippingCountry = 'shippingcountry';
73
74			// without optional parameters
75			$payload = $generator->createCustomerInfo($billingFirstName, $billingLastName, $billingAddress, $billingPostal, $billingCity, $billingCountry, $shippingFirstName, $shippingLastName, $shippingAddress, $shippingPostal, $shippingCity, $shippingCountry);
76			$this->assertInstanceOf(CustomerInfoPayload::class, $payload);
77			$this->assertSame($billingFirstName, $payload->getBillingFirstName());
78			$this->assertSame($billingLastName, $payload->getBillingLastName());
79			$this->assertSame($billingAddress, $payload->getBillingAddress());
80			$this->assertSame($billingPostal, $payload->getBillingPostal());
81			$this->assertSame($billingCity, $payload->getBillingCity());
82			$this->assertSame($billingCountry, $payload->getBillingCountry());
83			$this->assertSame($shippingFirstName, $payload->getShippingFirstName());
84			$this->assertSame($shippingLastName, $payload->getShippingLastName());
85			$this->assertSame($shippingAddress, $payload->getShippingAddress());
86			$this->assertSame($shippingPostal, $payload->getShippingPostal());
87			$this->assertSame($shippingCity, $payload->getShippingCity());
88			$this->assertSame($shippingCountry, $payload->getShippingCountry());
89			}
90
91			public function testCreateConfig()
92			{
93			$generator = $this->getGenerator();
94
95			$callbackForm = 'form';
96			$callbackOk = 'ok';
97			$callbackFail = 'fail';
98			$callbackRedirect = 'redirect';
99			$callbackOpen = 'open';
100			$callbackNotification = 'notification';
101
102			// without optional parameters
103			$payload = $generator->createConfig($callbackForm, $callbackOk, $callbackFail, $callbackRedirect, $callbackOpen, $callbackNotification);
104			$this->assertInstanceOf(ConfigPayload::class, $payload);
105			$this->assertSame($callbackForm, $payload->getCallbackForm());
106			$this->assertSame($callbackOk, $payload->getCallbackOk());
107			$this->assertSame($callbackFail, $payload->getCallbackFail());
108			$this->assertSame($callbackRedirect, $payload->getCallbackRedirect());
109			$this->assertSame($callbackOpen, $payload->getCallbackOpen());
110			$this->assertSame($callbackNotification, $payload->getCallbackNotification());
111			}
112
113			private function getGenerator()
114			{
115			$container = $this->getContainer();
116			$paymentRequest = $this->getPaymentRequest();
117			$terminal = $this->getTerminal();
118			$payment = $this->getPayment();
119			$handler = $this->getHandler();
120
121			$generator = new Gateway($container, $paymentRequest, $terminal, $payment, $handler);
			0 ignored issues – show Bug introduced 2017-10-25 12:20 UTC by Report Bug Copy Issue Report It seems like `$container` defined by `$this->getContainer()` on line `115` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Loevgaard\DandomainAltap...enerator::__construct()` does only seem to accept `object<Symfony\Component...ion\ContainerInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-10-25 12:20 UTC by Report Bug Copy Issue Report It seems like `$terminal` defined by `$this->getTerminal()` on line `117` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Loevgaard\DandomainAltap...enerator::__construct()` does only seem to accept `object<Loevgaard\Dandoma...tity\TerminalInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-10-25 12:20 UTC by Report Bug Copy Issue Report It seems like `$payment` defined by `$this->getPayment()` on line `118` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Loevgaard\DandomainAltap...enerator::__construct()` does only seem to accept `object<Loevgaard\Dandoma...yBundle\Entity\Payment>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
122
123			return $generator;
124			}
125
126			/**
127			* @return \PHPUnit_Framework_MockObject_MockObject\|ContainerInterface
128			*/
129			private function getContainer()
130			{
131			$container = $this->getMockForAbstractClass(ContainerInterface::class);
132
133			return $container;
134			}
135
136			private function getPaymentRequest()
137			{
138			$paymentRequest = new DandomainPaymentRequest();
139
140			return $paymentRequest;
141			}
142
143			/**
144			* @return TerminalInterface\|\PHPUnit_Framework_MockObject_MockObject
145			*/
146			private function getTerminal()
147			{
148			$terminal = $this->getMockForAbstractClass(TerminalInterface::class);
149
150			return $terminal;
151			}
152
153			/**
154			* @return Payment\|\PHPUnit_Framework_MockObject_MockObject
155			*/
156			private function getPayment()
157			{
158			$payment = $this->getMockForAbstractClass(Payment::class);
159
160			return $payment;
161			}
162
163			private function getHandler()
164			{
165			$request = $this->getMockForAbstractClass(ServerRequestInterface::class);
166			$handler = new Handler($request, 'sharedkey1', 'sharedkey2');
167
168			return $handler;
169			}
170			}
171

loevgaard / dandomain-altapay-bundle

Push — master ( afa46a...04583c )

PaymentRequestPayloadGeneratorTest::getTerminal() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like