PaymentRequestPayloadGeneratorTest::getRouter() - Code Metrics - Inspection of "created more tests and finished refactoring webhoo..." - loevgaard/dandomain-altapay-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2604a0...14e09a )

by Joachim

created 2017-11-29 12:26 UTC

PaymentRequestPayloadGeneratorTest::getRouter() A

↳ Parent: PaymentRequestPayloadGeneratorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0

<?php

namespace Loevgaard\DandomainAltapayBundle\Tests\PayloadGenerator;

use Loevgaard\AltaPay\Payload\OrderLine as OrderLinePayload;
use Loevgaard\AltaPay\Payload\PaymentRequest\Config as ConfigPayload;
use Loevgaard\AltaPay\Payload\PaymentRequest\CustomerInfo as CustomerInfoPayload;
use Loevgaard\Dandomain\Pay\Helper\ChecksumHelper;
use Loevgaard\Dandomain\Pay\Model\Payment as DandomainPayment;
use Loevgaard\DandomainAltapayBundle\Entity\Payment;
use Loevgaard\DandomainAltapayBundle\Entity\Terminal;
use Loevgaard\DandomainAltapayBundle\Tests\PayloadGenerator\Fixture\Gateway;
use Money\Currency;
use Money\Money;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\Routing\RouterInterface;

final class PaymentRequestPayloadGeneratorTest extends TestCase
{
    public function testCreateOrderLine()
    {
        $generator = $this->getGenerator();

        $description = 'description';
        $itemId = 'itemid';
        $quantity = 1.0;
        $unitPrice = new Money(9995, new Currency('DKK'));

        // without optional parameters
        $payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice);
        $this->assertInstanceOf(OrderLinePayload::class, $payload);
        $this->assertSame($description, $payload->getDescription());
        $this->assertSame($itemId, $payload->getItemId());
        $this->assertSame($quantity, $payload->getQuantity());
        $this->assertEquals($unitPrice, $payload->getUnitPrice());

        // with tax percent
        $taxPercent = 25.0;
        $payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice, $taxPercent);
        $this->assertInstanceOf(OrderLinePayload::class, $payload);
        $this->assertSame($description, $payload->getDescription());
        $this->assertSame($itemId, $payload->getItemId());
        $this->assertSame($quantity, $payload->getQuantity());
        $this->assertEquals($unitPrice, $payload->getUnitPrice());
        $this->assertSame($taxPercent, $payload->getTaxPercent());

        // with goods type
        $goodsType = OrderLinePayload::GOODS_TYPE_ITEM;
        $payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice, null, $goodsType);
        $this->assertInstanceOf(OrderLinePayload::class, $payload);
        $this->assertSame($description, $payload->getDescription());
        $this->assertSame($itemId, $payload->getItemId());
        $this->assertSame($quantity, $payload->getQuantity());
        $this->assertEquals($unitPrice, $payload->getUnitPrice());
        $this->assertSame($goodsType, $payload->getGoodsType());
    }

    public function testCreateCustomerInfo()
    {
        $generator = $this->getGenerator();

        $billingFirstName = 'billingfirstname';
        $billingLastName = 'billinglastname';
        $billingAddress = 'billingaddress';
        $billingPostal = 'billingpostal';
        $billingCity = 'billingcity';
        $billingCountry = 'billingcountry';
        $shippingFirstName = 'shippingfirstname';
        $shippingLastName = 'shippinglastname';
        $shippingAddress = 'shippingaddress';
        $shippingPostal = 'shippingpostal';
        $shippingCity = 'shippingcity';
        $shippingCountry = 'shippingcountry';

        // without optional parameters
        $payload = $generator->createCustomerInfo($billingFirstName, $billingLastName, $billingAddress, $billingPostal, $billingCity, $billingCountry, $shippingFirstName, $shippingLastName, $shippingAddress, $shippingPostal, $shippingCity, $shippingCountry);
        $this->assertInstanceOf(CustomerInfoPayload::class, $payload);
        $this->assertSame($billingFirstName, $payload->getBillingFirstName());
        $this->assertSame($billingLastName, $payload->getBillingLastName());
        $this->assertSame($billingAddress, $payload->getBillingAddress());
        $this->assertSame($billingPostal, $payload->getBillingPostal());
        $this->assertSame($billingCity, $payload->getBillingCity());
        $this->assertSame($billingCountry, $payload->getBillingCountry());
        $this->assertSame($shippingFirstName, $payload->getShippingFirstName());
        $this->assertSame($shippingLastName, $payload->getShippingLastName());
        $this->assertSame($shippingAddress, $payload->getShippingAddress());
        $this->assertSame($shippingPostal, $payload->getShippingPostal());
        $this->assertSame($shippingCity, $payload->getShippingCity());
        $this->assertSame($shippingCountry, $payload->getShippingCountry());
    }

    public function testCreateConfig()
    {
        $generator = $this->getGenerator();

        $callbackForm = 'form';
        $callbackOk = 'ok';
        $callbackFail = 'fail';
        $callbackRedirect = 'redirect';
        $callbackOpen = 'open';
        $callbackNotification = 'notification';

        // without optional parameters
        $payload = $generator->createConfig($callbackForm, $callbackOk, $callbackFail, $callbackRedirect, $callbackOpen, $callbackNotification);
        $this->assertInstanceOf(ConfigPayload::class, $payload);
        $this->assertSame($callbackForm, $payload->getCallbackForm());
        $this->assertSame($callbackOk, $payload->getCallbackOk());
        $this->assertSame($callbackFail, $payload->getCallbackFail());
        $this->assertSame($callbackRedirect, $payload->getCallbackRedirect());
        $this->assertSame($callbackOpen, $payload->getCallbackOpen());
        $this->assertSame($callbackNotification, $payload->getCallbackNotification());
    }

    private function getGenerator()
    {
        $container = $this->getContainer();
        $router = $this->getRouter();
        $dandomainPayment = $this->getDandomainPayment();
        $terminal = $this->getTerminal();
        $payment = $this->getPayment();
        $handler = $this->getChecksumHelper($dandomainPayment);

        $generator = new Gateway($container, $router, $dandomainPayment, $terminal, $payment, $handler);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        return $generator;
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|ContainerInterface
     */
    private function getContainer()
    {
        $container = $this->getMockForAbstractClass(ContainerInterface::class);

        return $container;
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|RouterInterface
     */
    private function getRouter()
    {
        $router = $this->createMock(RouterInterface::class);

        return $router;
    }

    private function getDandomainPayment()
    {
        $paymentRequest = new DandomainPayment();

        return $paymentRequest;
    }

    /**
     * @return Terminal
     */
    private function getTerminal()
    {
        return new Terminal();
    }

    /**
     * @return Payment|\PHPUnit_Framework_MockObject_MockObject
     */
    private function getPayment()
    {
        $payment = $this->getMockForAbstractClass(Payment::class);

        return $payment;
    }

    private function getChecksumHelper(DandomainPayment $payment)
    {
        $checksumHelper = new ChecksumHelper($payment, 'sharedkey1', 'sharedkey2');

        return $checksumHelper;
    }
}


1			<?php
2
3			namespace Loevgaard\DandomainAltapayBundle\Tests\PayloadGenerator;
4
5			use Loevgaard\AltaPay\Payload\OrderLine as OrderLinePayload;
6			use Loevgaard\AltaPay\Payload\PaymentRequest\Config as ConfigPayload;
7			use Loevgaard\AltaPay\Payload\PaymentRequest\CustomerInfo as CustomerInfoPayload;
8			use Loevgaard\Dandomain\Pay\Helper\ChecksumHelper;
9			use Loevgaard\Dandomain\Pay\Model\Payment as DandomainPayment;
10			use Loevgaard\DandomainAltapayBundle\Entity\Payment;
11			use Loevgaard\DandomainAltapayBundle\Entity\Terminal;
12			use Loevgaard\DandomainAltapayBundle\Tests\PayloadGenerator\Fixture\Gateway;
13			use Money\Currency;
14			use Money\Money;
15			use PHPUnit\Framework\TestCase;
16			use Symfony\Component\DependencyInjection\ContainerInterface;
17			use Symfony\Component\Routing\RouterInterface;
18
19			final class PaymentRequestPayloadGeneratorTest extends TestCase
20			{
21			public function testCreateOrderLine()
22			{
23			$generator = $this->getGenerator();
24
25			$description = 'description';
26			$itemId = 'itemid';
27			$quantity = 1.0;
28			$unitPrice = new Money(9995, new Currency('DKK'));
29
30			// without optional parameters
31			$payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice);
32			$this->assertInstanceOf(OrderLinePayload::class, $payload);
33			$this->assertSame($description, $payload->getDescription());
34			$this->assertSame($itemId, $payload->getItemId());
35			$this->assertSame($quantity, $payload->getQuantity());
36			$this->assertEquals($unitPrice, $payload->getUnitPrice());
37
38			// with tax percent
39			$taxPercent = 25.0;
40			$payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice, $taxPercent);
41			$this->assertInstanceOf(OrderLinePayload::class, $payload);
42			$this->assertSame($description, $payload->getDescription());
43			$this->assertSame($itemId, $payload->getItemId());
44			$this->assertSame($quantity, $payload->getQuantity());
45			$this->assertEquals($unitPrice, $payload->getUnitPrice());
46			$this->assertSame($taxPercent, $payload->getTaxPercent());
47
48			// with goods type
49			$goodsType = OrderLinePayload::GOODS_TYPE_ITEM;
50			$payload = $generator->createOrderLine($description, $itemId, $quantity, $unitPrice, null, $goodsType);
51			$this->assertInstanceOf(OrderLinePayload::class, $payload);
52			$this->assertSame($description, $payload->getDescription());
53			$this->assertSame($itemId, $payload->getItemId());
54			$this->assertSame($quantity, $payload->getQuantity());
55			$this->assertEquals($unitPrice, $payload->getUnitPrice());
56			$this->assertSame($goodsType, $payload->getGoodsType());
57			}
58
59			public function testCreateCustomerInfo()
60			{
61			$generator = $this->getGenerator();
62
63			$billingFirstName = 'billingfirstname';
64			$billingLastName = 'billinglastname';
65			$billingAddress = 'billingaddress';
66			$billingPostal = 'billingpostal';
67			$billingCity = 'billingcity';
68			$billingCountry = 'billingcountry';
69			$shippingFirstName = 'shippingfirstname';
70			$shippingLastName = 'shippinglastname';
71			$shippingAddress = 'shippingaddress';
72			$shippingPostal = 'shippingpostal';
73			$shippingCity = 'shippingcity';
74			$shippingCountry = 'shippingcountry';
75
76			// without optional parameters
77			$payload = $generator->createCustomerInfo($billingFirstName, $billingLastName, $billingAddress, $billingPostal, $billingCity, $billingCountry, $shippingFirstName, $shippingLastName, $shippingAddress, $shippingPostal, $shippingCity, $shippingCountry);
78			$this->assertInstanceOf(CustomerInfoPayload::class, $payload);
79			$this->assertSame($billingFirstName, $payload->getBillingFirstName());
80			$this->assertSame($billingLastName, $payload->getBillingLastName());
81			$this->assertSame($billingAddress, $payload->getBillingAddress());
82			$this->assertSame($billingPostal, $payload->getBillingPostal());
83			$this->assertSame($billingCity, $payload->getBillingCity());
84			$this->assertSame($billingCountry, $payload->getBillingCountry());
85			$this->assertSame($shippingFirstName, $payload->getShippingFirstName());
86			$this->assertSame($shippingLastName, $payload->getShippingLastName());
87			$this->assertSame($shippingAddress, $payload->getShippingAddress());
88			$this->assertSame($shippingPostal, $payload->getShippingPostal());
89			$this->assertSame($shippingCity, $payload->getShippingCity());
90			$this->assertSame($shippingCountry, $payload->getShippingCountry());
91			}
92
93			public function testCreateConfig()
94			{
95			$generator = $this->getGenerator();
96
97			$callbackForm = 'form';
98			$callbackOk = 'ok';
99			$callbackFail = 'fail';
100			$callbackRedirect = 'redirect';
101			$callbackOpen = 'open';
102			$callbackNotification = 'notification';
103
104			// without optional parameters
105			$payload = $generator->createConfig($callbackForm, $callbackOk, $callbackFail, $callbackRedirect, $callbackOpen, $callbackNotification);
106			$this->assertInstanceOf(ConfigPayload::class, $payload);
107			$this->assertSame($callbackForm, $payload->getCallbackForm());
108			$this->assertSame($callbackOk, $payload->getCallbackOk());
109			$this->assertSame($callbackFail, $payload->getCallbackFail());
110			$this->assertSame($callbackRedirect, $payload->getCallbackRedirect());
111			$this->assertSame($callbackOpen, $payload->getCallbackOpen());
112			$this->assertSame($callbackNotification, $payload->getCallbackNotification());
113			}
114
115			private function getGenerator()
116			{
117			$container = $this->getContainer();
118			$router = $this->getRouter();
119			$dandomainPayment = $this->getDandomainPayment();
120			$terminal = $this->getTerminal();
121			$payment = $this->getPayment();
122			$handler = $this->getChecksumHelper($dandomainPayment);
123
124			$generator = new Gateway($container, $router, $dandomainPayment, $terminal, $payment, $handler);
			0 ignored issues – show Bug introduced 2017-10-25 12:20 UTC by Report Bug Copy Issue Report It seems like `$container` defined by `$this->getContainer()` on line `117` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Loevgaard\DandomainAltap...enerator::__construct()` does only seem to accept `object<Symfony\Component...ion\ContainerInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-11-29 12:29 UTC by Report Bug Copy Issue Report It seems like `$router` defined by `$this->getRouter()` on line `118` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Loevgaard\DandomainAltap...enerator::__construct()` does only seem to accept `object<Symfony\Component\Routing\RouterInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-10-25 12:20 UTC by Report Bug Copy Issue Report It seems like `$payment` defined by `$this->getPayment()` on line `121` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Loevgaard\DandomainAltap...enerator::__construct()` does only seem to accept `object<Loevgaard\Dandoma...yBundle\Entity\Payment>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
125
126			return $generator;
127			}
128
129			/**
130			* @return \PHPUnit_Framework_MockObject_MockObject\|ContainerInterface
131			*/
132			private function getContainer()
133			{
134			$container = $this->getMockForAbstractClass(ContainerInterface::class);
135
136			return $container;
137			}
138
139			/**
140			* @return \PHPUnit_Framework_MockObject_MockObject\|RouterInterface
141			*/
142			private function getRouter()
143			{
144			$router = $this->createMock(RouterInterface::class);
145
146			return $router;
147			}
148
149			private function getDandomainPayment()
150			{
151			$paymentRequest = new DandomainPayment();
152
153			return $paymentRequest;
154			}
155
156			/**
157			* @return Terminal
158			*/
159			private function getTerminal()
160			{
161			return new Terminal();
162			}
163
164			/**
165			* @return Payment\|\PHPUnit_Framework_MockObject_MockObject
166			*/
167			private function getPayment()
168			{
169			$payment = $this->getMockForAbstractClass(Payment::class);
170
171			return $payment;
172			}
173
174			private function getChecksumHelper(DandomainPayment $payment)
175			{
176			$checksumHelper = new ChecksumHelper($payment, 'sharedkey1', 'sharedkey2');
177
178			return $checksumHelper;
179			}
180			}
181

loevgaard / dandomain-altapay-bundle

Push — master ( 2604a0...14e09a )

PaymentRequestPayloadGeneratorTest::getRouter() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like