Loevgaard\DandomainAltapayBundle\Manager\PaymentManager

Complexity

Total Complexity

13

Size/Duplication

Total Lines	104
Duplicated Lines	20.19 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
C	createPaymentFromDandomainPaymentRequest()	21	35	7
A	findByOrderIdOrAltapayId()	0	16	2
A	create()	0	4	1
A	delete()	0	4	1
A	update()	0	4	1
A	setPaymentLineManager()	0	4	1

<?php

namespace Loevgaard\DandomainAltapayBundle\Manager;

use Loevgaard\Dandomain\Pay\PaymentRequest;
use Loevgaard\DandomainAltapayBundle\Entity\Payment;
use Loevgaard\DoctrineManager\Manager;

class PaymentManager extends Manager
{
    /**
     * @var PaymentLineManager
     */
    protected $paymentLineManager;

    /**
     * This will transform a PaymentRequest (parent) to a Payment (child).
     *
     * @param PaymentRequest $paymentRequest
     *
     * @return Payment
     */
    public function createPaymentFromDandomainPaymentRequest(PaymentRequest $paymentRequest)
    {
        $payment = $this->create();

        $methods = get_class_methods($paymentRequest);

        foreach ($methods as $method) {

This code seems to be duplicated across your project.

            if ('get' === substr($method, 0, 3)) {
                $val = $paymentRequest->{$method}();
                $property = substr($method, 3);
            } elseif ('is' === substr($method, 0, 2)) {
                $val = $paymentRequest->{$method}();
                $property = substr($method, 2);
            } else {
                continue;
            }

            if (!is_scalar($val)) {
                continue;
            }

            $setter = 'set'.$property;

            if (method_exists($payment, $setter)) {
                $payment->{$setter}($val);
            }
        }

        foreach ($paymentRequest->getPaymentLines() as $paymentLine) {
            $newPaymentLine = $this->paymentLineManager->createPaymentLineFromDandomainPaymentRequest($paymentLine);
            $payment->addPaymentLine($newPaymentLine);
        }

        return $payment;
    }

    /**
     * @param $id
     * @return null|Payment
     */
    public function findByOrderIdOrAltapayId($id)
    {
        /** @var Payment $payment */
        $payment = $this->getRepository()->findOneBy([
            'orderId' => $id
        ]);

        if(!$payment) {
            /** @var Payment $payment */
            $payment = $this->getRepository()->findOneBy([

Are you sure the assignment to $payment is correct as $this->getRepository()->findOneBy(array('altapayId' => $id)) (which targets Doctrine\Common\Persistence\ObjectRepository::findOneBy()) seems to always return null.

                'altapayId' => $id
            ]);
        }

        return $payment;
    }

    /**
     * @return Payment
     */
    public function create()
    {
        return parent::create();
    }

    /**
     * @param Payment $obj
     */
    public function delete($obj)
    {
        parent::delete($obj);
    }

    /**
     * @param Payment $obj
     * @param bool    $flush
     */
    public function update($obj, $flush = true)
    {
        parent::update($obj, $flush);
    }

    /**
     * @param PaymentLineManager $paymentLineManager
     */
    public function setPaymentLineManager(PaymentLineManager $paymentLineManager)
    {
        $this->paymentLineManager = $paymentLineManager;
    }
}