Loevgaard\DandomainAltapayBundle\Exception\PaymentException

Complexity

Total Complexity

5

Size/Duplication

Total Lines	62
Duplicated Lines	11.29 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	7	7	1
A	getRequest()	0	4	1
A	setRequest()	0	5	1
A	getPayment()	0	4	1
A	setPayment()	0	5	1

<?php
namespace Loevgaard\DandomainAltapayBundle\Exception;

use Loevgaard\DandomainAltapayBundle\Entity\PaymentInterface;
use Symfony\Component\HttpFoundation\Request;

class PaymentException extends Exception
{
    /**
     * @var Request
     */
    protected $request;

    /**
     * @var PaymentInterface
     */
    protected $payment;

    /**
     * @param string $message
     * @param Request $request
     * @param PaymentInterface $payment
     * @return PaymentException
     */
    public static function create(string $message, Request $request, PaymentInterface $payment) : PaymentException

This method seems to be duplicated in your project.

    {
        $e = new static($message);
        $e->setRequest($request);
        $e->setPayment($payment);
        return $e;
    }

    /**
     * @return Request
     */
    public function getRequest(): Request
    {
        return $this->request;
    }

    /**
     * @param Request $request
     * @return PaymentException
     */
    public function setRequest(Request $request) : PaymentException

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
        return $this;
    }

    /**
     * @return PaymentInterface
     */
    public function getPayment() : PaymentInterface
    {
        return $this->payment;
    }

    /**
     * @param PaymentInterface $payment
     * @return PaymentException
     */
    public function setPayment(PaymentInterface $payment) : PaymentException
    {
        $this->payment = $payment;
        return $this;
    }
}