1 | <?php |
||
23 | class CallbackController extends Controller |
||
24 | { |
||
25 | /** |
||
26 | * @Method("POST") |
||
27 | * @Route("/form", name="loevgaard_dandomain_altapay_callback_form") |
||
28 | * |
||
29 | * @LogHttpTransaction() |
||
30 | * |
||
31 | * @param Request $request |
||
32 | * |
||
33 | * @return Response |
||
34 | */ |
||
35 | public function formAction(Request $request) |
||
43 | |||
44 | /** |
||
45 | * @Method("POST") |
||
46 | * @Route("/ok", name="loevgaard_dandomain_altapay_callback_ok") |
||
47 | * |
||
48 | * @LogHttpTransaction() |
||
49 | * |
||
50 | * @param Request $request |
||
51 | * |
||
52 | * @return Response |
||
53 | */ |
||
54 | public function okAction(Request $request) |
||
60 | |||
61 | /** |
||
62 | * @Method("POST") |
||
63 | * @Route("/fail", name="loevgaard_dandomain_altapay_callback_fail") |
||
64 | * |
||
65 | * @LogHttpTransaction() |
||
66 | * |
||
67 | * @param Request $request |
||
68 | * |
||
69 | * @return Response |
||
70 | */ |
||
71 | public function failAction(Request $request) |
||
77 | |||
78 | /** |
||
79 | * @Method("POST") |
||
80 | * @Route("/redirect", name="loevgaard_dandomain_altapay_callback_redirect") |
||
81 | * |
||
82 | * @LogHttpTransaction() |
||
83 | * |
||
84 | * @param Request $request |
||
85 | * |
||
86 | * @return Response |
||
87 | */ |
||
88 | public function redirectAction(Request $request) |
||
94 | |||
95 | /** |
||
96 | * @Method("POST") |
||
97 | * @Route("/open", name="loevgaard_dandomain_altapay_callback_open") |
||
98 | * |
||
99 | * @LogHttpTransaction() |
||
100 | * |
||
101 | * @param Request $request |
||
102 | * |
||
103 | * @return Response |
||
104 | */ |
||
105 | public function openAction(Request $request) |
||
109 | |||
110 | /** |
||
111 | * @Method("POST") |
||
112 | * @Route("/notification", name="loevgaard_dandomain_altapay_callback_notification") |
||
113 | * |
||
114 | * @LogHttpTransaction() |
||
115 | * |
||
116 | * @param Request $request |
||
117 | * |
||
118 | * @return Response |
||
119 | */ |
||
120 | public function notificationAction(Request $request) |
||
126 | |||
127 | /** |
||
128 | * @Method("POST") |
||
129 | * @Route("/verify-order", name="loevgaard_dandomain_altapay_callback_verify_order") |
||
130 | * |
||
131 | * @LogHttpTransaction() |
||
132 | * |
||
133 | * @param Request $request |
||
134 | * |
||
135 | * @return Response |
||
136 | */ |
||
137 | public function verifyOrderAction(Request $request) |
||
143 | |||
144 | /** |
||
145 | * @param Request $request |
||
146 | * |
||
147 | * @return Payment |
||
148 | * |
||
149 | * @throws PaymentException |
||
150 | */ |
||
151 | protected function handleCallback(Request $request) |
||
216 | |||
217 | /** |
||
218 | * @param Request $request |
||
219 | * |
||
220 | * @return Payment |
||
221 | * |
||
222 | * @throws CallbackException |
||
223 | */ |
||
224 | protected function getPaymentFromRequest(Request $request) |
||
238 | |||
239 | /** |
||
240 | * Add a callback request to the payment for logging purposes. |
||
241 | * |
||
242 | * @param Payment $payment |
||
243 | * @param Request $request |
||
244 | */ |
||
245 | protected function logCallback($payment, Request $request) |
||
254 | |||
255 | /** |
||
256 | * @return PaymentManager |
||
257 | */ |
||
258 | protected function getPaymentManager() |
||
262 | } |
||
263 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.