Loevgaard\DandomainAltapayBundle\Tests\Provider\SiteSettingsProviderTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testOnlyDefaultSettings()	0	16	1
A	testOneSetting()	0	20	1
A	getContainer()	0	9	1
A	getRepository()	0	7	1

<?php

namespace Loevgaard\DandomainAltapayBundle\Tests\Provider;

use Loevgaard\DandomainAltapayBundle\Entity\SiteSetting;
use Loevgaard\DandomainAltapayBundle\Entity\SiteSettingRepository;
use Loevgaard\DandomainAltapayBundle\Provider\SiteSettingsProvider;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\ContainerInterface;

final class SiteSettingsProviderTest extends TestCase
{
    public function testOnlyDefaultSettings()
    {
        $container = $this->getContainer();
        $repository = $this->getRepository();

        $repository->method('findBySiteIdIndexedBySetting')->willReturn(null);

        $expected = array_map(function () {
            return 'default_setting';
        }, SiteSetting::getSettings());

        $siteSettingsProvider = new SiteSettingsProvider($container, $repository);

It seems like $container defined by $this->getContainer() on line 15 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, Loevgaard\DandomainAltapayBundle\Provider\SiteSettingsProvider::__construct() does only seem to accept object<Symfony\Component\DependencyInjection\ContainerInterface>, maybe add an additional type check?

It seems like $repository defined by $this->getRepository() on line 16 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, Loevgaard\DandomainAltapayBundle\Provider\SiteSettingsProvider::__construct() does only seem to accept object<Loevgaard\DandomainAltapayBundle\Entity\SiteSettingRepository>, maybe add an additional type check?

        $settings = $siteSettingsProvider->findBySiteIdIndexedBySetting(26);

        $this->assertSame($expected, $settings);
    }

    public function testOneSetting()
    {
        $container = $this->getContainer();
        $repository = $this->getRepository();

        $siteSetting = new SiteSetting();
        $siteSetting->setVal('11223344')->setSetting(SiteSetting::SETTING_PHONE)->setSiteId(26);

        $repository->method('findBySiteIdIndexedBySetting')->willReturn([SiteSetting::SETTING_PHONE => $siteSetting]);

        $expected = array_map(function ($elm) {

The parameter $elm is not used and could be removed.

            return 'default_setting';
        }, SiteSetting::getSettings());
        $expected['phone'] = $siteSetting;

        $siteSettingsProvider = new SiteSettingsProvider($container, $repository);

It seems like $container defined by $this->getContainer() on line 32 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, Loevgaard\DandomainAltapayBundle\Provider\SiteSettingsProvider::__construct() does only seem to accept object<Symfony\Component\DependencyInjection\ContainerInterface>, maybe add an additional type check?

It seems like $repository defined by $this->getRepository() on line 33 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, Loevgaard\DandomainAltapayBundle\Provider\SiteSettingsProvider::__construct() does only seem to accept object<Loevgaard\DandomainAltapayBundle\Entity\SiteSettingRepository>, maybe add an additional type check?

        $settings = $siteSettingsProvider->findBySiteIdIndexedBySetting(26);

        $this->assertEquals($expected, $settings);
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|ContainerInterface
     */
    private function getContainer()
    {
        /** @var ContainerInterface|\PHPUnit_Framework_MockObject_MockObject $container */
        $container = $this->getMockForAbstractClass(ContainerInterface::class);

        $container->method('getParameter')->willReturn('default_setting');

        return $container;
    }

    /**
     * @return SiteSettingRepository|\PHPUnit_Framework_MockObject_MockObject
     */
    private function getRepository()
    {
        /** @var SiteSettingRepository|\PHPUnit_Framework_MockObject_MockObject $repository */
        $repository = $this->getMockBuilder(SiteSettingRepository::class)->disableOriginalConstructor()->getMock();

        return $repository;
    }
}