Issues in CaptureReservation.php (master) - Issues in master - loevgaard/altapay-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Issues (43)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Payload/CaptureReservation.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Loevgaard\AltaPay\Payload;

use Assert\Assert;
use Loevgaard\AltaPay;
use Money\Money;

class CaptureReservation extends Payload implements CaptureReservationInterface
{
    use OrderLineArrayTrait;

    /**
     * @var string
     */
    private $transactionId;

    /**
     * @var int
     */
    private $amountValue;

    /**
     * @var string
     */
    private $amountCurrency;

    /**
     * @var string
     */
    private $reconciliationIdentifier;

    /**
     * @var string
     */
    private $invoiceNumber;

    /**
     * @var int
     */
    private $salesTax;

    public function __construct(string $transactionId)
    {
        $this->transactionId = $transactionId;
        $this->orderLines = [];
    }

    /**
     * @return array
     */
    public function getPayload() : array
    {
        $this->validate();

        $payload = [
            'transaction_id' => $this->transactionId,
            'amount' => AltaPay\floatFromMoney($this->getAmount()),
            'reconciliation_identifier' => $this->reconciliationIdentifier,
            'invoice_number' => $this->invoiceNumber,
            'sales_tax' => AltaPay\floatFromMoney($this->getSalesTax()),
            'orderLines' => $this->orderLines
        ];

        return static::simplePayload($payload);
    }

    public function validate()
    {
        Assert::that($this->transactionId)->string();
        Assert::thatNullOr($this->getAmount())->isInstanceOf(Money::class);
        Assert::thatNullOr($this->reconciliationIdentifier)->string();
        Assert::thatNullOr($this->invoiceNumber)->string();
        Assert::thatNullOr($this->getSalesTax())->isInstanceOf(Money::class);
        Assert::that($this->orderLines)->isArray();
    }

    /**
     * @return string
     */
    public function getTransactionId() : string
    {
        return $this->transactionId;
    }

    /**
     * @param string $transactionId
     * @return CaptureReservation
     */
    public function setTransactionId(string $transactionId) : self
    {
        $this->transactionId = $transactionId;
        return $this;
    }

    /**
     * @return Money
     */
    public function getAmount() : ?Money
    {
        return AltaPay\createMoney((string)$this->amountCurrency, (int)$this->amountValue);
    }

    /**
     * @param Money $amount
     * @return CaptureReservation
     */
    public function setAmount(Money $amount) : self
    {
        $this->amountValue = $amount->getAmount();
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->amountCurrency = $amount->getCurrency()->getCode();

        return $this;
    }

    /**
     * @return string
     */
    public function getReconciliationIdentifier() : ?string
    {
        return $this->reconciliationIdentifier;
    }

    /**
     * @param string $reconciliationIdentifier
     * @return CaptureReservation
     */
    public function setReconciliationIdentifier(string $reconciliationIdentifier) : self
    {
        $this->reconciliationIdentifier = $reconciliationIdentifier;
        return $this;
    }

    /**
     * @return string
     */
    public function getInvoiceNumber() : ?string
    {
        return $this->invoiceNumber;
    }

    /**
     * @param string $invoiceNumber
     * @return CaptureReservation
     */
    public function setInvoiceNumber(string $invoiceNumber) : self
    {
        $this->invoiceNumber = $invoiceNumber;
        return $this;
    }

    /**
     * @return Money
     */
    public function getSalesTax() : ?Money
    {
        return AltaPay\createMoney((string)$this->amountCurrency, (int)$this->salesTax);
    }

    /**
     * @param Money $salesTax
     * @return CaptureReservation
     */
    public function setSalesTax(Money $salesTax) : self
    {
        $this->salesTax = $salesTax->getAmount();
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        return $this;
    }
}


1		<?php
2		namespace Loevgaard\AltaPay\Payload;
3
4		use Assert\Assert;
5		use Loevgaard\AltaPay;
6		use Money\Money;
7
8		class CaptureReservation extends Payload implements CaptureReservationInterface
9		{
10		use OrderLineArrayTrait;
11
12		/**
13		* @var string
14		*/
15		private $transactionId;
16
17		/**
18		* @var int
19		*/
20		private $amountValue;
21
22		/**
23		* @var string
24		*/
25		private $amountCurrency;
26
27		/**
28		* @var string
29		*/
30		private $reconciliationIdentifier;
31
32		/**
33		* @var string
34		*/
35		private $invoiceNumber;
36
37		/**
38		* @var int
39		*/
40		private $salesTax;
41
42	6	public function __construct(string $transactionId)
43		{
44	6	$this->transactionId = $transactionId;
45	6	$this->orderLines = [];
46	6	}
47
48		/**
49		* @return array
50		*/
51	3	public function getPayload() : array
52		{
53	3	$this->validate();
54
55		$payload = [
56	3	'transaction_id' => $this->transactionId,
57	3	'amount' => AltaPay\floatFromMoney($this->getAmount()),
58	3	'reconciliation_identifier' => $this->reconciliationIdentifier,
59	3	'invoice_number' => $this->invoiceNumber,
60	3	'sales_tax' => AltaPay\floatFromMoney($this->getSalesTax()),
61	3	'orderLines' => $this->orderLines
62		];
63
64	3	return static::simplePayload($payload);
65		}
66
67	3	public function validate()
68		{
69	3	Assert::that($this->transactionId)->string();
70	3	Assert::thatNullOr($this->getAmount())->isInstanceOf(Money::class);
71	3	Assert::thatNullOr($this->reconciliationIdentifier)->string();
72	3	Assert::thatNullOr($this->invoiceNumber)->string();
73	3	Assert::thatNullOr($this->getSalesTax())->isInstanceOf(Money::class);
74	3	Assert::that($this->orderLines)->isArray();
75	3	}
76
77		/**
78		* @return string
79		*/
80	3	public function getTransactionId() : string
81		{
82	3	return $this->transactionId;
83		}
84
85		/**
86		* @param string $transactionId
87		* @return CaptureReservation
88		*/
89	3	public function setTransactionId(string $transactionId) : self
90		{
91	3	$this->transactionId = $transactionId;
92	3	return $this;
93		}
94
95		/**
96		* @return Money
97		*/
98	6	public function getAmount() : ?Money
99		{
100	6	return AltaPay\createMoney((string)$this->amountCurrency, (int)$this->amountValue);
101		}
102
103		/**
104		* @param Money $amount
105		* @return CaptureReservation
106		*/
107	3	public function setAmount(Money $amount) : self
108		{
109	3	$this->amountValue = $amount->getAmount();
		0 ignored issues – show Documentation Bug introduced 2017-11-15 13:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$amountValue` was declared of type `integer`, but `$amount->getAmount()` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
110	3	$this->amountCurrency = $amount->getCurrency()->getCode();
111
112	3	return $this;
113		}
114
115		/**
116		* @return string
117		*/
118	3	public function getReconciliationIdentifier() : ?string
119		{
120	3	return $this->reconciliationIdentifier;
121		}
122
123		/**
124		* @param string $reconciliationIdentifier
125		* @return CaptureReservation
126		*/
127	3	public function setReconciliationIdentifier(string $reconciliationIdentifier) : self
128		{
129	3	$this->reconciliationIdentifier = $reconciliationIdentifier;
130	3	return $this;
131		}
132
133		/**
134		* @return string
135		*/
136	3	public function getInvoiceNumber() : ?string
137		{
138	3	return $this->invoiceNumber;
139		}
140
141		/**
142		* @param string $invoiceNumber
143		* @return CaptureReservation
144		*/
145	3	public function setInvoiceNumber(string $invoiceNumber) : self
146		{
147	3	$this->invoiceNumber = $invoiceNumber;
148	3	return $this;
149		}
150
151		/**
152		* @return Money
153		*/
154	6	public function getSalesTax() : ?Money
155		{
156	6	return AltaPay\createMoney((string)$this->amountCurrency, (int)$this->salesTax);
157		}
158
159		/**
160		* @param Money $salesTax
161		* @return CaptureReservation
162		*/
163	3	public function setSalesTax(Money $salesTax) : self
164		{
165	3	$this->salesTax = $salesTax->getAmount();
		0 ignored issues – show Documentation Bug introduced 2017-11-15 13:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$salesTax` was declared of type `integer`, but `$salesTax->getAmount()` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
166	3	return $this;
167		}
168		}
169

loevgaard / altapay-php-sdk

Issues (43)

Security Analysis not enabled

src/Payload/CaptureReservation.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like