Payload::cleanPayload() - Code Metrics - Inspection of "a lot of refactoring" - loevgaard/altapay-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3ee5ff...5084e8 )

by Joachim

created 2017-09-08 11:12 UTC

Payload::cleanPayload() A

↳ Parent: Payload

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	5
nc	3
nop	1
crap	3

<?php
namespace Loevgaard\AltaPay\Payload;

abstract class Payload implements PayloadInterface
{
    /**
     * @inheritdoc
     */
    public function getPayload(): array
    {
        return [];
    }

    /**
     * If the input array contains objects of PayloadInterface it will convert these to simple arrays
     * Also it will remove values that are null or empty arrays
     *
     * @param array $payload
     * @return array
     */
    public static function simplePayload(array $payload) : array
    {
        $payload = array_filter($payload, function ($val) {
            // this will effectively remove empty arrays
            if (is_array($val) && empty($val)) {
                return false;
            }

            return !is_null($val);
        });

        foreach ($payload as $key => $val) {
            if (is_array($val)) {
                $payload[$key] = static::simplePayload($val);
            } elseif ($val instanceof PayloadInterface) {
                $payload[$key] = static::simplePayload($val->getPayload());
            }
        }

        return $payload;
    }
}


1		<?php
2		namespace Loevgaard\AltaPay\Payload;
3
4		abstract class Payload implements PayloadInterface
5		{
6		/**
7		* @inheritdoc
8		*/
9		public function getPayload(): array
10		{
11	3	return [];
12		}
13	3
14		/**
15		* If the input array contains objects of PayloadInterface it will convert these to simple arrays
16		* Also it will remove values that are null or empty arrays
17		*
18		* @param array $payload
19		* @return array
20		*/
21		public static function simplePayload(array $payload) : array
22	6	{
23		$payload = array_filter($payload, function ($val) {
24	6	// this will effectively remove empty arrays
25	6	if (is_array($val) && empty($val)) {
26	6	return false;
27	4	}
28	4
29		return !is_null($val);
30	6	});
31
32		foreach ($payload as $key => $val) {
33	6	if (is_array($val)) {
34		$payload[$key] = static::simplePayload($val);
35	6	} elseif ($val instanceof PayloadInterface) {
36	6	$payload[$key] = static::simplePayload($val->getPayload());
37		}
38		}
39	3
40		return $payload;
41		}
42		}
43

loevgaard / altapay-php-sdk

Push — master ( 3ee5ff...5084e8 )

Payload::cleanPayload() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like