loevgaard / SyliusBarcodePlugin

spec/BarcodeChecker/BarcodeCheckerSpec.php

<?php

declare(strict_types=1);

namespace spec\Loevgaard\SyliusBarcodePlugin\BarcodeChecker;

use Loevgaard\SyliusBarcodePlugin\BarcodeChecker\BarcodeChecker;
use Loevgaard\SyliusBarcodePlugin\Event\PostBarcodeCheckEvent;
use Loevgaard\SyliusBarcodePlugin\Event\PreBarcodeCheckEvent;
use Loevgaard\SyliusBarcodePlugin\Model\BarcodeAwareInterface;
use PhpSpec\ObjectBehavior;
use Prophecy\Argument;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

class BarcodeCheckerSpec extends ObjectBehavior
{
    public function it_is_initializable(): void
    {
        $this->shouldHaveType(BarcodeChecker::class);
    }

    public function let(EventDispatcherInterface $eventDispatcher): void
    {
        $this->beConstructedWith($eventDispatcher);
    }

    public function it_invalidates(BarcodeAwareInterface $barcodeAware): void
    {
        $barcodeAware->getBarcode()->willReturn('invalid');
        $barcodeAware->markBarcodeAsChecked(false)->shouldBeCalled();

Are you sure the usage of $barcodeAware->markBarcodeAsChecked(false) targeting Loevgaard\SyliusBarcodePlugin\Model\BarcodeAwareInterface::markBarcodeAsChecked() seems to always return null.

        $this->check($barcodeAware);

The method check() does not exist on spec\Loevgaard\SyliusBarcodePlugin\BarcodeChecker\BarcodeCheckerSpec. Since you implemented __call, consider adding a @method annotation.

    }

    public function it_validates(BarcodeAwareInterface $barcodeAware): void
    {
        $barcodeAware->getBarcode()->willReturn('4006381333931');
        $barcodeAware->markBarcodeAsChecked(true)->shouldBeCalled();

Are you sure the usage of $barcodeAware->markBarcodeAsChecked(true) targeting Loevgaard\SyliusBarcodePlugin\Model\BarcodeAwareInterface::markBarcodeAsChecked() seems to always return null.

        $this->check($barcodeAware);
    }

    public function it_dispatches_events(EventDispatcherInterface $eventDispatcher, BarcodeAwareInterface $barcodeAware): void
    {
        $eventDispatcher->dispatch(Argument::type(PreBarcodeCheckEvent::class), PreBarcodeCheckEvent::NAME)->shouldBeCalledOnce();

The constant Loevgaard\SyliusBarcodePlugin\Event\PreBarcodeCheckEvent::NAME has been deprecated: will be removed in v2

The call to Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch() has too many arguments starting with Loevgaard\SyliusBarcodePlugin\Event\PreBarcodeCheckEvent::NAME.

        $eventDispatcher->dispatch(Argument::type(PostBarcodeCheckEvent::class), PostBarcodeCheckEvent::NAME)->shouldBeCalledOnce();

The constant Loevgaard\SyliusBarcodePlugin\Event\PostBarcodeCheckEvent::NAME has been deprecated: will be removed in v2

        $this->check($barcodeAware);
    }
}