JsonapiObject::toArray() - Code Metrics - Inspection of "Support for spec 1.1 RC 2 & 3" - lode/jsonapi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#66)

by Lode

created 2021-05-15 17:35 UTC

JsonapiObject::toArray() B

↳ Parent: JsonapiObject

Complexity

Conditions	10
Paths	64

Size

Total Lines	29
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	10

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
cc	10
eloc	18
c	2
b	0
f	2
nc	64
nop	0
dl	0
loc	29
ccs	19
cts	19
cp	1
crap	10
rs	7.6666

How to fix Complexity

<?php

namespace alsvanzelf\jsonapi\objects;

use alsvanzelf\jsonapi\Document;
use alsvanzelf\jsonapi\helpers\AtMemberManager;
use alsvanzelf\jsonapi\helpers\ExtensionMemberManager;
use alsvanzelf\jsonapi\interfaces\ExtensionInterface;
use alsvanzelf\jsonapi\interfaces\ObjectInterface;
use alsvanzelf\jsonapi\interfaces\ProfileInterface;
use alsvanzelf\jsonapi\objects\MetaObject;

class JsonapiObject implements ObjectInterface {
	use AtMemberManager, ExtensionMemberManager;
	
	/** @var string */
	protected $version;
	/** @var ExtensionInterface[] */
	protected $extensions = [];
	/** @var ProfileInterface */
	protected $profiles = [];
	/** @var MetaObject */
	protected $meta;
	
	/**
	 * @param string $version one of the Document::JSONAPI_VERSION_* constants, optional, defaults to Document::JSONAPI_VERSION_LATEST
	 */
	public function __construct($version=Document::JSONAPI_VERSION_LATEST) {
		if ($version !== null) {
			$this->setVersion($version);
		}
	}
	
	/**
	 * human api
	 */
	
	/**
	 * @param string $key
	 * @param mixed  $value
	 */
	public function addMeta($key, $value) {
		if ($this->meta === null) {
			$this->setMetaObject(new MetaObject());
		}
		
		$this->meta->add($key, $value);
	}
	
	/**
	 * spec api
	 */
	
	/**
	 * @param string $version
	 */
	public function setVersion($version) {
		$this->version = $version;
	}
	
	/**
	 * @param ExtensionInterface $extension
	 */
	public function addExtension(ExtensionInterface $extension) {
		$this->extensions[] = $extension;
	}
	
	/**
	 * @param ProfileInterface $profile
	 */
	public function addProfile(ProfileInterface $profile) {
		$this->profiles[] = $profile;
	}
	
	/**
	 * @param MetaObject $metaObject
	 */
	public function setMetaObject(MetaObject $metaObject) {
		$this->meta = $metaObject;
	}
	
	/**
	 * ObjectInterface
	 */
	
	/**
	 * @inheritDoc
	 */
	public function isEmpty() {
		if ($this->version !== null) {
			return false;
		}
		if ($this->extensions !== []) {
			return false;
		}
		if ($this->profiles !== []) {

			return false;
		}
		if ($this->meta !== null && $this->meta->isEmpty() === false) {
			return false;
		}
		if ($this->hasAtMembers()) {
			return false;
		}
		if ($this->hasExtensionMembers()) {
			return false;
		}
		
		return true;
	}
	
	/**
	 * @inheritDoc
	 */
	public function toArray() {
		$array = [];
		
		if ($this->hasAtMembers()) {
			$array = array_merge($array, $this->getAtMembers());
		}
		if ($this->hasExtensionMembers()) {
			$array = array_merge($array, $this->getExtensionMembers());
		}
		if ($this->version !== null) {
			$array['version'] = $this->version;
		}
		if ($this->extensions !== []) {
			$array['ext'] = [];
			foreach ($this->extensions as $extension) {
				$array['ext'][] = $extension->getOfficialLink();
			}
		}
		if ($this->profiles !== []) {

			$array['profile'] = [];
			foreach ($this->profiles as $profile) {
				$array['profile'][] = $profile->getOfficialLink();
			}
		}
		if ($this->meta !== null && $this->meta->isEmpty() === false) {
			$array['meta'] = $this->meta->toArray();
		}
		
		return $array;
	}
}


1		<?php
2
3		namespace alsvanzelf\jsonapi\objects;
4
5		use alsvanzelf\jsonapi\Document;
6		use alsvanzelf\jsonapi\helpers\AtMemberManager;
7		use alsvanzelf\jsonapi\helpers\ExtensionMemberManager;
8		use alsvanzelf\jsonapi\interfaces\ExtensionInterface;
9		use alsvanzelf\jsonapi\interfaces\ObjectInterface;
10		use alsvanzelf\jsonapi\interfaces\ProfileInterface;
11		use alsvanzelf\jsonapi\objects\MetaObject;
12
13		class JsonapiObject implements ObjectInterface {
14		use AtMemberManager, ExtensionMemberManager;
15
16		/** @var string */
17		protected $version;
18		/** @var ExtensionInterface[] */
19		protected $extensions = [];
20		/** @var ProfileInterface */
21		protected $profiles = [];
22		/** @var MetaObject */
23		protected $meta;
24
25		/**
26		* @param string $version one of the Document::JSONAPI_VERSION_* constants, optional, defaults to Document::JSONAPI_VERSION_LATEST
27		*/
28	126	public function __construct($version=Document::JSONAPI_VERSION_LATEST) {
29	126	if ($version !== null) {
30	121	$this->setVersion($version);
31		}
32	126	}
33
34		/**
35		* human api
36		*/
37
38		/**
39		* @param string $key
40		* @param mixed $value
41		*/
42	4	public function addMeta($key, $value) {
43	4	if ($this->meta === null) {
44	4	$this->setMetaObject(new MetaObject());
45		}
46
47	4	$this->meta->add($key, $value);
48	4	}
49
50		/**
51		* spec api
52		*/
53
54		/**
55		* @param string $version
56		*/
57	121	public function setVersion($version) {
58	121	$this->version = $version;
59	121	}
60
61		/**
62		* @param ExtensionInterface $extension
63		*/
64	8	public function addExtension(ExtensionInterface $extension) {
65	8	$this->extensions[] = $extension;
66	8	}
67
68		/**
69		* @param ProfileInterface $profile
70		*/
71	12	public function addProfile(ProfileInterface $profile) {
72	12	$this->profiles[] = $profile;
73	12	}
74
75		/**
76		* @param MetaObject $metaObject
77		*/
78	6	public function setMetaObject(MetaObject $metaObject) {
79	6	$this->meta = $metaObject;
80	6	}
81
82		/**
83		* ObjectInterface
84		*/
85
86		/**
87		* @inheritDoc
88		*/
89	90	public function isEmpty() {
90	90	if ($this->version !== null) {
91	85	return false;
92		}
93	5	if ($this->extensions !== []) {
94	1	return false;
95		}
96	5	if ($this->profiles !== []) {
		1 ignored issue – show introduced 2021-05-15 17:39 UTC by Report Bug Copy Issue Report The condition `$this->profiles !== array()` is always `true`. Loading history...
97	1	return false;
98		}
99	5	if ($this->meta !== null && $this->meta->isEmpty() === false) {
100	1	return false;
101		}
102	5	if ($this->hasAtMembers()) {
103	1	return false;
104		}
105	5	if ($this->hasExtensionMembers()) {
106	1	return false;
107		}
108
109	5	return true;
110		}
111
112		/**
113		* @inheritDoc
114		*/
115	86	public function toArray() {
116	86	$array = [];
117
118	86	if ($this->hasAtMembers()) {
119	2	$array = array_merge($array, $this->getAtMembers());
120		}
121	86	if ($this->hasExtensionMembers()) {
122	1	$array = array_merge($array, $this->getExtensionMembers());
123		}
124	86	if ($this->version !== null) {
125	85	$array['version'] = $this->version;
126		}
127	86	if ($this->extensions !== []) {
128	5	$array['ext'] = [];
129	5	foreach ($this->extensions as $extension) {
130	5	$array['ext'][] = $extension->getOfficialLink();
131		}
132		}
133	86	if ($this->profiles !== []) {
		1 ignored issue – show introduced 2021-05-15 17:39 UTC by Report Bug Copy Issue Report The condition `$this->profiles !== array()` is always `true`. Loading history...
134	11	$array['profile'] = [];
135	11	foreach ($this->profiles as $profile) {
136	11	$array['profile'][] = $profile->getOfficialLink();
137		}
138		}
139	86	if ($this->meta !== null && $this->meta->isEmpty() === false) {
140	6	$array['meta'] = $this->meta->toArray();
141		}
142
143	86	return $array;
144		}
145		}
146

lode / jsonapi

Pull Request — main (#66)

JsonapiObject::toArray() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like