AbstractLoader - Code Metrics - Inspection of "Improve exception messages for template loading" - locomotivemtl/charcoal-view - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 7f0819...d3db1e )

by Chauncey

created 2017-12-07 22:35 UTC

AbstractLoader B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	283
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	36
lcom	1
cbo	2
dl	0
loc	283
rs	8.8
c	0
b	0
f	0

14 Methods

Rating	Name	Size	Complexity
A	__construct()	6	1
C	load()	32	7
B	setDynamicTemplate()	26	5
A	dynamicTemplate()	14	3
A	removeDynamicTemplate()	15	3
A	clearDynamicTemplates()	7	1
A	basePath()	4	1
A	paths()	4	1
B	findTemplateFile()	20	5
	filenameFromIdent()	1	?
A	setPaths()	10	2
A	setBasePath()	11	2
A	addPath()	6	1
A	resolvePath()	16	4

<?php

namespace Charcoal\View;

// PHP Dependencies
use InvalidArgumentException;

// PSR-3 (logger) dependencies
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;

// Local namespace dependencies
use Charcoal\View\LoaderInterface;

/**
 * Base template loader.
 */
abstract class AbstractLoader implements
    LoggerAwareInterface,
    LoaderInterface
{
    use LoggerAwareTrait;

    /**
     * @var string
     */
    private $basePath = '';

    /**
     * @var string[]
     */
    private $paths = [];

    /**
     * @var array
     */
    private $dynamicTemplates = [];

    /**
     * Default constructor, if none is provided by the concrete class implementations.
     *
     * ## Required dependencies
     * - `logger` A PSR-3 logger
     *
     * @param array $data The class dependencies map.
     */
    public function __construct(array $data = null)
    {
        $this->setLogger($data['logger']);
        $this->setBasePath($data['base_path']);
        $this->setPaths($data['paths']);
    }

    /**
     * Load a template content
     *
     * @deprecated $GLOBALS['widget_template']
     * @param  string $ident The template ident to load and render.
     * @throws InvalidArgumentException If the dynamic template identifier is not a string.
     * @return string
     */
    public function load($ident)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // Handle dynamic template
        if (substr($ident, 0, 1) === '$') {
            $tryLegacy = ($ident === '$widget_template');

            $ident = $this->dynamicTemplate(substr($ident, 1));

            // Legacy dynamic template hack
            if ($tryLegacy) {
                $ident = empty($GLOBALS['widget_template']) ? $ident : $GLOBALS['widget_template'];
                $this->logger->warning(sprintf(
                    '%s is deprecated in favor of %s: %s',
                    '$GLOBALS[\'widget_template\']',
                    'setDynamicTemplate()',
                    $ident
                ));
                if (!is_string($ident)) {
                    throw new InvalidArgumentException(
                        'Dynamic template ident (from "$widget_template") must be a string'
                    );
                }
            }
        }

        $file = $this->findTemplateFile($ident);
        if ($file === null || $file === '') {
            return $ident;
        }

        return file_get_contents($file);
    }

    /**
     * @deprecated $GLOBALS['widget_template']
     * @param string      $varName       The name of the variable to set this template unto.
     * @param string|null $templateIdent The "dynamic template" to set or NULL to clear.
     * @throws InvalidArgumentException If var name is not a string
     *     or if the template is not a string (and not null).
     * @return void
     */
    public function setDynamicTemplate($varName, $templateIdent)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!is_string($varName)) {
            throw new InvalidArgumentException(
                'Can not set dynamic template: var name is not a string.'
            );
        }

        if ($templateIdent === null) {
            $this->removeDynamicTemplate($varName);

            return;
        }

        if (!is_string($templateIdent)) {
            throw new InvalidArgumentException(
                'Can not set dynamic template. Must be a a string, or null.'
            );
        }

        // Legacy dynamic template hack
        if ($varName === 'widget_template') {
            $GLOBALS['widget_template'] = $templateIdent;
        }

        $this->dynamicTemplates[$varName] = $templateIdent;
    }

    /**
     * @param string $varName The name of the variable to get template ident from.
     * @throws InvalidArgumentException If the var name is not a string.
     * @return string
     */
    public function dynamicTemplate($varName)
    {
        if (!is_string($varName)) {
            throw new InvalidArgumentException(
                'Can not get dynamic template: var name is not a string.'
            );
        }

        if (!isset($this->dynamicTemplates[$varName])) {
            return '';
        }

        return $this->dynamicTemplates[$varName];
    }

    /**
     * @deprecated $GLOBALS['widget_template']
     * @param string $varName The name of the variable to remove.
     * @throws InvalidArgumentException If var name is not a string.
     * @return void
     */
    public function removeDynamicTemplate($varName)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!is_string($varName)) {
            throw new InvalidArgumentException(
                'Can not set dynamic template: var name is not a string.'
            );
        }

        // Legacy dynamic template hack
        if ($varName === 'widget_template') {
            $GLOBALS['widget_template'] = null;
        }

        unset($this->dynamicTemplates[$varName]);
    }

    /**
     * @deprecated $GLOBALS['widget_template']
     * @return void
     */
    public function clearDynamicTemplates()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // Legacy dynamic template hack
        $GLOBALS['widget_template'] = null;

        $this->dynamicTemplates = [];
    }

    /**
     * @return string
     */
    protected function basePath()
    {
        return $this->basePath;
    }

    /**
     * @return string[]
     */
    protected function paths()
    {
        return $this->paths;
    }

    /**
     * Get the template file (full path + filename) to load from an ident.
     *
     * This method first generates the filename for an identifier and search for it in all of the loader's paths.
     *
     * @param string $ident The template identifier to load.
     * @throws InvalidArgumentException If the template ident is not a string.
     * @return string|null The full path + filename of the found template. Null if nothing was found.
     */
    protected function findTemplateFile($ident)
    {
        if (!is_string($ident)) {
            throw new InvalidArgumentException(sprintf(
                'Template ident must be a string, received %s',
                is_object($ident) ? get_class($ident) : gettype($ident)
            ));
        }

        $filename = $this->filenameFromIdent($ident);
        $searchPath = $this->paths();
        foreach ($searchPath as $path) {
            $f = realpath($path).'/'.strtolower($filename);
            if (file_exists($f)) {
                return $f;
            }
        }

        return null;
    }

    /**
     * @param string $ident The template identifier to convert to a filename.
     * @return string
     */
    abstract protected function filenameFromIdent($ident);

    /**
     * @param string[] $paths The list of path to add.
     * @return LoaderInterface Chainable
     */
    private function setPaths(array $paths)
    {
        $this->paths = [];

        foreach ($paths as $path) {
            $this->addPath($path);
        }

        return $this;
    }

    /**
     * @param string $basePath The base path to set.
     * @throws InvalidArgumentException If the base path parameter is not a string.
     * @return LoaderInterface Chainable
     */
    private function setBasePath($basePath)
    {
        if (!is_string($basePath)) {
            throw new InvalidArgumentException(
                'Base path must be a string'
            );
        }
        $basePath = realpath($basePath);
        $this->basePath = rtrim($basePath, '/\\').DIRECTORY_SEPARATOR;
        return $this;
    }

    /**
     * @param string $path The path to add to the load.
     * @return LoaderInterface Chainable
     */
    private function addPath($path)
    {
        $this->paths[] = $this->resolvePath($path);

        return $this;
    }

    /**
     * @param string $path The path to resolve.
     * @throws InvalidArgumentException If the path argument is not a string.
     * @return string
     */
    private function resolvePath($path)
    {
        if (!is_string($path)) {
            throw new InvalidArgumentException(
                'Path needs to be a string'
            );
        }

        $basePath = $this->basePath();
        $path = rtrim($path, '/\\').DIRECTORY_SEPARATOR;
        if ($basePath && strpos($path, $basePath) === false) {
            $path = $basePath.$path;
        }

        return $path;
    }
}


1			<?php
2
3			namespace Charcoal\View;
4
5			// PHP Dependencies
6			use InvalidArgumentException;
7
8			// PSR-3 (logger) dependencies
9			use Psr\Log\LoggerAwareInterface;
10			use Psr\Log\LoggerAwareTrait;
11
12			// Local namespace dependencies
13			use Charcoal\View\LoaderInterface;
14
15			/**
16			* Base template loader.
17			*/
18			abstract class AbstractLoader implements
19			LoggerAwareInterface,
20			LoaderInterface
21			{
22			use LoggerAwareTrait;
23
24			/**
25			* @var string
26			*/
27			private $basePath = '';
28
29			/**
30			* @var string[]
31			*/
32			private $paths = [];
33
34			/**
35			* @var array
36			*/
37			private $dynamicTemplates = [];
38
39			/**
40			* Default constructor, if none is provided by the concrete class implementations.
41			*
42			* ## Required dependencies
43			* - `logger` A PSR-3 logger
44			*
45			* @param array $data The class dependencies map.
46			*/
47			public function __construct(array $data = null)
48			{
49			$this->setLogger($data['logger']);
50			$this->setBasePath($data['base_path']);
51			$this->setPaths($data['paths']);
52			}
53
54			/**
55			* Load a template content
56			*
57			* @deprecated $GLOBALS['widget_template']
58			* @param string $ident The template ident to load and render.
59			* @throws InvalidArgumentException If the dynamic template identifier is not a string.
60			* @return string
61			*/
62			public function load($ident)
			0 ignored issues – show Coding Style introduced 2017-08-16 22:08 UTC by Report Bug Copy Issue Report `load` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
63			{
64			// Handle dynamic template
65			if (substr($ident, 0, 1) === '$') {
66			$tryLegacy = ($ident === '$widget_template');
67
68			$ident = $this->dynamicTemplate(substr($ident, 1));
69
70			// Legacy dynamic template hack
71			if ($tryLegacy) {
72			$ident = empty($GLOBALS['widget_template']) ? $ident : $GLOBALS['widget_template'];
73			$this->logger->warning(sprintf(
74			'%s is deprecated in favor of %s: %s',
75			'$GLOBALS[\'widget_template\']',
76			'setDynamicTemplate()',
77			$ident
78			));
79			if (!is_string($ident)) {
80			throw new InvalidArgumentException(
81			'Dynamic template ident (from "$widget_template") must be a string'
82			);
83			}
84			}
85			}
86
87			$file = $this->findTemplateFile($ident);
88			if ($file === null \|\| $file === '') {
89			return $ident;
90			}
91
92			return file_get_contents($file);
93			}
94
95			/**
96			* @deprecated $GLOBALS['widget_template']
97			* @param string $varName The name of the variable to set this template unto.
98			* @param string\|null $templateIdent The "dynamic template" to set or NULL to clear.
99			* @throws InvalidArgumentException If var name is not a string
100			* or if the template is not a string (and not null).
101			* @return void
102			*/
103			public function setDynamicTemplate($varName, $templateIdent)
			0 ignored issues – show Coding Style introduced 2017-08-16 22:08 UTC by Report Bug Copy Issue Report `setDynamicTemplate` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
104			{
105			if (!is_string($varName)) {
106			throw new InvalidArgumentException(
107			'Can not set dynamic template: var name is not a string.'
108			);
109			}
110
111			if ($templateIdent === null) {
112			$this->removeDynamicTemplate($varName);
			0 ignored issues – show Deprecated Code introduced 2017-08-17 22:40 UTC by Report Bug Copy Issue Report The method `Charcoal\View\AbstractLo...removeDynamicTemplate()` has been deprecated with message: $GLOBALS['widget_template'] This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
113			return;
114			}
115
116			if (!is_string($templateIdent)) {
117			throw new InvalidArgumentException(
118			'Can not set dynamic template. Must be a a string, or null.'
119			);
120			}
121
122			// Legacy dynamic template hack
123			if ($varName === 'widget_template') {
124			$GLOBALS['widget_template'] = $templateIdent;
125			}
126
127			$this->dynamicTemplates[$varName] = $templateIdent;
128			}
129
130			/**
131			* @param string $varName The name of the variable to get template ident from.
132			* @throws InvalidArgumentException If the var name is not a string.
133			* @return string
134			*/
135			public function dynamicTemplate($varName)
136			{
137			if (!is_string($varName)) {
138			throw new InvalidArgumentException(
139			'Can not get dynamic template: var name is not a string.'
140			);
141			}
142
143			if (!isset($this->dynamicTemplates[$varName])) {
144			return '';
145			}
146
147			return $this->dynamicTemplates[$varName];
148			}
149
150			/**
151			* @deprecated $GLOBALS['widget_template']
152			* @param string $varName The name of the variable to remove.
153			* @throws InvalidArgumentException If var name is not a string.
154			* @return void
155			*/
156			public function removeDynamicTemplate($varName)
			0 ignored issues – show Coding Style introduced 2017-08-17 22:40 UTC by Report Bug Copy Issue Report `removeDynamicTemplate` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
157			{
158			if (!is_string($varName)) {
159			throw new InvalidArgumentException(
160			'Can not set dynamic template: var name is not a string.'
161			);
162			}
163
164			// Legacy dynamic template hack
165			if ($varName === 'widget_template') {
166			$GLOBALS['widget_template'] = null;
167			}
168
169			unset($this->dynamicTemplates[$varName]);
170			}
171
172			/**
173			* @deprecated $GLOBALS['widget_template']
174			* @return void
175			*/
176			public function clearDynamicTemplates()
			0 ignored issues – show Coding Style introduced 2017-08-17 22:40 UTC by Report Bug Copy Issue Report `clearDynamicTemplates` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
177			{
178			// Legacy dynamic template hack
179			$GLOBALS['widget_template'] = null;
180
181			$this->dynamicTemplates = [];
182			}
183
184			/**
185			* @return string
186			*/
187			protected function basePath()
188			{
189			return $this->basePath;
190			}
191
192			/**
193			* @return string[]
194			*/
195			protected function paths()
196			{
197			return $this->paths;
198			}
199
200			/**
201			* Get the template file (full path + filename) to load from an ident.
202			*
203			* This method first generates the filename for an identifier and search for it in all of the loader's paths.
204			*
205			* @param string $ident The template identifier to load.
206			* @throws InvalidArgumentException If the template ident is not a string.
207			* @return string\|null The full path + filename of the found template. Null if nothing was found.
208			*/
209			protected function findTemplateFile($ident)
210			{
211			if (!is_string($ident)) {
212			throw new InvalidArgumentException(sprintf(
213			'Template ident must be a string, received %s',
214			is_object($ident) ? get_class($ident) : gettype($ident)
215			));
216			}
217
218			$filename = $this->filenameFromIdent($ident);
219			$searchPath = $this->paths();
220			foreach ($searchPath as $path) {
221			$f = realpath($path).'/'.strtolower($filename);
222			if (file_exists($f)) {
223			return $f;
224			}
225			}
226
227			return null;
228			}
229
230			/**
231			* @param string $ident The template identifier to convert to a filename.
232			* @return string
233			*/
234			abstract protected function filenameFromIdent($ident);
235
236			/**
237			* @param string[] $paths The list of path to add.
238			* @return LoaderInterface Chainable
239			*/
240			private function setPaths(array $paths)
241			{
242			$this->paths = [];
243
244			foreach ($paths as $path) {
245			$this->addPath($path);
246			}
247
248			return $this;
249			}
250
251			/**
252			* @param string $basePath The base path to set.
253			* @throws InvalidArgumentException If the base path parameter is not a string.
254			* @return LoaderInterface Chainable
255			*/
256			private function setBasePath($basePath)
257			{
258			if (!is_string($basePath)) {
259			throw new InvalidArgumentException(
260			'Base path must be a string'
261			);
262			}
263			$basePath = realpath($basePath);
264			$this->basePath = rtrim($basePath, '/\\').DIRECTORY_SEPARATOR;
265			return $this;
266			}
267
268			/**
269			* @param string $path The path to add to the load.
270			* @return LoaderInterface Chainable
271			*/
272			private function addPath($path)
273			{
274			$this->paths[] = $this->resolvePath($path);
275
276			return $this;
277			}
278
279			/**
280			* @param string $path The path to resolve.
281			* @throws InvalidArgumentException If the path argument is not a string.
282			* @return string
283			*/
284			private function resolvePath($path)
285			{
286			if (!is_string($path)) {
287			throw new InvalidArgumentException(
288			'Path needs to be a string'
289			);
290			}
291
292			$basePath = $this->basePath();
293			$path = rtrim($path, '/\\').DIRECTORY_SEPARATOR;
294			if ($basePath && strpos($path, $basePath) === false) {
295			$path = $basePath.$path;
296			}
297
298			return $path;
299			}
300			}
301

locomotivemtl / charcoal-view

Push — master ( 7f0819...d3db1e )

AbstractLoader B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

Duplication Side-by-Side

Filter issues like