ImagickCropEffect - Code Metrics - Inspection of "calculate crop gravity" - locomotivemtl/charcoal-image - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dce39d...eb587f )

unknown

created 2018-02-26 20:35 UTC

ImagickCropEffect A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	21.05 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	10
c	1
b	0
f	0
lcom	0
cbo	2
dl	12
loc	57
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
C	doCrop()	12	47	10

How to fix Duplicated Code

<?php

namespace Charcoal\Image\Imagick\Effect;

use \Imagick;

use \Charcoal\Image\Effect\AbstractCropEffect;

/**
 * Resize Effect for the Imagick driver
 */
class ImagickCropEffect extends AbstractCropEffect
{
    /**
     * @param integer $width  The crop width.
     * @param integer $height The crop height.
     * @param integer $x      The x-position (in pixel) of the crop.
     * @param integer $y      The y-position (in pixel) of the crop.
     * @return void
     */
    protected function doCrop($width, $height, $x, $y)
    {
        $gravity = $this->image()->imagickGravity($this->gravity());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        // This sets the gravity for the rest of the chain
        $this->image()->imagick()->setGravity($gravity);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        // Apply gravity to crop coordinates

        $imageWidth  = $this->image()->width();
        $imageHeight = $this->image()->height();

        switch ($this->image()->imagick()->getGravity()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            case Imagick::GRAVITY_NORTHWEST:
                break;
            case Imagick::GRAVITY_NORTH:
                $x = ($imageWidth / 2 - $width / 2);
                break;
            case Imagick::GRAVITY_NORTHEAST:
                $x = ($imageWidth - $width);
                break;
            case Imagick::GRAVITY_WEST:
                $y = ($imageHeight / 2 - $height / 2);
                break;
            case Imagick::GRAVITY_CENTER:

                $x = ($imageWidth / 2 - $width / 2);
                $y = ($imageHeight / 2 - $height / 2);
                break;
            case Imagick::GRAVITY_EAST:

                $x = ($imageWidth - $width);
                $y = ($imageHeight / 2 - $height / 2);
                break;
            case Imagick::GRAVITY_SOUTHWEST:
                $y = ($imageHeight - $height);
                break;
            case Imagick::GRAVITY_SOUTH:

                $x = ($imageWidth / 2 - $width / 2);
                $y = ($imageHeight - $height);
                break;
            case Imagick::GRAVITY_SOUTHEAST:
                $x = ($imageWidth - $width);
                $y = ($imageHeight - $height);
                break;
        }

        $this->image()->imagick()->cropImage($width, $height, $x, $y);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


Push — master ( dce39d...eb587f )

ImagickCropEffect A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Charcoal\Image\Imagick\Effect;
4
5		use \Imagick;
6
7		use \Charcoal\Image\Effect\AbstractCropEffect;
8
9		/**
10		* Resize Effect for the Imagick driver
11		*/
12		class ImagickCropEffect extends AbstractCropEffect
13		{
14		/**
15		* @param integer $width The crop width.
16		* @param integer $height The crop height.
17		* @param integer $x The x-position (in pixel) of the crop.
18		* @param integer $y The y-position (in pixel) of the crop.
19		* @return void
20		*/
21		protected function doCrop($width, $height, $x, $y)
22		{
23		$gravity = $this->image()->imagickGravity($this->gravity());
		0 ignored issues – show Bug introduced 2017-07-13 23:31 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Charcoal\Image\ImageInterface` as the method `imagickGravity()` does only exist in the following implementations of said interface: `Charcoal\Image\Imagick\ImagickImage`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
24
25		// This sets the gravity for the rest of the chain
26		$this->image()->imagick()->setGravity($gravity);
		0 ignored issues – show Bug introduced 2018-02-23 19:45 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Charcoal\Image\ImageInterface` as the method `imagick()` does only exist in the following implementations of said interface: `Charcoal\Image\Imagick\ImagickImage`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
27
28		// Apply gravity to crop coordinates
29
30		$imageWidth = $this->image()->width();
31		$imageHeight = $this->image()->height();
32
33		switch ($this->image()->imagick()->getGravity()) {
		0 ignored issues – show Bug introduced 2018-02-26 20:37 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Charcoal\Image\ImageInterface` as the method `imagick()` does only exist in the following implementations of said interface: `Charcoal\Image\Imagick\ImagickImage`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
34		case Imagick::GRAVITY_NORTHWEST:
35		break;
36		case Imagick::GRAVITY_NORTH:
37		$x = ($imageWidth / 2 - $width / 2);
38		break;
39		case Imagick::GRAVITY_NORTHEAST:
40		$x = ($imageWidth - $width);
41		break;
42		case Imagick::GRAVITY_WEST:
43		$y = ($imageHeight / 2 - $height / 2);
44		break;
45	View Code Duplication	case Imagick::GRAVITY_CENTER:
		0 ignored issues – show Duplication introduced 2018-02-26 20:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		$x = ($imageWidth / 2 - $width / 2);
47		$y = ($imageHeight / 2 - $height / 2);
48		break;
49	View Code Duplication	case Imagick::GRAVITY_EAST:
		0 ignored issues – show Duplication introduced 2018-02-26 20:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		$x = ($imageWidth - $width);
51		$y = ($imageHeight / 2 - $height / 2);
52		break;
53		case Imagick::GRAVITY_SOUTHWEST:
54		$y = ($imageHeight - $height);
55		break;
56	View Code Duplication	case Imagick::GRAVITY_SOUTH:
		0 ignored issues – show Duplication introduced 2018-02-26 20:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		$x = ($imageWidth / 2 - $width / 2);
58		$y = ($imageHeight - $height);
59		break;
60		case Imagick::GRAVITY_SOUTHEAST:
61		$x = ($imageWidth - $width);
62		$y = ($imageHeight - $height);
63		break;
64		}
65
66		$this->image()->imagick()->cropImage($width, $height, $x, $y);
		0 ignored issues – show Bug introduced 2016-03-29 18:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Charcoal\Image\ImageInterface` as the method `imagick()` does only exist in the following implementations of said interface: `Charcoal\Image\Imagick\ImagickImage`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
67		}
68		}
69

locomotivemtl / charcoal-image

Push — master ( dce39d...eb587f )

ImagickCropEffect A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like