Charcoal\Image\Effect\AbstractCropEffect

Complexity

Total Complexity

18

Size/Duplication

Total Lines	148
Duplicated Lines	6.76 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	setWidth()	0	10	3
A	width()	0	4	1
A	setHeight()	10	10	3
A	height()	0	4	1
A	setX()	0	10	3
A	x()	0	4	1
A	setY()	0	10	3
A	process()	0	15	2
	doCrop()	0	1	?

<?php

namespace Charcoal\Image\Effect;

use \Exception;
use \InvalidArgumentException;

use \Charcoal\Image\AbstractEffect;

/**
 * Resize an image to given dimensions
 */
abstract class AbstractCropEffect extends AbstractEffect
{
    /**
    * @var integer $x
    */
    private $x = 0;
    /**
    * @var integer $y
    */
    private $y = 0;
    /**
    * @var integer $width
    */
    private $width = 0;
    /**
    * @var integer $height
    */
    private $height = 0;

    /**
    * @param int $width
    * @throws InvalidArgumentException
    * @return Rotate Chainable
    */
    public function setWidth($width)
    {
        if (!is_int($width) || ($width < 0)) {
            throw new InvalidArgumentException(
                'Width must be a a positive integer'
            );
        }
        $this->width = $width;
        return $this;
    }

    /**
    * @return float
    */
    public function width()
    {
        return $this->width;
    }

    /**
    * @param integer $height
    * @throws InvalidArgumentException
    * @return $this Chainable
    */
    public function setHeight($height)

This method seems to be duplicated in your project.

    {
        if (!is_int($height) || ($height < 0)) {
            throw new InvalidArgumentException(
                'Height must be a positive integer'
            );
        }
        $this->height = $height;
        return $this;
    }

    /**
    * @return float
    */
    public function height()
    {
        return $this->height;
    }

    /**
    * The X coordinate of the cropped region's top left corner
    *
    * @param integer $x
    * @throws InvalidArgumentException
    * @return $this Chainable
    */
    public function setX($x)
    {
        if (!is_int($x) || ($x < 0)) {
            throw new InvalidArgumentException(
                'Height must be a positive integer'
            );
        }
        $this->x = $x;
        return $this;
    }

    /**
    * @return float
    */
    public function x()
    {
        return $this->x;
    }

    /**
    * The Y coordinate of the cropped region's top left corner
    *
    * @param integer $y
    * @throws InvalidArgumentException
    * @return $this Chainable
    */
    public function setY($y)
    {
        if (!is_int($y) || ($y < 0)) {
            throw new InvalidArgumentException(
                'Height must be a positive integer'
            );
        }
        $this->y = $y;
        return $this;
    }

    /**
    * @return float
    */
    public function x()
    {
        return $this->x;
    }

    /**
    * @param array $data
    * @throws Exception
    * @return AbstractResizeEffect Chainable
    */
    public function process(array $data = null)
    {
        if ($data !== null) {
            $this->setData($data);
        }

        $y = $this->y();

The method y() does not seem to exist on object<Charcoal\Image\Effect\AbstractCropEffect>.

        $x = $this->x();
        $width = $this->width();
        $height = $this->height();

        $this->doCrop($x, $y, $width, $height);

        return $this;
    }

    /**
    * @param integer $width
    * @param integer $height
    * @param boolean $best_fit

There is no parameter named $best_fit. Was it maybe removed?

    * @return void
    */
    abstract protected function doCrop($x, $y, $width, $height);
}