Charcoal\Model\ModelValidator

Complexity

Total Complexity

5

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	validate()	0	20	5

<?php

namespace Charcoal\Model;

// From 'charcoal-core'
use Charcoal\Validator\AbstractValidator;

/**
 *
 */
class ModelValidator extends AbstractValidator
{
    /**
     * @return boolean
     */
    public function validate()
    {
        $model = $this->model;

        $props = $model->properties();

The method properties() does not exist on Charcoal\Validator\ValidatableInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Charcoal\Tests\Mock\ValidatableClass. Are you sure you never get one of those?

        $ret = true;
        foreach ($props as $ident => $p) {
            if (!$p ||  !$p->active()) {
                continue;
            }
            $valid = $p->validate();
            if ($valid === false) {
                $validator = $p->validator();
                $this->merge($validator, $ident);
                $ret = false;
            }
        }

        return $ret;
    }
}