Passed
Push — master ( 247e64...08f14c )
by Chauncey
02:53
created
src/Charcoal/Cms/Service/Manager/NewsManager.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         $loader->addOrder('news_date', 'desc');
123 123
 
124 124
         if ($this->category()) {
125
-            $loader->addFilter('category', $this->category(), [ 'operator' => 'in' ]);
125
+            $loader->addFilter('category', $this->category(), ['operator' => 'in']);
126 126
         }
127 127
         if ($this->numPerPage()) {
128 128
             $loader->setPage($this->page());
@@ -223,8 +223,8 @@  discard block
 block discarded – undo
223 223
 
224 224
         $ids = explode(',', $ids);
225 225
 
226
-        $loader->addFilter('id', $ids, [ 'operator' => 'in' ])
227
-            ->addOrder('id', 'values', [ 'values' => $ids ]);
226
+        $loader->addFilter('id', $ids, ['operator' => 'in'])
227
+            ->addOrder('id', 'values', ['values' => $ids]);
228 228
 
229 229
         if (count($options) > 0) {
230 230
             foreach ($options as $key => $option) {
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
         $loader->addOrder('news_date', 'desc');
273 273
 
274 274
         if ($this->category()) {
275
-            $loader->addFilter('category', $this->category(), [ 'operator' => 'in' ]);
275
+            $loader->addFilter('category', $this->category(), ['operator' => 'in']);
276 276
         }
277 277
         if ($this->numPerPage()) {
278 278
             $loader->setPage($this->page());
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
     /**
151 151
      * @param integer|null $id The news id.
152
-     * @return mixed
152
+     * @return NewsInterface
153 153
      */
154 154
     public function entry($id = null)
155 155
     {
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
     }
317 317
 
318 318
     /**
319
-     * @return mixed The previous news
319
+     * @return NewsInterface The previous news
320 320
      */
321 321
     public function prev()
322 322
     {
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
     }
329 329
 
330 330
     /**
331
-     * @return mixed The next news
331
+     * @return NewsInterface The next news
332 332
      */
333 333
     public function next()
334 334
     {
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
 
401 401
     /**
402 402
      * Amount of news (total)
403
-     * @return integer How many news?
403
+     * @return boolean How many news?
404 404
      */
405 405
     public function numNews()
406 406
     {
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
442 442
     }
443 443
 
444 444
     /**
445
-     * @return mixed
445
+     * @return string
446 446
      */
447 447
     public function objType()
448 448
     {
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
     }
451 451
 
452 452
     /**
453
-     * @return mixed
453
+     * @return string
454 454
      */
455 455
     public function featIdent()
456 456
     {
Please login to merge, or discard this patch.
src/Charcoal/Cms/Config/NewsConfig.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
     }
60 60
 
61 61
     /**
62
-     * @return boolean Entry cycle.
62
+     * @return string Entry cycle.
63 63
      */
64 64
     public function entryCycle()
65 65
     {
Please login to merge, or discard this patch.
src/Charcoal/Cms/Support/Helpers/DateHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -263,7 +263,7 @@
 block discarded – undo
263 263
     }
264 264
 
265 265
     /**
266
-     * @param mixed $format DateTime to be formatted.
266
+     * @param string $format DateTime to be formatted.
267 267
      * @return mixed
268 268
      */
269 269
     private function crossPlatformFormat($format)
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -199,18 +199,18 @@  discard block
 block discarded – undo
199 199
                            ? $this->translator()->translation($case['formats']['to'])
200 200
                            : null;
201 201
 
202
-        $formats['from'] = $this->crossPlatformFormat((string)$formats['from']);
203
-        $formats['to']   = $this->crossPlatformFormat((string)$formats['to']);
202
+        $formats['from'] = $this->crossPlatformFormat((string) $formats['from']);
203
+        $formats['to']   = $this->crossPlatformFormat((string) $formats['to']);
204 204
 
205 205
         if (!$this->to || !$formats['to']) {
206 206
             return sprintf(
207
-                (string)$content,
207
+                (string) $content,
208 208
                 strftime($formats['from'], $this->from->getTimestamp())
209 209
             );
210 210
         }
211 211
 
212 212
         return sprintf(
213
-            (string)$content,
213
+            (string) $content,
214 214
             strftime($formats['from'], $this->from->getTimestamp()),
215 215
             strftime($formats['to'], $this->to->getTimestamp())
216 216
         );
@@ -235,13 +235,13 @@  discard block
 block discarded – undo
235 235
 
236 236
         if (!$this->to || !$formats['to']) {
237 237
             return sprintf(
238
-                (string)$content,
238
+                (string) $content,
239 239
                 strftime($formats['from'], $this->from->getTimestamp())
240 240
             );
241 241
         }
242 242
 
243 243
         return sprintf(
244
-            (string)$content,
244
+            (string) $content,
245 245
             strftime($formats['from'], $this->from->getTimestamp()),
246 246
             strftime($formats['to'], $this->to->getTimestamp())
247 247
         );
Please login to merge, or discard this patch.
src/Charcoal/Property/TemplateProperty.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,8 +3,6 @@
 block discarded – undo
3 3
 namespace Charcoal\Property;
4 4
 
5 5
 use PDO;
6
-
7
-use RuntimeException;
8 6
 use InvalidArgumentException;
9 7
 
10 8
 // From Pimple
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
                 }
100 100
 
101 101
                 $struct    = $this->availableTemplates[$choiceIdent];
102
-                $immutable = [ 'value' => $struct['value'] ];
102
+                $immutable = ['value' => $struct['value']];
103 103
 
104 104
                 return array_replace($struct, $choice, $immutable);
105 105
             } elseif (isset($choice['template']) || isset($choice['controller']) || isset($choice['class'])) {
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
                 return '';
140 140
             }
141 141
         } elseif ($val instanceof Translation) {
142
-            $propertyValue = (string)$val;
142
+            $propertyValue = (string) $val;
143 143
         } else {
144 144
             $propertyValue = $val;
145 145
         }
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
         $val = $this->val();
188 188
         if ($this->hasChoice($val)) {
189 189
             $choice = $this->choice($val);
190
-            $keys   = [ 'controller', 'template', 'class' ];
190
+            $keys   = ['controller', 'template', 'class'];
191 191
             foreach ($keys as $key) {
192 192
                 if (isset($choice[$key])) {
193 193
                     return $choice[$key];
Please login to merge, or discard this patch.
src/Charcoal/Cms/Service/Loader/SectionLoader.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
         $loader = $this->all();
74 74
         $operator = [];
75 75
         if (!$this->baseSection()) {
76
-            $operator = [ 'operator' => 'IS NULL' ];
76
+            $operator = ['operator' => 'IS NULL'];
77 77
         }
78 78
         $loader->addFilter('master', $this->baseSection(), $operator);
79 79
 
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@  discard block
 block discarded – undo
2 2
 
3 3
 namespace Charcoal\Cms\Service\Loader;
4 4
 
5
-use Exception;
6
-
7 5
 // From 'charcoal-core'
8 6
 use Charcoal\Loader\CollectionLoader;
9 7
 
@@ -11,7 +9,6 @@  discard block
 block discarded – undo
11 9
 use Charcoal\Object\ObjectRoute;
12 10
 
13 11
 // From 'charcoal-translator'
14
-use Charcoal\Translator\TranslatorAwareTrait;
15 12
 
16 13
 /**
17 14
  * Section Loader
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@
 block discarded – undo
222 222
     }
223 223
 
224 224
     /**
225
-     * @return object
225
+     * @return string
226 226
      */
227 227
     public function objType()
228 228
     {
Please login to merge, or discard this patch.
src/Charcoal/Property/TemplateOptionsProperty.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
     public function addStructureInterface($interface)
35 35
     {
36 36
         if ($interface instanceof TemplateProperty) {
37
-            $interface = (string)$interface;
37
+            $interface = (string) $interface;
38 38
             if (empty($interface)) {
39 39
                 throw new InvalidArgumentException(
40 40
                     'Invalid template structure interface'
Please login to merge, or discard this patch.
src/Charcoal/Cms/Route/NewsRoute.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@
 block discarded – undo
118 118
     protected function loadNewsFromPath(Container $container)
119 119
     {
120 120
         if (!$this->news) {
121
-            $config  = $this->config();
121
+            $config = $this->config();
122 122
             $type   = (isset($config['obj_type']) ? $config['obj_type'] : $this->objType);
123 123
             $model  = $container['model/factory']->create($type);
124 124
 
Please login to merge, or discard this patch.
src/Charcoal/Cms/Route/EventRoute.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@
 block discarded – undo
118 118
     protected function loadEventFromPath(Container $container)
119 119
     {
120 120
         if (!$this->event) {
121
-            $config  = $this->config();
121
+            $config = $this->config();
122 122
             $type   = (isset($config['obj_type']) ? $config['obj_type'] : $this->objType);
123 123
             $model  = $container['model/factory']->create($type);
124 124
 
Please login to merge, or discard this patch.
src/Charcoal/Cms/Route/SectionRoute.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,8 +88,8 @@
 block discarded – undo
88 88
             return $response->withStatus(404);
89 89
         }
90 90
 
91
-        $templateIdent      = (string)$section->templateIdent();
92
-        $templateController = (string)$section->templateIdent();
91
+        $templateIdent      = (string) $section->templateIdent();
92
+        $templateController = (string) $section->templateIdent();
93 93
 
94 94
         if (!$templateController) {
95 95
             return $response->withStatus(404);
Please login to merge, or discard this patch.