Charcoal\Cms\Section\ExternalSection

Complexity

Total Complexity

2

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setExternalUrl()	0	6	1
A	externalUrl()	0	4	1

<?php

namespace Charcoal\Cms\Section;

// From 'charcoal-cms'
use Charcoal\Cms\AbstractSection;

/**
 * External section may appear in menus and breadcrumbs, but only
 *
 * Unlike all other section types, they do not provide any metadata information.
 */
class ExternalSection extends AbstractSection

There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: hasProperty, p, properties, property

{
    /**
     * @var Translation|string|null
     */
    private $externalUrl;

    /**
     * @param  mixed $url The external URL (localized).
     * @return self
     */
    public function setExternalUrl($url)
    {
        $this->externalUrl = $this->translator()->translation($url);

        return $this;
    }

    /**
     * @return Translation|string|null
     */
    public function externalUrl()
    {
        return $this->externalUrl;

The expression $this->externalUrl; of type Charcoal\Cms\Section\Translation|string|null adds the type Charcoal\Cms\Section\Translation to the return on line 36 which is incompatible with the return type declared by the interface Charcoal\Cms\SectionInterface::externalUrl of type string.

    }
}