Test Failed
Push — master ( 65160c...18a7d4 )
by Mathieu
08:45
created
src/Charcoal/Property/TemplateProperty.php 2 patches
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,9 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use PDO;
6 6
 
7
-use RuntimeException;
8
-use InvalidArgumentException;
9
-
10 7
 // From Pimple
11 8
 use Pimple\Container;
12 9
 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
                 return '';
129 129
             }
130 130
         } elseif ($val instanceof Translation) {
131
-            $propertyValue = (string)$val;
131
+            $propertyValue = (string) $val;
132 132
         } else {
133 133
             $propertyValue = $val;
134 134
         }
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
         $val = $this->val();
177 177
         if ($this->hasChoice($val)) {
178 178
             $choice = $this->choice($val);
179
-            $keys   = [ 'controller', 'template', 'class' ];
179
+            $keys   = ['controller', 'template', 'class'];
180 180
             foreach ($keys as $key) {
181 181
                 if (isset($choice[$key])) {
182 182
                     return $choice[$key];
Please login to merge, or discard this patch.
src/Charcoal/Admin/Widget/Cms/SectionTableTrait.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Charcoal\Admin\Widget\Cms;
4 4
 
5
-use Exception;
6 5
 use RuntimeException;
7 6
 
8 7
 // From 'charcoal-core'
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 
97 97
                 switch ($sectionType) {
98 98
                     case AbstractSection::TYPE_EXTERNAL:
99
-                        $externalUrl = (string)$object->externalUrl();
99
+                        $externalUrl = (string) $object->externalUrl();
100 100
                         $linkExcerpt = '';
101 101
                         $tagTemplate = '<span class="glyphicon glyphicon-link" data-toggle="tooltip" '.
102 102
                             'data-placement="auto" title="%1$s"></span>';
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         }
124 124
 
125 125
         if ($propertyIdent === 'title') {
126
-            if (is_callable([ $object, 'navMenu' ]) && $object->navMenu()) {
126
+            if (is_callable([$object, 'navMenu']) && $object->navMenu()) {
127 127
                 $propertyValue .= sprintf(
128 128
                     ' &nbsp; '.
129 129
                     '<span class="glyphicon glyphicon-list" data-toggle="tooltip" '.
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
                 );
136 136
             }
137 137
 
138
-            if (is_callable([ $object, 'locked' ]) && $object->locked()) {
138
+            if (is_callable([$object, 'locked']) && $object->locked()) {
139 139
                 $propertyValue .= sprintf(
140 140
                     ' &nbsp; '.
141 141
                     '<span class="glyphicon glyphicon-lock" data-toggle="tooltip" '.
Please login to merge, or discard this patch.
src/Charcoal/Cms/AbstractSection.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use InvalidArgumentException;
6 6
 
7 7
 // From 'charcoal-core'
8
-use Charcoal\Model\Collection;
9 8
 use Charcoal\Loader\CollectionLoader;
10 9
 
11 10
 // From 'charcoal-object'
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     {
129 129
         parent::__construct($data);
130 130
 
131
-        if (is_callable([ $this, 'defaultData' ])) {
131
+        if (is_callable([$this, 'defaultData'])) {
132 132
             $this->setData($this->defaultData());
133 133
         }
134 134
     }
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
          * an empty string, or an object.
491 491
          */
492 492
         if (!is_array($value)) {
493
-            return [ $value ];
493
+            return [$value];
494 494
         }
495 495
 
496 496
         return $value;
Please login to merge, or discard this patch.
src/Charcoal/Cms/ServiceProvider/CmsServiceProvider.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -12,13 +12,11 @@
 block discarded – undo
12 12
 use Pimple\ServiceProviderInterface;
13 13
 
14 14
 // Local dependencies
15
-use Charcoal\Cms\Config;
16 15
 
17 16
 // Cms Loaders
18 17
 use Charcoal\Cms\Service\Loader\SectionLoader;
19 18
 
20 19
 // dependencies from `charcoal-core`
21
-use Charcoal\Model\AbstractModel;
22 20
 
23 21
 // dependencies from `charcoal-cms`
24 22
 use Charcoal\Cms\SectionInterface;
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
          * @param Container $container
52 52
          * @return CmsConfig Website configurations (from cms.json).
53 53
          */
54
-        $container['cms/config'] = function (Container $container) {
54
+        $container['cms/config'] = function(Container $container) {
55 55
             $appConfig = $container['config'];
56 56
             $cms = $appConfig->get('cms');
57 57
 
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
          * @param Container $container Pimple DI Container.
84 84
          * @return DateHelper
85 85
          */
86
-        $container['date/helper'] = function (Container $container) {
86
+        $container['date/helper'] = function(Container $container) {
87 87
 
88 88
             trigger_error(sprintf(
89 89
                 '%s is deprecated, use %s instead',
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
          * @param Container $container Pimple DI Container.
103 103
          * @return DateHelper
104 104
          */
105
-        $container['cms/date/helper'] = function (Container $container) {
105
+        $container['cms/date/helper'] = function(Container $container) {
106 106
 
107 107
             return new DateHelper([
108 108
                 'date_formats' => $container['cms/config']->get('date_formats'),
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
          * @param Container $container Pimple DI Container.
127 127
          * @return GenericFactory
128 128
          */
129
-        $container['cms/section/factory'] = function (Container $container) {
129
+        $container['cms/section/factory'] = function(Container $container) {
130 130
             return new GenericFactory([
131 131
                 'base_class'       => SectionInterface::class,
132 132
                 'arguments'        => $container['model/factory']->arguments(),
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
          * @param Container $container Pimple DI Container.
141 141
          * @return SectionLoader
142 142
          */
143
-        $container['cms/section/loader'] = function (Container $container) {
143
+        $container['cms/section/loader'] = function(Container $container) {
144 144
             $sectionLoader = new SectionLoader([
145 145
                 'loader'     => $container['model/collection/loader'],
146 146
                 'factory'    => $container['model/factory'],
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
          * @param Container $container Pimple DI Container.
170 170
          * @return NewsLoader
171 171
          */
172
-        $container['cms/news/loader'] = function (Container $container) {
172
+        $container['cms/news/loader'] = function(Container $container) {
173 173
             $newsLoader = new NewsLoader([
174 174
                 'loader'     => $container['model/collection/loader'],
175 175
                 'factory'    => $container['model/factory'],
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
          * @param Container $container
191 191
          * @return NewsManager
192 192
          */
193
-        $container['cms/news/manager'] = function (Container $container) {
193
+        $container['cms/news/manager'] = function(Container $container) {
194 194
 
195 195
             $newsManager = new NewsManager([
196 196
                 'loader'      => $container['model/collection/loader'],
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
          * @param Container $container Pimple DI Container.
216 216
          * @return EventLoader
217 217
          */
218
-        $container['cms/event/loader'] = function (Container $container) {
218
+        $container['cms/event/loader'] = function(Container $container) {
219 219
             $eventLoader = new EventLoader([
220 220
                 'loader'     => $container['model/collection/loader'],
221 221
                 'factory'    => $container['model/factory'],
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
          * @param Container $container
240 240
          * @return EventManager
241 241
          */
242
-        $container['cms/event/manager'] = function (Container $container) {
242
+        $container['cms/event/manager'] = function(Container $container) {
243 243
 
244 244
             $eventManager = new EventManager([
245 245
                 'loader'       => $container['model/collection/loader'],
Please login to merge, or discard this patch.
src/Charcoal/Cms/NewsCategory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
     {
32 32
         parent::__construct($data);
33 33
 
34
-        if (is_callable([ $this, 'defaultData' ])) {
34
+        if (is_callable([$this, 'defaultData'])) {
35 35
             $this->setData($this->defaultData());
36 36
         }
37 37
     }
Please login to merge, or discard this patch.
src/Charcoal/Cms/Service/Loader/EventLoader.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     {
55 55
         $now = new DateTime();
56 56
         $loader = $this->all();
57
-        $loader->addFilter('publish_date', $now->format('Y-m-d H:i:s'), [ 'operator' => '<=' ])
57
+        $loader->addFilter('publish_date', $now->format('Y-m-d H:i:s'), ['operator' => '<='])
58 58
             ->addOrder('start_date', 'asc');
59 59
 
60 60
         return $loader;
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
     {
96 96
         $date = $this->parseAsDate($date);
97 97
         $loader = $this->published();
98
-        $loader->addFilter('end_date', $date->format('Y-m-d H:i:s'), [ 'operator' => '>=' ]);
98
+        $loader->addFilter('end_date', $date->format('Y-m-d H:i:s'), ['operator' => '>=']);
99 99
 
100 100
         return $loader;
101 101
     }
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
     {
112 112
         $date = $this->parseAsDate($date);
113 113
         $loader = $this->published();
114
-        $loader->addFilter('end_date', $date->format('Y-m-d H:i:s'), [ 'operator' => '<' ]);
114
+        $loader->addFilter('end_date', $date->format('Y-m-d H:i:s'), ['operator' => '<']);
115 115
 
116 116
         return $loader;
117 117
     }
Please login to merge, or discard this patch.
src/Charcoal/Cms/Service/Loader/NewsLoader.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
47 47
     {
48 48
         $now = new DateTime();
49 49
         $loader = $this->all();
50
-        $loader->addFilter('publish_date', $now->format('Y-m-d H:i:s'), [ 'operator' => '<=' ])
51
-            ->addFilter('expiry_date', $now->format('Y-m-d H:i:s'), [ 'operator' => '>=' ]);
50
+        $loader->addFilter('publish_date', $now->format('Y-m-d H:i:s'), ['operator' => '<='])
51
+            ->addFilter('expiry_date', $now->format('Y-m-d H:i:s'), ['operator' => '>=']);
52 52
 
53 53
         return $loader;
54 54
     }
@@ -60,8 +60,8 @@  discard block
 block discarded – undo
60 60
     {
61 61
         $now = new DateTime();
62 62
         $loader = $this->all();
63
-        $loader->addFilter('publish_date', $now->format('Y-m-d H:i:s'), [ 'operator' => '<=' ])
64
-            ->addFilter('expiry_date', $now->format('Y-m-d H:i:s'), [ 'operator' => '<=' ]);
63
+        $loader->addFilter('publish_date', $now->format('Y-m-d H:i:s'), ['operator' => '<='])
64
+            ->addFilter('expiry_date', $now->format('Y-m-d H:i:s'), ['operator' => '<=']);
65 65
 
66 66
         return $loader;
67 67
     }
Please login to merge, or discard this patch.
src/Charcoal/Cms/Service/Manager/EventManager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
         }
217 217
 
218 218
         if ($this->category()) {
219
-            $loader->addFilter('category', $this->category(), [ 'operator' => 'in' ]);
219
+            $loader->addFilter('category', $this->category(), ['operator' => 'in']);
220 220
         }
221 221
 
222 222
         if ($this->numPerPage()) {
@@ -321,8 +321,8 @@  discard block
 block discarded – undo
321 321
 
322 322
         $ids = explode(',', $ids);
323 323
 
324
-        $loader->addFilter('id', $ids, [ 'operator' => 'in' ])
325
-            ->addOrder('id', 'values', [ 'values' => $ids ]);
324
+        $loader->addFilter('id', $ids, ['operator' => 'in'])
325
+            ->addOrder('id', 'values', ['values' => $ids]);
326 326
 
327 327
         if (count($options) > 0) {
328 328
             foreach ($options as $key => $option) {
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
         $loader = $this->loader()->archive();
370 370
 
371 371
         if ($this->category()) {
372
-            $loader->addFilter('category', $this->category(), [ 'operator' => 'in' ]);
372
+            $loader->addFilter('category', $this->category(), ['operator' => 'in']);
373 373
         }
374 374
         if ($this->numPerPage()) {
375 375
             $loader->setPage($this->page());
Please login to merge, or discard this patch.
src/Charcoal/Cms/Service/Manager/NewsManager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         $loader->addOrder('news_date', 'desc');
123 123
 
124 124
         if ($this->category()) {
125
-            $loader->addFilter('category', $this->category(), [ 'operator' => 'in' ]);
125
+            $loader->addFilter('category', $this->category(), ['operator' => 'in']);
126 126
         }
127 127
         if ($this->numPerPage()) {
128 128
             $loader->setPage($this->page());
@@ -223,8 +223,8 @@  discard block
 block discarded – undo
223 223
 
224 224
         $ids = explode(',', $ids);
225 225
 
226
-        $loader->addFilter('id', $ids, [ 'operator' => 'in' ])
227
-            ->addOrder('id', 'values', [ 'values' => $ids ]);
226
+        $loader->addFilter('id', $ids, ['operator' => 'in'])
227
+            ->addOrder('id', 'values', ['values' => $ids]);
228 228
 
229 229
         if (count($options) > 0) {
230 230
             foreach ($options as $key => $option) {
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
         $loader->addOrder('news_date', 'desc');
273 273
 
274 274
         if ($this->category()) {
275
-            $loader->addFilter('category', $this->category(), [ 'operator' => 'in' ]);
275
+            $loader->addFilter('category', $this->category(), ['operator' => 'in']);
276 276
         }
277 277
         if ($this->numPerPage()) {
278 278
             $loader->setPage($this->page());
Please login to merge, or discard this patch.