locomotivemtl / charcoal-attachment

src/Charcoal/Attachment/Object/Attachment.php

Doc Comments +8 added lines, -8 removed lines

@@ -324,7 +324,7 @@ 
      *
      * @param  string $type The attachment type.
      * @throws InvalidArgumentException If provided argument is not of type 'string'.
-     * @return string
+     * @return Attachment
      */
     public function setType($type)
     {
@@ -765,7 +765,7 @@ 
     /**
      * Retrieve the attachment's sub-title.
      *
-     * @return Translation|string|null
+     * @return null|Translation
      */
     public function subtitle()
     {
@@ -775,7 +775,7 @@ 
     /**
      * Retrieve attachment's description.
      *
-     * @return Translation|string|null
+     * @return null|Translation
      */
     public function description()
     {
@@ -795,7 +795,7 @@ 
     /**
      * Retrieve the path to the thumbnail associated with the object.
      *
-     * @return string|null
+     * @return string
      */
     public function thumbnail()
     {
@@ -838,7 +838,7 @@ 
     /**
      * Retrieve the file label.
      *
-     * @return string|null
+     * @return null|Translation
      */
     public function fileLabel()
     {
@@ -848,7 +848,7 @@ 
     /**
      * Retrieve the link label.
      *
-     * @return string|null
+     * @return null|Translation
      */
     public function linkLabel()
     {
@@ -893,7 +893,7 @@ 
     }
 
     /**
-     * @return ModelInterface|mixed
+     * @return ModelInterface
      */
     public function presenter()
     {
@@ -1001,7 +1001,7 @@ 
      * Prepend the base URI to the given path.
      *
      * @param  string $text A string to parse relative URIs.
-     * @return UriInterface|null
+     * @return string
      */
     protected function resolveUrls($text)
     {

Spacing +9 added lines, -9 removed lines

@@ -196,7 +196,7 @@ 
     {
         parent::__construct($data);
 
-        if (is_callable([ $this, 'defaultData' ])) {
+        if (is_callable([$this, 'defaultData'])) {
             $defaultData = $this->metadata()->defaultData();
             if ($defaultData) {
                 $this->setData($defaultData);
@@ -372,7 +372,7 @@ 
      */
     public function heading()
     {
-        $heading = $this->render((string)$this->heading);
+        $heading = $this->render((string) $this->heading);
 
         if (!$heading) {
             $heading = $this->translator()->translation('{{ objType }} #{{ id }}', [
@@ -415,7 +415,7 @@ 
     public function preview()
     {
         if ($this->preview) {
-            return $this->render((string)$this->preview);
+            return $this->render((string) $this->preview);
         }
 
         return '';
@@ -1008,19 +1008,19 @@ 
         static $search;
 
         if ($search === null) {
-            $attr   = [ 'href', 'link', 'url', 'src' ];
-            $scheme = [ '../', './', '/', 'data', 'mailto', 'http' ];
+            $attr   = ['href', 'link', 'url', 'src'];
+            $scheme = ['../', './', '/', 'data', 'mailto', 'http'];
 
             $search = sprintf(
                 '(?<=%1$s=")(?!%2$s)(\S+)(?=")',
-                implode('="|', array_map('preg_quote', $attr, [ '~' ])),
-                implode('|', array_map('preg_quote', $scheme, [ '~' ]))
+                implode('="|', array_map('preg_quote', $attr, ['~'])),
+                implode('|', array_map('preg_quote', $scheme, ['~']))
             );
         }
 
         $text = preg_replace_callback(
             '~'.$search.'~i',
-            function ($matches) {
+            function($matches) {
                 return $this->createAbsoluteUrl($matches[1]);
             },
             $text
@@ -1039,7 +1039,7 @@ 
     protected function isRelativeUri($uri)
     {
         if ($uri && !parse_url($uri, PHP_URL_SCHEME)) {
-            if (!in_array($uri[0], [ '/', '#', '?' ])) {
+            if (!in_array($uri[0], ['/', '#', '?'])) {
                 return true;
             }
         }

tests/Charcoal/ContainerProvider.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 use League\CLImate\Util\UtilFactory;
 
 // From 'charcoal-core'
-use Charcoal\Source\DatabaseSource;
 use Charcoal\Model\ServiceProvider\ModelServiceProvider;
 
 // From 'charcoal-user'

Spacing +12 added lines, -12 removed lines

@@ -82,11 +82,11 @@ 
      */
     public function registerBaseUrl(Container $container)
     {
-        $container['base-url'] = function () {
+        $container['base-url'] = function() {
             return Uri::createFromString('');
         };
 
-        $container['admin/base-url'] = function () {
+        $container['admin/base-url'] = function() {
             return Uri::createFromString('admin');
         };
     }
@@ -99,7 +99,7 @@ 
      */
     public function registerConfig(Container $container)
     {
-        $container['config'] = function () {
+        $container['config'] = function() {
             return new AppConfig([
                 'base_path'  => realpath(__DIR__.'/../../..'),
                 'apis'       => [
@@ -149,7 +149,7 @@ 
     {
         $this->registerConfig($container);
 
-        $container['admin/config'] = function () {
+        $container['admin/config'] = function() {
             return new AdminConfig();
         };
     }
@@ -160,7 +160,7 @@ 
      */
     public function registerClimate(Container $container)
     {
-        $container['climate/system'] = function () {
+        $container['climate/system'] = function() {
             $system = Mockery::mock(Linux::class);
             $system->shouldReceive('hasAnsiSupport')->andReturn(true);
             $system->shouldReceive('width')->andReturn(80);
@@ -168,7 +168,7 @@ 
             return $system;
         };
 
-        $container['climate/output'] = function () {
+        $container['climate/output'] = function() {
             $output = Mockery::mock(Output::class);
             $output->shouldReceive('persist')->andReturn($output);
             $output->shouldReceive('sameLine')->andReturn($output);
@@ -177,7 +177,7 @@ 
             return $output;
         };
 
-        $container['climate/reader'] = function () {
+        $container['climate/reader'] = function() {
             $reader = Mockery::mock(Stdin::class);
             $reader->shouldReceive('line')->andReturn('line');
             $reader->shouldReceive('char')->andReturn('char');
@@ -185,11 +185,11 @@ 
             return $reader;
         };
 
-        $container['climate/util'] = function (Container $container) {
+        $container['climate/util'] = function(Container $container) {
             return new UtilFactory($container['climate/system']);
         };
 
-        $container['climate'] = function (Container $container) {
+        $container['climate'] = function(Container $container) {
             $climate = new CLImate();
 
             $climate->setOutput($container['climate/output']);
@@ -206,7 +206,7 @@ 
      */
     public function registerDatabase(Container $container)
     {
-        $container['database'] = function () {
+        $container['database'] = function() {
             $pdo = new PDO('sqlite::memory:');
             $pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
             return $pdo;
@@ -294,7 +294,7 @@ 
      */
     public function registerLogger(Container $container)
     {
-        $container['logger'] = function () {
+        $container['logger'] = function() {
             return new NullLogger();
         };
     }
@@ -305,7 +305,7 @@ 
      */
     public function registerCache(Container $container)
     {
-        $container['cache'] = function () {
+        $container['cache'] = function() {
             return new Pool();
         };
     }