FlexformSelection::addReleations() - Code Metrics - lochmueller/tagger - Measure and Improve Code Quality continuously with Scrutinizer

FlexformSelection::addReleations() A
last analyzed 2016-06-15 19:05 UTC

↳ Parent: FlexformSelection

Complexity

Conditions	3
Paths	3

Size

Total Lines	20
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	0
loc	20
rs	9.4285
cc	3
eloc	14
nc	3
nop	2

<?php

/**
 * Flexform selection
 */

namespace HDNET\Tagger\Service;

use TYPO3\CMS\Backend\Utility\IconUtility;
use TYPO3\CMS\Core\Database\DatabaseConnection;

/**
 * Flexform selection
 */
class FlexformSelection
{

    /**
     * Add the possible relation to the flexform selection of the tagger plugin
     *
     * @param array $config
     * @param object $obj
     */
    public function addReleations(&$config, &$obj)

    {
        /** @var DatabaseConnection $databaseConnection */
        $databaseConnection = $GLOBALS['TYPO3_DB'];
        $rows = $databaseConnection->exec_SELECTgetRows(
            'tablenames',
            'tx_tagger_tag_mm',
            '1=1',
            'tablenames',
            'tablenames DESC'
        );
        foreach ($rows as $row) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $table = $row['tablenames'];
            $icon = IconUtility::getSpriteIconForRecord($table, []);

            if (substr($icon, 0, 4) == 'gfx/') {
                $icon = str_replace('gfx/', '', $icon);
            }
            $config['items'][] = [$table, $table, $icon];
        }
    }
}


1			<?php
2
3			/**
4			* Flexform selection
5			*/
6
7			namespace HDNET\Tagger\Service;
8
9			use TYPO3\CMS\Backend\Utility\IconUtility;
10			use TYPO3\CMS\Core\Database\DatabaseConnection;
11
12			/**
13			* Flexform selection
14			*/
15			class FlexformSelection
16			{
17
18			/**
19			* Add the possible relation to the flexform selection of the tagger plugin
20			*
21			* @param array $config
22			* @param object $obj
23			*/
24			public function addReleations(&$config, &$obj)
			0 ignored issues – show Unused Code introduced 2016-06-15 17:26 UTC by Report Bug Copy Issue Report The parameter `$obj` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
25			{
26			/** @var DatabaseConnection $databaseConnection */
27			$databaseConnection = $GLOBALS['TYPO3_DB'];
28			$rows = $databaseConnection->exec_SELECTgetRows(
29			'tablenames',
30			'tx_tagger_tag_mm',
31			'1=1',
32			'tablenames',
33			'tablenames DESC'
34			);
35			foreach ($rows as $row) {
			0 ignored issues – show Bug introduced 2016-06-15 18:50 UTC by Report Bug Copy Issue Report The expression `$rows` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
36			$table = $row['tablenames'];
37			$icon = IconUtility::getSpriteIconForRecord($table, []);
			0 ignored issues – show Deprecated Code introduced 2016-06-15 18:50 UTC by Report Bug Copy Issue Report The method `TYPO3\CMS\Backend\Utilit...etSpriteIconForRecord()` has been deprecated with message: since TYPO3 CMS 7, will be removed with TYPO3 CMS 8 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
38			if (substr($icon, 0, 4) == 'gfx/') {
39			$icon = str_replace('gfx/', '', $icon);
40			}
41			$config['items'][] = [$table, $table, $icon];
42			}
43			}
44			}
45

lochmueller / tagger

FlexformSelection::addReleations() A last analyzed 2016-06-15 19:05 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

FlexformSelection::addReleations() A
last analyzed 2016-06-15 19:05 UTC