SuggestReceiverCall::createTag() - Code Metrics - lochmueller/tagger - Measure and Improve Code Quality continuously with Scrutinizer

SuggestReceiverCall::createTag() C
last analyzed 2016-06-15 19:05 UTC

↳ Parent: SuggestReceiverCall

Complexity

Conditions	7
Paths	11

Size

Total Lines	35
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	35
rs	6.7272
cc	7
eloc	22
nc	11
nop	2

<?php

/**
 * Suggest call
 */

namespace HDNET\Tagger\Hooks;

use HDNET\Tagger\Service;
use TYPO3\CMS\Core\Database\DatabaseConnection;
use TYPO3\CMS\Core\Http\AjaxRequestHandler;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Class SuggestReceiverCall
 */
class SuggestReceiverCall
{

    const TAG = 'tx_tagger_domain_model_tag';
    const LLPATH = 'LLL:EXT:tagger/Resources/Private/Language/locallang.xml:tag_suggest_';

    /**
     * Create a tag
     *
     * @param array $params
     * @param AjaxRequestHandler $ajaxObj
     * @return void
     */
    public function createTag(array $params, AjaxRequestHandler $ajaxObj)

    {
        $request = GeneralUtility::_POST();

        try {
            // check if a tag is submitted
            if (!isset($request['item']) || empty($request['item'])) {
                throw new \Exception('error_no-tag');
            }

            $newsUid = $request['newsid'];
            if ((int)$newsUid === 0 && (strlen($newsUid) == 16 && !GeneralUtility::isFirstPartOfStr($newsUid, 'NEW'))) {
                throw new \Exception('error_no-newsid');
            }

            // get tag uid
            $newTagId = $this->getTagUid($request);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            $ajaxObj->setContentFormat('javascript');
            $ajaxObj->setContent('');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $response = [
                $newTagId,
                $request['item'],
                'tx_tagger_domain_model_tag',
                self::TAG,
                'tags',
                'data[tx_tagger_domain_model_tag][' . $newsUid . '][tags]',
                $newsUid
            ];
            $ajaxObj->setJavascriptCallbackWrap(implode('-', $response));
        } catch (\Exception $e) {
            //$errorMsg = $GLOBALS['LANG']->sL(self::LLPATH . );
            $ajaxObj->setError($e->getMessage());
        }
    }

    /**
     * Get the uid of the tag, either bei inserting as new or get existing
     *
     * @param array $request ajax request
     * @return int
     * @throws \Exception
     */
    protected function getTagUid(array $request)
    {
        /** @var DatabaseConnection $databaseConnection */
        $databaseConnection = $GLOBALS['TYPO3_DB'];
        $record = $databaseConnection->exec_SELECTgetSingleRow(
            '*',
            'tx_tagger_domain_model_tag',
            'deleted=0 AND title=' . $databaseConnection->fullQuoteStr($request['item'], 'tx_tagger_domain_model_tag')
        );
        if (isset($record['uid'])) {
            $tagUid = (int)$record['uid'];
        } else {
            $tagUid = Service\IntegrationService::createTagRecord($request['item']);
        }

        if ($tagUid == 0) {
            throw new \Exception('error_no-tag-created');
        }

        return $tagUid;
    }
}


1			<?php
2
3			/**
4			* Suggest call
5			*/
6
7			namespace HDNET\Tagger\Hooks;
8
9			use HDNET\Tagger\Service;
10			use TYPO3\CMS\Core\Database\DatabaseConnection;
11			use TYPO3\CMS\Core\Http\AjaxRequestHandler;
12			use TYPO3\CMS\Core\Utility\GeneralUtility;
13
14			/**
15			* Class SuggestReceiverCall
16			*/
17			class SuggestReceiverCall
18			{
19
20			const TAG = 'tx_tagger_domain_model_tag';
21			const LLPATH = 'LLL:EXT:tagger/Resources/Private/Language/locallang.xml:tag_suggest_';
22
23			/**
24			* Create a tag
25			*
26			* @param array $params
27			* @param AjaxRequestHandler $ajaxObj
28			* @return void
29			*/
30			public function createTag(array $params, AjaxRequestHandler $ajaxObj)
			0 ignored issues – show Unused Code introduced 2016-06-15 17:26 UTC by Report Bug Copy Issue Report The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
31			{
32			$request = GeneralUtility::_POST();
33
34			try {
35			// check if a tag is submitted
36			if (!isset($request['item']) \|\| empty($request['item'])) {
37			throw new \Exception('error_no-tag');
38			}
39
40			$newsUid = $request['newsid'];
41			if ((int)$newsUid === 0 && (strlen($newsUid) == 16 && !GeneralUtility::isFirstPartOfStr($newsUid, 'NEW'))) {
42			throw new \Exception('error_no-newsid');
43			}
44
45			// get tag uid
46			$newTagId = $this->getTagUid($request);
			0 ignored issues – show Bug introduced 2016-06-15 18:50 UTC by Report Bug Copy Issue Report It seems like `$request` defined by `\TYPO3\CMS\Core\Utility\GeneralUtility::_POST()` on line `32` can also be of type `string`; however, `HDNET\Tagger\Hooks\Sugge...ceiverCall::getTagUid()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
47
48			$ajaxObj->setContentFormat('javascript');
49			$ajaxObj->setContent('');
			0 ignored issues – show Documentation introduced 2016-06-15 18:50 UTC by Report Bug Copy Issue Report `''` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50			$response = [
51			$newTagId,
52			$request['item'],
53			'tx_tagger_domain_model_tag',
54			self::TAG,
55			'tags',
56			'data[tx_tagger_domain_model_tag][' . $newsUid . '][tags]',
57			$newsUid
58			];
59			$ajaxObj->setJavascriptCallbackWrap(implode('-', $response));
60			} catch (\Exception $e) {
61			//$errorMsg = $GLOBALS['LANG']->sL(self::LLPATH . );
62			$ajaxObj->setError($e->getMessage());
63			}
64			}
65
66			/**
67			* Get the uid of the tag, either bei inserting as new or get existing
68			*
69			* @param array $request ajax request
70			* @return int
71			* @throws \Exception
72			*/
73			protected function getTagUid(array $request)
74			{
75			/** @var DatabaseConnection $databaseConnection */
76			$databaseConnection = $GLOBALS['TYPO3_DB'];
77			$record = $databaseConnection->exec_SELECTgetSingleRow(
78			'*',
79			'tx_tagger_domain_model_tag',
80			'deleted=0 AND title=' . $databaseConnection->fullQuoteStr($request['item'], 'tx_tagger_domain_model_tag')
81			);
82			if (isset($record['uid'])) {
83			$tagUid = (int)$record['uid'];
84			} else {
85			$tagUid = Service\IntegrationService::createTagRecord($request['item']);
86			}
87
88			if ($tagUid == 0) {
89			throw new \Exception('error_no-tag-created');
90			}
91
92			return $tagUid;
93			}
94			}
95

lochmueller / tagger

SuggestReceiverCall::createTag() C last analyzed 2016-06-15 19:05 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SuggestReceiverCall::createTag() C
last analyzed 2016-06-15 19:05 UTC