lochmueller / language_detection

Classes/Service/LanguageService.php

<?php

declare(strict_types=1);

namespace Lochmueller\LanguageDetection\Service;

use Locale;
use ResourceBundle;

class LanguageService
{
    public function getLanguageByCountry(string $country): string
    {
        /** @var ResourceBundle $subtags */
        $subtags = ResourceBundle::create('likelySubtags', 'ICUDATA', false);
        $dummy = 'und_' . strtoupper($country);
        $locale = $subtags->get($dummy) ?: $subtags->get('und');

        return Locale::getPrimaryLanguage($locale);

The expression return Locale::getPrimaryLanguage($locale) could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}