IpLocation::__construct() - Code Metrics - Inspection of "style: Construct promotion and tests fixes for v12" - lochmueller/language_detection - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( ca09ad...1c062a )

by Tim

created 2024-01-17 08:48 UTC

IpLocation::__construct() A

↳ Parent: IpLocation

Complexity

Conditions	1
Paths	1

Size

Total Lines	1
Code Lines	0

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	0
nc	1
nop	1
dl	0
loc	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Lochmueller\LanguageDetection\Service;

use Psr\Http\Message\RequestFactoryInterface;
use TYPO3\CMS\Core\Http\Client\GuzzleClientFactory;
use TYPO3\CMS\Core\Information\Typo3Version;
use TYPO3\CMS\Core\Utility\GeneralUtility;

class IpLocation
{
    public function __construct(private RequestFactoryInterface $requestFactory) {}

    public function getCountryCode(string $ip): ?string
    {
        if ($ip === '') {
            return null;
        }
        $urlService = 'http://www.geoplugin.net/php.gp?ip=' . $ip;
        try {
            $request = $this->requestFactory->createRequest('GET', $urlService);
            $response = $this->getClient()->send($request);

            if ($response->getStatusCode() !== 200) {
                throw new IpLocationException('Missing information in response', 123781);
            }
            $result = (array)unserialize((string)$response->getBody(), ['allowed_classes' => false]);

            if (empty($result) || (int)$result['geoplugin_status'] === 404) {
                throw new IpLocationException('No valid data', 162378);
            }

            return $result['geoplugin_countryCode'] ?? null;
        } catch (IpLocationException $exc) {
            return null;
        }
    }

    protected function getClient(): \Psr\Http\Client\ClientInterface
    {
        if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() >= 12) {
            return GeneralUtility::makeInstance(GuzzleClientFactory::class)->getClient();
        }
        return GuzzleClientFactory::getClient();

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Lochmueller\LanguageDetection\Service;
6
7			use Psr\Http\Message\RequestFactoryInterface;
8			use TYPO3\CMS\Core\Http\Client\GuzzleClientFactory;
9			use TYPO3\CMS\Core\Information\Typo3Version;
10			use TYPO3\CMS\Core\Utility\GeneralUtility;
11
12			class IpLocation
13			{
14			public function __construct(private RequestFactoryInterface $requestFactory) {}
15
16			public function getCountryCode(string $ip): ?string
17			{
18			if ($ip === '') {
19			return null;
20			}
21			$urlService = 'http://www.geoplugin.net/php.gp?ip=' . $ip;
22			try {
23			$request = $this->requestFactory->createRequest('GET', $urlService);
24			$response = $this->getClient()->send($request);
25
26			if ($response->getStatusCode() !== 200) {
27			throw new IpLocationException('Missing information in response', 123781);
28			}
29			$result = (array)unserialize((string)$response->getBody(), ['allowed_classes' => false]);
30
31			if (empty($result) \|\| (int)$result['geoplugin_status'] === 404) {
32			throw new IpLocationException('No valid data', 162378);
33			}
34
35			return $result['geoplugin_countryCode'] ?? null;
36			} catch (IpLocationException $exc) {
37			return null;
38			}
39			}
40
41			protected function getClient(): \Psr\Http\Client\ClientInterface
42			{
43			if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() >= 12) {
44			return GeneralUtility::makeInstance(GuzzleClientFactory::class)->getClient();
45			}
46			return GuzzleClientFactory::getClient();
			0 ignored issues – show Bug Best Practice introduced 2024-01-17 09:01 UTC by Report Bug Copy Issue Report The expression `return TYPO3\CMS\Core\Ht...entFactory::getClient()` returns the type `GuzzleHttp\ClientInterface` which is incompatible with the type-hinted return `Psr\Http\Client\ClientInterface`. Loading history...
47			}
48			}
49

lochmueller / language_detection

Push — main ( ca09ad...1c062a )

IpLocation::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like