lochmueller / ink

Classes/Postprocessing/InlineCss.php

<?php
/**
 * Inliner for CSS
 *
 * @author  Tim Lochmüller
 */

namespace FRUIT\Ink\Postprocessing;

use TijsVerkoyen\CssToInlineStyles\CssToInlineStyles;
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\HttpUtility;
use TYPO3\CMS\Extbase\Utility\DebuggerUtility;

/**
 * Inliner for CSS
 */
class InlineCss implements PostprocessingInterface
{

    /**
     * Call the inliner CSS processor
     *
     * @param string $content
     *
     * @return string
     */
    public function process($content)
    {
        GeneralUtility::requireOnce(ExtensionManagementUtility::extPath('ink', 'Resources/Private/Php/vendor/autoload.php'));
        $pattern = '%<(link|style)(?=[^<>]*?(?:type="(text/css)"|>))(?=[^<>]*?(?:media="([^<>"]*)"|>))(?=[^<>]*?(?:href="(.*?)"|>))(?=[^<>]*(?:rel="([^<>"]*)"|>))(?:.*?</\1>|[^<>]*>)%si';
        $matches = array();
        $css = '';
        preg_match_all($pattern, $content, $matches);
        if (isset($matches[0])) {
            foreach ($matches[0] as $key => $match) {
                if ($matches[1][$key] === 'style') {
                    $css .= strip_tags($match);
                } elseif (strpos($match, 'type="text/css"') !== false) {
                    $file = preg_replace('/^(.+)\.(\d+)\.css$/', '$1.css', $matches[4][$key]);
                    $parts = parse_url($file);
                    if (isset($parts['query'])) {
                        unset($parts['query']);
                    }
                    if (!isset($parts['host'])) {
                        $parts['path'] = ltrim($parts['path'], '/');
                    }

                    if ($parts['host'] === GeneralUtility::getIndpEnv('TYPO3_HOST_ONLY')) {
                        unset($parts['scheme']);
                        unset($parts['host']);
                        $parts['path'] = ltrim($parts['path'], '/');
                    }

                    $file = HttpUtility::buildUrl($parts);

It seems like $parts defined by parse_url($file) on line 42 can also be of type false; however, TYPO3\CMS\Core\Utility\HttpUtility::buildUrl() does only seem to accept array, did you maybe forget to handle an error condition?

                    $css .= GeneralUtility::getUrl($file);
                } else {
                    continue;
                }
                $content = str_replace($match, '', $content);
            }
        }
        $format = new CssToInlineStyles($content, $css);
        return $format->convert();
    }
}