Templavoila::renderInternal() - Code Metrics - lochmueller/ink - Measure and Improve Code Quality continuously with Scrutinizer

Templavoila::renderInternal() A
last analyzed 2016-06-15 20:40 UTC

↳ Parent: Templavoila

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	16
rs	9.4285
cc	3
eloc	10
nc	3
nop	0

<?php
/**
 * Render templavoila
 *
 * @author Tim Lochmüller
 */

namespace FRUIT\Ink\Rendering;

use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Render templavoila
 */
class Templavoila extends AbstractRendering
{

    /**
     * Render the given element
     *
     * @return array
     */
    public function renderInternal()
    {

        // TV nicht geladen
        if (!ExtensionManagementUtility::isLoaded('templavoila')) {
            $defaultOutput = $this->configuration['defaultOutput'];
            if ($defaultOutput) {
                $defaultOutput = str_replace('###CType###', $this->contentObject->data['CType'], $defaultOutput);
            }
            return $defaultOutput;
        }
        $pi1 = GeneralUtility::makeInstance('tx_templavoila_pi1');
        $pi1->cObj = $this->contentObject;
        $lines[] = $pi1->renderElement($this->contentObject->data, 'tt_content');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        return $lines;
    }
}


1			<?php
2			/**
3			* Render templavoila
4			*
5			* @author Tim Lochmüller
6			*/
7
8			namespace FRUIT\Ink\Rendering;
9
10			use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
11			use TYPO3\CMS\Core\Utility\GeneralUtility;
12
13			/**
14			* Render templavoila
15			*/
16			class Templavoila extends AbstractRendering
17			{
18
19			/**
20			* Render the given element
21			*
22			* @return array
23			*/
24			public function renderInternal()
25			{
26
27			// TV nicht geladen
28			if (!ExtensionManagementUtility::isLoaded('templavoila')) {
29			$defaultOutput = $this->configuration['defaultOutput'];
30			if ($defaultOutput) {
31			$defaultOutput = str_replace('###CType###', $this->contentObject->data['CType'], $defaultOutput);
32			}
33			return $defaultOutput;
34			}
35			$pi1 = GeneralUtility::makeInstance('tx_templavoila_pi1');
36			$pi1->cObj = $this->contentObject;
37			$lines[] = $pi1->renderElement($this->contentObject->data, 'tt_content');
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-06-15 17:29 UTC by Report Bug Copy Issue Report `$lines` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$lines = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
38			return $lines;
39			}
40			}
41

lochmueller / ink

Templavoila::renderInternal() A last analyzed 2016-06-15 20:40 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Templavoila::renderInternal() A
last analyzed 2016-06-15 20:40 UTC