Menu - Code Metrics - lochmueller/ink - Measure and Improve Code Quality continuously with Scrutinizer

Menu A
last analyzed 2016-06-15 20:40 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	7
c	3
b	0
f	0
lcom	1
cbo	4
dl	0
loc	54
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	renderInternal()	0	6	1
B	breakBulletList()	0	30	6

<?php
/**
 * Render Ctype menu
 *
 * @author Tim Lochmüller
 */

namespace FRUIT\Ink\Rendering;

use FRUIT\Ink\Configuration;
use TYPO3\CMS\Core\Utility\MathUtility;
use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;

/**
 * Render Ctype menu
 */
class Menu extends AbstractRendering
{

    /**
     * Render the given element
     *
     * @return array
     */
    public function renderInternal()
    {
        $str = $this->contentObject->cObjGetSingle($this->configuration['menu'], $this->configuration['menu.']);
        $str = $this->breakBulletList($this->contentObject, trim(strip_tags(preg_replace('/<br\s*\/?>/i', chr(10), $this->parseBody($str)))));
        return $str;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Breaks content lines into a bullet list
     *
     * @param ContentObjectRenderer $contentObject
     * @param string                $str Content string to make into a bullet list
     *
     * @return string Processed value
     */
    public function breakBulletList($contentObject, $str)
    {
        $type = $contentObject->data['layout'];
        $type = MathUtility::forceIntegerInRange($type, 0, 3);

        $tConf = $this->configuration['bulletlist.'][$type . '.'];

        $cParts = explode(chr(10), $str);
        $lines = array();
        $c = 0;

        foreach ($cParts as $substrs) {
            if (!strlen($substrs)) {
                continue;
            }
            $c++;
            $bullet = $tConf['bullet'] ? $tConf['bullet'] : ' - ';
            $bLen = strlen($bullet);
            $bullet = substr(str_replace('#', $c, $bullet), 0, $bLen);
            $secondRow = substr($tConf['secondRow'] ? $tConf['secondRow'] : str_pad('', strlen($bullet), ' '), 0, $bLen);

            $lines[] = $bullet . $this->breakLines($substrs, chr(10) . $secondRow, Configuration::getPlainTextWith() - $bLen);

            $blanks = MathUtility::forceIntegerInRange($tConf['blanks'], 0, 1000);
            if ($blanks) {
                $lines[] = str_pad('', $blanks - 1, chr(10));
            }
        }
        return implode(chr(10), $lines);
    }
}


1			<?php
2			/**
3			* Render Ctype menu
4			*
5			* @author Tim Lochmüller
6			*/
7
8			namespace FRUIT\Ink\Rendering;
9
10			use FRUIT\Ink\Configuration;
11			use TYPO3\CMS\Core\Utility\MathUtility;
12			use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
13
14			/**
15			* Render Ctype menu
16			*/
17			class Menu extends AbstractRendering
18			{
19
20			/**
21			* Render the given element
22			*
23			* @return array
24			*/
25			public function renderInternal()
26			{
27			$str = $this->contentObject->cObjGetSingle($this->configuration['menu'], $this->configuration['menu.']);
28			$str = $this->breakBulletList($this->contentObject, trim(strip_tags(preg_replace('/<br\s*\/?>/i', chr(10), $this->parseBody($str)))));
29			return $str;
			0 ignored issues – show Bug Best Practice introduced 2016-06-15 17:29 UTC by Report Bug Copy Issue Report The return type of `return $str;` (`string`) is incompatible with the return type declared by the interface `FRUIT\Ink\Rendering\Rend...terface::renderInternal` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
30			}
31
32			/**
33			* Breaks content lines into a bullet list
34			*
35			* @param ContentObjectRenderer $contentObject
36			* @param string $str Content string to make into a bullet list
37			*
38			* @return string Processed value
39			*/
40			public function breakBulletList($contentObject, $str)
41			{
42			$type = $contentObject->data['layout'];
43			$type = MathUtility::forceIntegerInRange($type, 0, 3);
44
45			$tConf = $this->configuration['bulletlist.'][$type . '.'];
46
47			$cParts = explode(chr(10), $str);
48			$lines = array();
49			$c = 0;
50
51			foreach ($cParts as $substrs) {
52			if (!strlen($substrs)) {
53			continue;
54			}
55			$c++;
56			$bullet = $tConf['bullet'] ? $tConf['bullet'] : ' - ';
57			$bLen = strlen($bullet);
58			$bullet = substr(str_replace('#', $c, $bullet), 0, $bLen);
59			$secondRow = substr($tConf['secondRow'] ? $tConf['secondRow'] : str_pad('', strlen($bullet), ' '), 0, $bLen);
60
61			$lines[] = $bullet . $this->breakLines($substrs, chr(10) . $secondRow, Configuration::getPlainTextWith() - $bLen);
62
63			$blanks = MathUtility::forceIntegerInRange($tConf['blanks'], 0, 1000);
64			if ($blanks) {
65			$lines[] = str_pad('', $blanks - 1, chr(10));
66			}
67			}
68			return implode(chr(10), $lines);
69			}
70			}
71

lochmueller / ink

Menu A last analyzed 2016-06-15 20:40 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

Menu A
last analyzed 2016-06-15 20:40 UTC