AccessService::isProtectionForm() - Code Metrics - Inspection of "Migrate vendor namespace from FRUIT to HVP" - lochmueller/html5videoplayer_powermail - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bbe443...f4a6ec )

by Tim

created 2016-06-17 04:51 UTC

AccessService::isProtectionForm() A

↳ Parent: AccessService

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php
/**
 * Handling the detail page access
 *
 * @package    Html5videoplayerPowermail\Service
 * @author     Tim Lochmüller
 */

namespace HVP\Html5videoplayerPowermail\Service;

use HVP\Html5videoplayerPowermail\Utility\GlobalUtility;
use HVP\Html5videoplayer\Domain\Model\Video;
use In2code\Powermail\Domain\Model\Form;
use TYPO3\CMS\Backend\Utility\BackendUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\HttpUtility;
use TYPO3\CMS\Core\Utility\MathUtility;
use TYPO3\CMS\Frontend\Page\PageRepository;

/**
 * Handling the detail page access
 *
 * @author     Tim Lochmüller
 */
class AccessService extends AbstractService
{

    /**
     * Session service
     *
     * @var \HVP\Html5videoplayerPowermail\Service\SessionService
     * @inject
     */
    protected $sessionService;

    /**
     * Uri Builder
     *
     * @var \TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder
     * @inject
     */
    protected $uriBuilder;

    /**
     * Flexform service
     *
     * @var \TYPO3\CMS\Extbase\Service\FlexFormService
     * @inject
     */
    protected $flexFormService;

    /**
     * The session name
     *
     * @var string
     */
    protected $sessionName = 'submittedForms';

    /**
     * @param Video $video
     */
    public function checkVideoAccess(Video $video = null)
    {
        if ($video === null) {
            return;
        }

        $formProtection = $this->getFormProtection($video);
        if ($formProtection <= 0) {
            return;
        }

        // disable the cache
        GlobalUtility::getTypoScriptFrontendController()
            ->set_no_cache('Do not cache video detail page, because every request is check via html5videoplayer_powermail');

        if ($this->isAccessableByCurrentUser($formProtection)) {
            return;
        }

        $formPage = $this->findFormPage($formProtection);
        if ($formPage) {
            $this->sessionService->set('videoReturnUrl', GeneralUtility::getIndpEnv('TYPO3_REQUEST_URL'));

            $uri = $this->uriBuilder->setTargetPageUid($formPage)
                ->build();
            HttpUtility::redirect($uri, HttpUtility::HTTP_STATUS_403);
        }
    }

    /**
     * @param Form $form
     */
    public function triggerFormSubmit(Form $form)
    {
        if ($this->sessionService->has('videoReturnUrl') && $this->isProtectionForm($form)) {
            $forms = $this->sessionService->has($this->sessionName) ? $this->sessionService->get($this->sessionName) : [];
            $forms[] = $form->getUid();
            $this->sessionService->set($this->sessionName, $forms);
            HttpUtility::redirect($this->sessionService->get('videoReturnUrl'));
        }
    }

    /**
     * Find the given page UID of the form Protection ID
     *
     * @param int $formProtectionId
     *
     * @return int
     */
    protected function findFormPage($formProtectionId)
    {
        $pluings = $this->findPowermailPlugins();
        foreach ($pluings as $plugin) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $configuration = $this->flexFormService->convertFlexFormContentToArray($plugin['pi_flexform']);
            if (isset($configuration['settings']['flexform']['main']['form'])) {
                $formId = $configuration['settings']['flexform']['main']['form'];
                if (MathUtility::canBeInterpretedAsInteger($formId) && (int)$formId == $formProtectionId) {
                    return $plugin['pid'];
                }
            }
        }
        return 0;
    }

    /**
     * Find all includes Powermail plugins
     *
     * @return array
     */
    protected function findPowermailPlugins()
    {
        $database = GlobalUtility::getDatabaseConnection();
        $pageRepository = new PageRepository();
        return $database->exec_SELECTgetRows('uid,pid,pi_flexform', 'tt_content', 'CType="list" AND list_type="powermail_pi1"' . $pageRepository->enableFields('tt_content'));
    }

    /**
     * @param $formProtectionId
     *
     * @return bool
     */
    protected function isAccessableByCurrentUser($formProtectionId)
    {
        $forms = $this->sessionService->has($this->sessionName) ? $this->sessionService->get($this->sessionName) : [];
        return in_array((int)$formProtectionId, $forms);
    }

    /**
     * @param Form $form
     *
     * @return bool
     */
    protected function isProtectionForm(Form $form)
    {
        return (bool)GlobalUtility::getDatabaseConnection()
            ->exec_SELECTcountRows('*', 'tx_html5videoplayer_domain_model_video', 'powermail_protection=' . $form->getUid());
    }

    /**
     * Get the Form protection value
     *
     * @param Video $video
     *
     * @return int
     */
    protected function getFormProtection(Video $video)
    {
        $record = BackendUtility::getRecord('tx_html5videoplayer_domain_model_video', $video->getUid());
        return (int)$record['powermail_protection'];
    }
}


1			<?php
2			/**
3			* Handling the detail page access
4			*
5			* @package Html5videoplayerPowermail\Service
6			* @author Tim Lochmüller
7			*/
8
9			namespace HVP\Html5videoplayerPowermail\Service;
10
11			use HVP\Html5videoplayerPowermail\Utility\GlobalUtility;
12			use HVP\Html5videoplayer\Domain\Model\Video;
13			use In2code\Powermail\Domain\Model\Form;
14			use TYPO3\CMS\Backend\Utility\BackendUtility;
15			use TYPO3\CMS\Core\Utility\GeneralUtility;
16			use TYPO3\CMS\Core\Utility\HttpUtility;
17			use TYPO3\CMS\Core\Utility\MathUtility;
18			use TYPO3\CMS\Frontend\Page\PageRepository;
19
20			/**
21			* Handling the detail page access
22			*
23			* @author Tim Lochmüller
24			*/
25			class AccessService extends AbstractService
26			{
27
28			/**
29			* Session service
30			*
31			* @var \HVP\Html5videoplayerPowermail\Service\SessionService
32			* @inject
33			*/
34			protected $sessionService;
35
36			/**
37			* Uri Builder
38			*
39			* @var \TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder
40			* @inject
41			*/
42			protected $uriBuilder;
43
44			/**
45			* Flexform service
46			*
47			* @var \TYPO3\CMS\Extbase\Service\FlexFormService
48			* @inject
49			*/
50			protected $flexFormService;
51
52			/**
53			* The session name
54			*
55			* @var string
56			*/
57			protected $sessionName = 'submittedForms';
58
59			/**
60			* @param Video $video
61			*/
62			public function checkVideoAccess(Video $video = null)
63			{
64			if ($video === null) {
65			return;
66			}
67
68			$formProtection = $this->getFormProtection($video);
69			if ($formProtection <= 0) {
70			return;
71			}
72
73			// disable the cache
74			GlobalUtility::getTypoScriptFrontendController()
75			->set_no_cache('Do not cache video detail page, because every request is check via html5videoplayer_powermail');
76
77			if ($this->isAccessableByCurrentUser($formProtection)) {
78			return;
79			}
80
81			$formPage = $this->findFormPage($formProtection);
82			if ($formPage) {
83			$this->sessionService->set('videoReturnUrl', GeneralUtility::getIndpEnv('TYPO3_REQUEST_URL'));
84
85			$uri = $this->uriBuilder->setTargetPageUid($formPage)
86			->build();
87			HttpUtility::redirect($uri, HttpUtility::HTTP_STATUS_403);
88			}
89			}
90
91			/**
92			* @param Form $form
93			*/
94			public function triggerFormSubmit(Form $form)
95			{
96			if ($this->sessionService->has('videoReturnUrl') && $this->isProtectionForm($form)) {
97			$forms = $this->sessionService->has($this->sessionName) ? $this->sessionService->get($this->sessionName) : [];
98			$forms[] = $form->getUid();
99			$this->sessionService->set($this->sessionName, $forms);
100			HttpUtility::redirect($this->sessionService->get('videoReturnUrl'));
101			}
102			}
103
104			/**
105			* Find the given page UID of the form Protection ID
106			*
107			* @param int $formProtectionId
108			*
109			* @return int
110			*/
111			protected function findFormPage($formProtectionId)
112			{
113			$pluings = $this->findPowermailPlugins();
114			foreach ($pluings as $plugin) {
			0 ignored issues – show Bug introduced 2016-06-15 18:30 UTC by Report Bug Copy Issue Report The expression `$pluings` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
115			$configuration = $this->flexFormService->convertFlexFormContentToArray($plugin['pi_flexform']);
116			if (isset($configuration['settings']['flexform']['main']['form'])) {
117			$formId = $configuration['settings']['flexform']['main']['form'];
118			if (MathUtility::canBeInterpretedAsInteger($formId) && (int)$formId == $formProtectionId) {
119			return $plugin['pid'];
120			}
121			}
122			}
123			return 0;
124			}
125
126			/**
127			* Find all includes Powermail plugins
128			*
129			* @return array
130			*/
131			protected function findPowermailPlugins()
132			{
133			$database = GlobalUtility::getDatabaseConnection();
134			$pageRepository = new PageRepository();
135			return $database->exec_SELECTgetRows('uid,pid,pi_flexform', 'tt_content', 'CType="list" AND list_type="powermail_pi1"' . $pageRepository->enableFields('tt_content'));
136			}
137
138			/**
139			* @param $formProtectionId
140			*
141			* @return bool
142			*/
143			protected function isAccessableByCurrentUser($formProtectionId)
144			{
145			$forms = $this->sessionService->has($this->sessionName) ? $this->sessionService->get($this->sessionName) : [];
146			return in_array((int)$formProtectionId, $forms);
147			}
148
149			/**
150			* @param Form $form
151			*
152			* @return bool
153			*/
154			protected function isProtectionForm(Form $form)
155			{
156			return (bool)GlobalUtility::getDatabaseConnection()
157			->exec_SELECTcountRows('*', 'tx_html5videoplayer_domain_model_video', 'powermail_protection=' . $form->getUid());
158			}
159
160			/**
161			* Get the Form protection value
162			*
163			* @param Video $video
164			*
165			* @return int
166			*/
167			protected function getFormProtection(Video $video)
168			{
169			$record = BackendUtility::getRecord('tx_html5videoplayer_domain_model_video', $video->getUid());
170			return (int)$record['powermail_protection'];
171			}
172			}
173

lochmueller / html5videoplayer_powermail

Push — master ( bbe443...f4a6ec )

AccessService::isProtectionForm() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like