Sitemap::getRecords() - Code Metrics - lochmueller/google_services - Measure and Improve Code Quality continuously with Scrutinizer

Sitemap::getRecords() C
last analyzed 2021-01-21 19:23 UTC

↳ Parent: Sitemap

Complexity

Conditions	11
Paths	10

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	57
rs	6.7915
c	0
b	0
f	0
cc	11
nc	10
nop	3

How to fix Long Method Complexity

<?php

/**
 * Sitemap Provider
 */

namespace FRUIT\GoogleServices\Service\SitemapProvider;

use FRUIT\GoogleServices\Controller\SitemapController;
use FRUIT\GoogleServices\Domain\Model\Node;
use FRUIT\GoogleServices\Service\SitemapProviderInterface;
use TYPO3\CMS\Backend\Utility\BackendUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Frontend\Page\PageRepository;

/**
 * Sitemap Provider
 *
 * @author timlochmueller
 */
class Sitemap implements SitemapProviderInterface
{

    /**
     * Get the Records
     *
     * @param integer $startPage
     * @param array $basePages
     * @param SitemapController $obj
     *
     * @return array
     */
    public function getRecords($startPage, $basePages, SitemapController $obj): array
    {
        $nodes = [];
        $database = $this->getDatabaseConnection();
        /** @var PageRepository $pageRepository */
        $pageRepository = GeneralUtility::makeInstance(PageRepository::class);
        $rows = $database->exec_SELECTgetRows('*', 'tt_content', 'CType=' . $database->fullQuoteStr(
            'list',
            'tt_content'
        ) . ' AND list_type=' . $database->fullQuoteStr(
            'googleservices_pisitemap',
            'tt_content'
        ) . $pageRepository->enableFields('tt_content'));

        foreach ($rows as $row) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $uid = $row['pid'];
            if ($uid == $GLOBALS['TSFE']->id) {
                continue;
            }

            // Build URL
            $url = $obj->getUriBuilder()
                ->setTargetPageUid($uid)
                ->build();

            // can't generate a valid url
            if (!strlen($url)) {
                continue;
            }

            // Get Record
            $record = BackendUtility::getRecord('pages', $uid);

            // Check FE Access
            if ($record['fe_group'] != 0 || $record['no_search'] != 0) {
                continue;
            }
            $rootLineList = $GLOBALS['TSFE']->sys_page->getRootLine($record['uid']);
            $addToNode = true;
            foreach ($rootLineList as $rootPage) {
                if ($rootPage['extendToSubpages'] == 1 && ($rootPage['fe_group'] != 0 || $record['no_search'] != 0)) {
                    $addToNode = false;
                    break;
                }
            }
            if ($addToNode === false) {
                continue;
            }

            // Build Node
            $node = new Node();
            $node->setLoc($url);
            $node->setLastmod($this->getModifiedDate($record));
            $nodes[] = $node;
        }
        return $nodes;
    }

    /**
     * get the modifiedDate
     *
     * @param array $record
     *
     * @return integer
     */
    protected function getModifiedDate($record)
    {
        // Last mod
        $lastMod = $record['crdate'];
        if ($record['tstamp'] > $lastMod) {
            $lastMod = $record['tstamp'];
        }
        if ($record['SYS_LASTCHANGED'] > $lastMod) {
            $lastMod = $record['SYS_LASTCHANGED'];
        }
        return $lastMod;
    }

    /**
     * Get the database connection
     *
     * @return \TYPO3\CMS\Core\Database\DatabaseConnection
     */
    protected function getDatabaseConnection()
    {
        return $GLOBALS['TYPO3_DB'];
    }
}


1			<?php
2
3			/**
4			* Sitemap Provider
5			*/
6
7			namespace FRUIT\GoogleServices\Service\SitemapProvider;
8
9			use FRUIT\GoogleServices\Controller\SitemapController;
10			use FRUIT\GoogleServices\Domain\Model\Node;
11			use FRUIT\GoogleServices\Service\SitemapProviderInterface;
12			use TYPO3\CMS\Backend\Utility\BackendUtility;
13			use TYPO3\CMS\Core\Utility\GeneralUtility;
14			use TYPO3\CMS\Frontend\Page\PageRepository;
15
16			/**
17			* Sitemap Provider
18			*
19			* @author timlochmueller
20			*/
21			class Sitemap implements SitemapProviderInterface
22			{
23
24			/**
25			* Get the Records
26			*
27			* @param integer $startPage
28			* @param array $basePages
29			* @param SitemapController $obj
30			*
31			* @return array
32			*/
33			public function getRecords($startPage, $basePages, SitemapController $obj): array
34			{
35			$nodes = [];
36			$database = $this->getDatabaseConnection();
37			/** @var PageRepository $pageRepository */
38			$pageRepository = GeneralUtility::makeInstance(PageRepository::class);
39			$rows = $database->exec_SELECTgetRows('*', 'tt_content', 'CType=' . $database->fullQuoteStr(
40			'list',
41			'tt_content'
42			) . ' AND list_type=' . $database->fullQuoteStr(
43			'googleservices_pisitemap',
44			'tt_content'
45			) . $pageRepository->enableFields('tt_content'));
46
47			foreach ($rows as $row) {
			0 ignored issues – show Bug introduced 2016-06-15 17:22 UTC by Report Bug Copy Issue Report The expression `$rows` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
48			$uid = $row['pid'];
49			if ($uid == $GLOBALS['TSFE']->id) {
50			continue;
51			}
52
53			// Build URL
54			$url = $obj->getUriBuilder()
55			->setTargetPageUid($uid)
56			->build();
57
58			// can't generate a valid url
59			if (!strlen($url)) {
60			continue;
61			}
62
63			// Get Record
64			$record = BackendUtility::getRecord('pages', $uid);
65
66			// Check FE Access
67			if ($record['fe_group'] != 0 \|\| $record['no_search'] != 0) {
68			continue;
69			}
70			$rootLineList = $GLOBALS['TSFE']->sys_page->getRootLine($record['uid']);
71			$addToNode = true;
72			foreach ($rootLineList as $rootPage) {
73			if ($rootPage['extendToSubpages'] == 1 && ($rootPage['fe_group'] != 0 \|\| $record['no_search'] != 0)) {
74			$addToNode = false;
75			break;
76			}
77			}
78			if ($addToNode === false) {
79			continue;
80			}
81
82			// Build Node
83			$node = new Node();
84			$node->setLoc($url);
85			$node->setLastmod($this->getModifiedDate($record));
86			$nodes[] = $node;
87			}
88			return $nodes;
89			}
90
91			/**
92			* get the modifiedDate
93			*
94			* @param array $record
95			*
96			* @return integer
97			*/
98			protected function getModifiedDate($record)
99			{
100			// Last mod
101			$lastMod = $record['crdate'];
102			if ($record['tstamp'] > $lastMod) {
103			$lastMod = $record['tstamp'];
104			}
105			if ($record['SYS_LASTCHANGED'] > $lastMod) {
106			$lastMod = $record['SYS_LASTCHANGED'];
107			}
108			return $lastMod;
109			}
110
111			/**
112			* Get the database connection
113			*
114			* @return \TYPO3\CMS\Core\Database\DatabaseConnection
115			*/
116			protected function getDatabaseConnection()
117			{
118			return $GLOBALS['TYPO3_DB'];
119			}
120			}
121

lochmueller / google_services

Sitemap::getRecords() C last analyzed 2021-01-21 19:23 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

Sitemap::getRecords() C
last analyzed 2021-01-21 19:23 UTC