QuestionRepository::findByTeaserConfiguration() - Code Metrics - Inspection of "Fix #37 - enable manually sorting by configuration" - lochmueller/faq - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5ff62b...faff63 )

by Tim

created 2019-12-06 07:34 UTC

QuestionRepository::findByTeaserConfiguration() B

↳ Parent: QuestionRepository

Complexity

Conditions	6
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	41
rs	8.6417
c	0
b	0
f	0
cc	6
nc	5
nop	3

<?php

declare(strict_types = 1);
/**
 * Build up the Question.
 */

namespace HDNET\Faq\Domain\Repository;

use HDNET\Faq\Domain\Model\Question;
use HDNET\Faq\Domain\Model\Questioncategory;
use HDNET\Faq\Domain\Model\Request\Faq;
use TYPO3\CMS\Core\Database\ConnectionPool;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Extbase\Persistence\QueryInterface;

/**
 * Build up the Question.
 */
class QuestionRepository extends AbstractRepository
{
    /**
     * Orderings.
     *
     * @var array
     */
    protected $defaultOrderings = [
        'title' => QueryInterface::ORDER_ASCENDING,
    ];

    /**
     * Constructs a new Repository
     *
     * @param \TYPO3\CMS\Extbase\Object\ObjectManagerInterface $objectManager
     */
    public function __construct(\TYPO3\CMS\Extbase\Object\ObjectManagerInterface $objectManager)
    {
        parent::__construct($objectManager);

        $configuration = (array) @\unserialize((string) $GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['faq']);
        $enableManuallySorting = isset($configuration['enableManuallySorting']) ? (bool) $configuration['enableManuallySorting'] : false;

        if ($enableManuallySorting) {
            $this->defaultOrderings = [
                'sorting' => QueryInterface::ORDER_ASCENDING,
            ];
        }
    }


    /**
     * Get the top questions.
     *
     * @param int   $limit
     * @param int   $topCategoryId
     * @param array $topQuestions
     *
     * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
     */
    public function findTop($limit = 5, $topCategoryId = 0, $topQuestions = [])
    {
        $questions = $this->getStaticQuestionsAndReduceLimit($topQuestions, $limit);
        if ($limit > 0) {
            $query = $this->createQuery();
            $constraintsOr = [];
            $constraintsOr[] = $query->contains('categories', $topCategoryId);
            $constraintsOr[] = $query->equals('categories.parent', $topCategoryId);

            $constraintsAnd = [];
            $constraintsAnd[] = $query->logicalOr($constraintsOr);
            if (!empty($topQuestions)) {
                $constraintsAnd[] = $query->logicalNot($query->in('uid', $topQuestions));
            }

            $query->matching($query->logicalAnd($constraintsAnd));

            $query->setOrderings(['topCounter' => QueryInterface::ORDER_DESCENDING]);
            $query->setLimit($limit);
            $results = $query->execute()
                ->toArray();

            $questions = \array_merge($questions, $results);
        }

        return $questions;
    }

    /**
     * Get the newest questions.
     *
     * @param int $limit
     * @param int $topCategoryId
     *
     * @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException
     *
     * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
     */
    public function findNewest($limit = 5, $topCategoryId = 0)
    {
        $query = $this->createQuery();

        $constraintsOr = [];
        $constraintsOr[] = $query->contains('categories', $topCategoryId);
        $constraintsOr[] = $query->equals('categories.parent', $topCategoryId);

        $query->matching($query->logicalOr($constraintsOr));

        $query->setOrderings(['crdate' => QueryInterface::ORDER_DESCENDING]);
        if ($limit) {
            $query->setLimit($limit);
        }

        return $query->execute();
    }

    /**
     * Returns all objects of this repository.
     *
     * @param int $topCategoryId
     *
     * @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException
     *
     * @return \TYPO3\CMS\Extbase\Persistence\QueryResultInterface|array
     */
    public function findAll($topCategoryId = 0)
    {
        if (!$topCategoryId) {
            return parent::findAll();
        }
        $query = $this->createQuery();

        $constraintsOr = [];
        $constraintsOr[] = $query->contains('categories', $topCategoryId);
        $constraintsOr[] = $query->equals('categories.parent', $topCategoryId);

        $query->matching($query->logicalOr($constraintsOr));

        return $query->execute();
    }

    /**
     * Find by FAQ model.
     *
     * @param int $topCategoryId
     *
     * @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException
     *
     * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
     */
    public function findByFaq(Faq $faq, $topCategoryId = 0)
    {
        $query = $this->createQuery();

        $constraintsOr = [];
        $constraintsOr[] = $query->contains('categories', $topCategoryId);
        $constraintsOr[] = $query->equals('categories.parent', $topCategoryId);

        $constraints = [];
        $constraints[] = $query->logicalOr($constraintsOr);

        $categories = GeneralUtility::intExplode(',', \implode(',', $faq->getCategories()), true);
        if ($faq->getCategory() instanceof Questioncategory) {
            $categories[] = (int)$faq->getCategory()
                ->getUid();
        }

        if ($categories) {

            $catSelection = [];
            foreach ($categories as $catId) {
                $catSelection[] = $query->contains('categories', $catId);
            }
            $constraints[] = $query->logicalOr($catSelection);
        }

        if (\mb_strlen($faq->getSearchWord())) {
            $constraints[] = $query->logicalOr([
                $query->like('title', '%' . $faq->getSearchWord() . '%'),
                $query->like('answer', '%' . $faq->getSearchWord() . '%'),
            ]);
        }

        if (\count($constraints)) {
            $query->matching($query->logicalAnd($constraints));
        }

        return $query->execute();
    }

    /**
     * Get the teaser questions.
     *
     * @param int $limit
     *
     * @throws \Exception
     *
     * @return array
     */
    public function findByTeaserConfiguration(array $topQuestions, array $categories, $limit)
    {
        $questions = $this->getStaticQuestionsAndReduceLimit($topQuestions, $limit);
        if ($limit > 0) {
            $t = $this->getTableName();

            $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)->getQueryBuilderForTable('tx_faq_mm_question_questioncategory');
            $queryBuilder
                ->getRestrictions()
                ->removeAll();

            $where = [
                $queryBuilder->expr()->eq($t . '.uid', 'mm.uid_local'),
            ];
            if (\count($topQuestions)) {
                $where[] = $queryBuilder->expr()->notIn($t . '.uid', $topQuestions);
            }
            if (!empty($categories)) {
                $where[] = $queryBuilder->expr()->in('mm.uid_foreign', $categories);
            }

            $rows = $queryBuilder->select($t . '.*')
                ->from($t)
                ->join($t, 'tx_faq_mm_question_questioncategory', 'mm')
                ->where(...$where)
                ->groupBy($t . '.uid')
                ->execute()
                ->fetchAll();

            \shuffle($rows);

            foreach ($rows as $row) {
                $q = $this->findByUid((int)$row['uid']);
                if ($q instanceof Question) {
                    $questions[] = $q;
                }
            }
        }

        return $questions;
    }

    /**
     * Get the Questsions with the given IDS and reduce the limit.
     *
     * @param int $limit
     *
     * @return array
     */
    protected function getStaticQuestionsAndReduceLimit(array $ids, &$limit)
    {
        $questions = [];
        foreach ($ids as $id) {
            $q = $this->findByUid((int)$id);
            if ($q instanceof Question) {
                $questions[] = $q;
                --$limit;
            }
        }

        return $questions;
    }
}


1			<?php
2
3			declare(strict_types = 1);
4			/**
5			* Build up the Question.
6			*/
7
8			namespace HDNET\Faq\Domain\Repository;
9
10			use HDNET\Faq\Domain\Model\Question;
11			use HDNET\Faq\Domain\Model\Questioncategory;
12			use HDNET\Faq\Domain\Model\Request\Faq;
13			use TYPO3\CMS\Core\Database\ConnectionPool;
14			use TYPO3\CMS\Core\Utility\GeneralUtility;
15			use TYPO3\CMS\Extbase\Persistence\QueryInterface;
16
17			/**
18			* Build up the Question.
19			*/
20			class QuestionRepository extends AbstractRepository
21			{
22			/**
23			* Orderings.
24			*
25			* @var array
26			*/
27			protected $defaultOrderings = [
28			'title' => QueryInterface::ORDER_ASCENDING,
29			];
30
31			/**
32			* Constructs a new Repository
33			*
34			* @param \TYPO3\CMS\Extbase\Object\ObjectManagerInterface $objectManager
35			*/
36			public function __construct(\TYPO3\CMS\Extbase\Object\ObjectManagerInterface $objectManager)
37			{
38			parent::__construct($objectManager);
39
40			$configuration = (array) @\unserialize((string) $GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['faq']);
41			$enableManuallySorting = isset($configuration['enableManuallySorting']) ? (bool) $configuration['enableManuallySorting'] : false;
42
43			if ($enableManuallySorting) {
44			$this->defaultOrderings = [
45			'sorting' => QueryInterface::ORDER_ASCENDING,
46			];
47			}
48			}
49
50
51			/**
52			* Get the top questions.
53			*
54			* @param int $limit
55			* @param int $topCategoryId
56			* @param array $topQuestions
57			*
58			* @return array\|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
59			*/
60			public function findTop($limit = 5, $topCategoryId = 0, $topQuestions = [])
61			{
62			$questions = $this->getStaticQuestionsAndReduceLimit($topQuestions, $limit);
63			if ($limit > 0) {
64			$query = $this->createQuery();
65			$constraintsOr = [];
66			$constraintsOr[] = $query->contains('categories', $topCategoryId);
67			$constraintsOr[] = $query->equals('categories.parent', $topCategoryId);
68
69			$constraintsAnd = [];
70			$constraintsAnd[] = $query->logicalOr($constraintsOr);
71			if (!empty($topQuestions)) {
72			$constraintsAnd[] = $query->logicalNot($query->in('uid', $topQuestions));
73			}
74
75			$query->matching($query->logicalAnd($constraintsAnd));
76
77			$query->setOrderings(['topCounter' => QueryInterface::ORDER_DESCENDING]);
78			$query->setLimit($limit);
79			$results = $query->execute()
80			->toArray();
81
82			$questions = \array_merge($questions, $results);
83			}
84
85			return $questions;
86			}
87
88			/**
89			* Get the newest questions.
90			*
91			* @param int $limit
92			* @param int $topCategoryId
93			*
94			* @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException
95			*
96			* @return array\|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
97			*/
98			public function findNewest($limit = 5, $topCategoryId = 0)
99			{
100			$query = $this->createQuery();
101
102			$constraintsOr = [];
103			$constraintsOr[] = $query->contains('categories', $topCategoryId);
104			$constraintsOr[] = $query->equals('categories.parent', $topCategoryId);
105
106			$query->matching($query->logicalOr($constraintsOr));
107
108			$query->setOrderings(['crdate' => QueryInterface::ORDER_DESCENDING]);
109			if ($limit) {
110			$query->setLimit($limit);
111			}
112
113			return $query->execute();
114			}
115
116			/**
117			* Returns all objects of this repository.
118			*
119			* @param int $topCategoryId
120			*
121			* @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException
122			*
123			* @return \TYPO3\CMS\Extbase\Persistence\QueryResultInterface\|array
124			*/
125			public function findAll($topCategoryId = 0)
126			{
127			if (!$topCategoryId) {
128			return parent::findAll();
129			}
130			$query = $this->createQuery();
131
132			$constraintsOr = [];
133			$constraintsOr[] = $query->contains('categories', $topCategoryId);
134			$constraintsOr[] = $query->equals('categories.parent', $topCategoryId);
135
136			$query->matching($query->logicalOr($constraintsOr));
137
138			return $query->execute();
139			}
140
141			/**
142			* Find by FAQ model.
143			*
144			* @param int $topCategoryId
145			*
146			* @throws \TYPO3\CMS\Extbase\Persistence\Exception\InvalidQueryException
147			*
148			* @return array\|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
149			*/
150			public function findByFaq(Faq $faq, $topCategoryId = 0)
151			{
152			$query = $this->createQuery();
153
154			$constraintsOr = [];
155			$constraintsOr[] = $query->contains('categories', $topCategoryId);
156			$constraintsOr[] = $query->equals('categories.parent', $topCategoryId);
157
158			$constraints = [];
159			$constraints[] = $query->logicalOr($constraintsOr);
160
161			$categories = GeneralUtility::intExplode(',', \implode(',', $faq->getCategories()), true);
162			if ($faq->getCategory() instanceof Questioncategory) {
163			$categories[] = (int)$faq->getCategory()
164			->getUid();
165			}
166
167			if ($categories) {
			0 ignored issues – show Bug Best Practice introduced 2018-06-13 12:28 UTC by Report Bug Copy Issue Report The expression `$categories` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
168			$catSelection = [];
169			foreach ($categories as $catId) {
170			$catSelection[] = $query->contains('categories', $catId);
171			}
172			$constraints[] = $query->logicalOr($catSelection);
173			}
174
175			if (\mb_strlen($faq->getSearchWord())) {
176			$constraints[] = $query->logicalOr([
177			$query->like('title', '%' . $faq->getSearchWord() . '%'),
178			$query->like('answer', '%' . $faq->getSearchWord() . '%'),
179			]);
180			}
181
182			if (\count($constraints)) {
183			$query->matching($query->logicalAnd($constraints));
184			}
185
186			return $query->execute();
187			}
188
189			/**
190			* Get the teaser questions.
191			*
192			* @param int $limit
193			*
194			* @throws \Exception
195			*
196			* @return array
197			*/
198			public function findByTeaserConfiguration(array $topQuestions, array $categories, $limit)
199			{
200			$questions = $this->getStaticQuestionsAndReduceLimit($topQuestions, $limit);
201			if ($limit > 0) {
202			$t = $this->getTableName();
203
204			$queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)->getQueryBuilderForTable('tx_faq_mm_question_questioncategory');
205			$queryBuilder
206			->getRestrictions()
207			->removeAll();
208
209			$where = [
210			$queryBuilder->expr()->eq($t . '.uid', 'mm.uid_local'),
211			];
212			if (\count($topQuestions)) {
213			$where[] = $queryBuilder->expr()->notIn($t . '.uid', $topQuestions);
214			}
215			if (!empty($categories)) {
216			$where[] = $queryBuilder->expr()->in('mm.uid_foreign', $categories);
217			}
218
219			$rows = $queryBuilder->select($t . '.*')
220			->from($t)
221			->join($t, 'tx_faq_mm_question_questioncategory', 'mm')
222			->where(...$where)
223			->groupBy($t . '.uid')
224			->execute()
225			->fetchAll();
226
227			\shuffle($rows);
228
229			foreach ($rows as $row) {
230			$q = $this->findByUid((int)$row['uid']);
231			if ($q instanceof Question) {
232			$questions[] = $q;
233			}
234			}
235			}
236
237			return $questions;
238			}
239
240			/**
241			* Get the Questsions with the given IDS and reduce the limit.
242			*
243			* @param int $limit
244			*
245			* @return array
246			*/
247			protected function getStaticQuestionsAndReduceLimit(array $ids, &$limit)
248			{
249			$questions = [];
250			foreach ($ids as $id) {
251			$q = $this->findByUid((int)$id);
252			if ($q instanceof Question) {
253			$questions[] = $q;
254			--$limit;
255			}
256			}
257
258			return $questions;
259			}
260			}
261

lochmueller / faq

Push — master ( 5ff62b...faff63 )

QuestionRepository::findByTeaserConfiguration() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like