EventImport::getEvent() - Code Metrics - Inspection of "[BUGFIX] Make DI TYPO3 v9 Compatible" - lochmueller/calendarize - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#278)

by Pascale

created 2018-12-11 15:23 UTC

EventImport::getEvent() A

↳ Parent: EventImport

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

/**
 * Import default events.
 */
declare(strict_types=1);

namespace HDNET\Calendarize\Slots;

use HDNET\Calendarize\Command\ImportCommandController;
use HDNET\Calendarize\Domain\Model\Configuration;
use HDNET\Calendarize\Domain\Model\Event;
use HDNET\Calendarize\Domain\Repository\EventRepository;
use HDNET\Calendarize\Utility\DateTimeUtility;
use HDNET\Calendarize\Utility\HelperUtility;
use TYPO3\CMS\Extbase\Persistence\Generic\PersistenceManager;

/**
 * Import default events.
 */
class EventImport
{
    /**
     * Event repository.
     *
     * @var \HDNET\Calendarize\Domain\Repository\EventRepository
     */
    protected $eventRepository;

    public function injectEventRepository(EventRepository $eventRepository)
    {
        $this->eventRepository = $eventRepository;
    }

    /**
     * Run the import.
     *
     * @param array                   $event
     * @param ImportCommandController $commandController
     * @param int                     $pid
     * @param bool                    $handled
     *
     * @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
     *
     * @return array
     */
    public function importCommand(array $event, $commandController, $pid, $handled)

    {
        $commandController->enqueueMessage('Handle via Default Event Import Slot');

        $eventObject = $this->getEvent($event['uid']);
        $eventObject->setPid($pid);
        $eventObject->setTitle($event['title']);
        $eventObject->setDescription($this->nl2br($event['description']));

        $configuration = $this->getConfiguration($pid, $event['start'], $event['end']);
        $eventObject->addCalendarize($configuration);

        if (null === $eventObject->getUid()) {
            $this->eventRepository->update($eventObject);
            $commandController->enqueueMessage('Update Event Meta data: ' . $eventObject->getTitle(), 'Update');
        } else {
            $this->eventRepository->add($eventObject);
            $commandController->enqueueMessage('Add Event: ' . $eventObject->getTitle(), 'Add');
        }

        $this->persist();
        $handled = true;

        return [
            'event' => $event,
            'commandController' => $commandController,
            'pid' => $pid,
            'handled' => $handled,
        ];
    }

    /**
     * Get the configuration.
     *
     * @param int       $pid
     * @param \DateTime $startDate
     * @param \DateTime $endDate
     *
     * @return Configuration
     */
    protected function getConfiguration($pid, \DateTime $startDate, \DateTime $endDate)
    {
        $configuration = new Configuration();
        $configuration->setPid($pid);
        $configuration->setType(Configuration::TYPE_TIME);
        $configuration->setFrequency(Configuration::FREQUENCY_NONE);
        $configuration->setAllDay(true);

        $startTime = clone $startDate;
        $configuration->setStartDate(DateTimeUtility::resetTime($startDate));
        $endTime = clone $endDate;
        $configuration->setEndDate(DateTimeUtility::resetTime($endDate));

        $startTime = DateTimeUtility::getDaySecondsOfDateTime($startTime);
        if ($startTime > 0) {
            $configuration->setStartTime($startTime);
            $configuration->setEndTime(DateTimeUtility::getDaySecondsOfDateTime($endTime));
            $configuration->setAllDay(false);
        }

        return $configuration;
    }

    /**
     * Get the right event object (or a new one).
     *
     * @param string $importId
     *
     * @return Event
     */
    protected function getEvent($importId)
    {
        $eventObject = $this->eventRepository->findOneByImportId($importId);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if (!($eventObject instanceof Event)) {
            $eventObject = new Event();
        }
        $eventObject->setImportId($importId);

        return $eventObject;
    }

    /**
     * Store to the DB.
     */
    protected function persist()
    {
        $persist = HelperUtility::create(PersistenceManager::class);
        $persist->persistAll();
    }

    /**
     * Replace new lines.
     *
     * @param string $string
     *
     * @return string
     */
    protected function nl2br($string)
    {
        $string = \nl2br((string) $string);

        return \str_replace('\\n', '<br />', $string);
    }
}


1			<?php
2
3			/**
4			* Import default events.
5			*/
6			declare(strict_types=1);
7
8			namespace HDNET\Calendarize\Slots;
9
10			use HDNET\Calendarize\Command\ImportCommandController;
11			use HDNET\Calendarize\Domain\Model\Configuration;
12			use HDNET\Calendarize\Domain\Model\Event;
13			use HDNET\Calendarize\Domain\Repository\EventRepository;
14			use HDNET\Calendarize\Utility\DateTimeUtility;
15			use HDNET\Calendarize\Utility\HelperUtility;
16			use TYPO3\CMS\Extbase\Persistence\Generic\PersistenceManager;
17
18			/**
19			* Import default events.
20			*/
21			class EventImport
22			{
23			/**
24			* Event repository.
25			*
26			* @var \HDNET\Calendarize\Domain\Repository\EventRepository
27			*/
28			protected $eventRepository;
29
30			public function injectEventRepository(EventRepository $eventRepository)
31			{
32			$this->eventRepository = $eventRepository;
33			}
34
35			/**
36			* Run the import.
37			*
38			* @param array $event
39			* @param ImportCommandController $commandController
40			* @param int $pid
41			* @param bool $handled
42			*
43			* @throws \TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException
44			*
45			* @return array
46			*/
47			public function importCommand(array $event, $commandController, $pid, $handled)
			0 ignored issues – show Unused Code introduced 2017-08-15 13:18 UTC by Report Bug Copy Issue Report The parameter `$handled` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
48			{
49			$commandController->enqueueMessage('Handle via Default Event Import Slot');
50
51			$eventObject = $this->getEvent($event['uid']);
52			$eventObject->setPid($pid);
53			$eventObject->setTitle($event['title']);
54			$eventObject->setDescription($this->nl2br($event['description']));
55
56			$configuration = $this->getConfiguration($pid, $event['start'], $event['end']);
57			$eventObject->addCalendarize($configuration);
58
59			if (null === $eventObject->getUid()) {
60			$this->eventRepository->update($eventObject);
61			$commandController->enqueueMessage('Update Event Meta data: ' . $eventObject->getTitle(), 'Update');
62			} else {
63			$this->eventRepository->add($eventObject);
64			$commandController->enqueueMessage('Add Event: ' . $eventObject->getTitle(), 'Add');
65			}
66
67			$this->persist();
68			$handled = true;
69
70			return [
71			'event' => $event,
72			'commandController' => $commandController,
73			'pid' => $pid,
74			'handled' => $handled,
75			];
76			}
77
78			/**
79			* Get the configuration.
80			*
81			* @param int $pid
82			* @param \DateTime $startDate
83			* @param \DateTime $endDate
84			*
85			* @return Configuration
86			*/
87			protected function getConfiguration($pid, \DateTime $startDate, \DateTime $endDate)
88			{
89			$configuration = new Configuration();
90			$configuration->setPid($pid);
91			$configuration->setType(Configuration::TYPE_TIME);
92			$configuration->setFrequency(Configuration::FREQUENCY_NONE);
93			$configuration->setAllDay(true);
94
95			$startTime = clone $startDate;
96			$configuration->setStartDate(DateTimeUtility::resetTime($startDate));
97			$endTime = clone $endDate;
98			$configuration->setEndDate(DateTimeUtility::resetTime($endDate));
99
100			$startTime = DateTimeUtility::getDaySecondsOfDateTime($startTime);
101			if ($startTime > 0) {
102			$configuration->setStartTime($startTime);
103			$configuration->setEndTime(DateTimeUtility::getDaySecondsOfDateTime($endTime));
104			$configuration->setAllDay(false);
105			}
106
107			return $configuration;
108			}
109
110			/**
111			* Get the right event object (or a new one).
112			*
113			* @param string $importId
114			*
115			* @return Event
116			*/
117			protected function getEvent($importId)
118			{
119			$eventObject = $this->eventRepository->findOneByImportId($importId);
			0 ignored issues – show Documentation Bug introduced 2016-06-15 13:24 UTC by Report Bug Copy Issue Report The method `findOneByImportId` does not exist on `object<HDNET\Calendarize...sitory\EventRepository>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
120			if (!($eventObject instanceof Event)) {
121			$eventObject = new Event();
122			}
123			$eventObject->setImportId($importId);
124
125			return $eventObject;
126			}
127
128			/**
129			* Store to the DB.
130			*/
131			protected function persist()
132			{
133			$persist = HelperUtility::create(PersistenceManager::class);
134			$persist->persistAll();
135			}
136
137			/**
138			* Replace new lines.
139			*
140			* @param string $string
141			*
142			* @return string
143			*/
144			protected function nl2br($string)
145			{
146			$string = \nl2br((string) $string);
147
148			return \str_replace('\\n', '<br />', $string);
149			}
150			}
151

lochmueller / calendarize

Pull Request — master (#278)

EventImport::getEvent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like