Complex classes like Configuration often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Configuration, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
18 | class Configuration extends AbstractModel implements ConfigurationInterface |
||
19 | { |
||
20 | /** |
||
21 | * Type. |
||
22 | * |
||
23 | * @var string |
||
24 | * @db |
||
25 | */ |
||
26 | protected $type = self::TYPE_TIME; |
||
27 | |||
28 | /** |
||
29 | * Handling. |
||
30 | * |
||
31 | * @var string |
||
32 | * @db |
||
33 | */ |
||
34 | protected $handling = self::HANDLING_INCLUDE; |
||
35 | |||
36 | /** |
||
37 | * State. |
||
38 | * |
||
39 | * @var string |
||
40 | * @db |
||
41 | */ |
||
42 | protected $state = self::STATE_DEFAULT; |
||
43 | |||
44 | /** |
||
45 | * Start date. |
||
46 | * |
||
47 | * @var \DateTime |
||
48 | * @db |
||
49 | */ |
||
50 | protected $startDate; |
||
51 | |||
52 | /** |
||
53 | * End date. |
||
54 | * |
||
55 | * @var \DateTime |
||
56 | * @db |
||
57 | */ |
||
58 | protected $endDate; |
||
59 | |||
60 | /** |
||
61 | * End date dynamic. |
||
62 | * |
||
63 | * @var string |
||
64 | * @db |
||
65 | */ |
||
66 | protected $endDateDynamic; |
||
67 | |||
68 | /** |
||
69 | * Start time. |
||
70 | * |
||
71 | * @var int |
||
72 | * @db |
||
73 | */ |
||
74 | protected $startTime; |
||
75 | |||
76 | /** |
||
77 | * End time. |
||
78 | * |
||
79 | * @var int |
||
80 | * @db |
||
81 | */ |
||
82 | protected $endTime; |
||
83 | |||
84 | /** |
||
85 | * AllDay. |
||
86 | * |
||
87 | * @var bool |
||
88 | * @db |
||
89 | */ |
||
90 | protected $allDay; |
||
91 | |||
92 | /** |
||
93 | * OpenEndTime. |
||
94 | * |
||
95 | * @var bool |
||
96 | * @db |
||
97 | */ |
||
98 | protected $openEndTime; |
||
99 | |||
100 | /** |
||
101 | * External ICS url. |
||
102 | * |
||
103 | * @var string |
||
104 | * @db |
||
105 | */ |
||
106 | protected $externalIcsUrl; |
||
107 | |||
108 | /** |
||
109 | * Groups. |
||
110 | * |
||
111 | * @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\HDNET\Calendarize\Domain\Model\ConfigurationGroup> |
||
112 | * @db text |
||
113 | * @lazy |
||
114 | * @TYPO3\CMS\Extbase\Annotation\ORM\Lazy |
||
115 | */ |
||
116 | protected $groups; |
||
117 | |||
118 | /** |
||
119 | * Frequency. |
||
120 | * |
||
121 | * @var string |
||
122 | * @db |
||
123 | */ |
||
124 | protected $frequency = self::FREQUENCY_NONE; |
||
125 | |||
126 | /** |
||
127 | * Till date. |
||
128 | * |
||
129 | * @var \DateTime |
||
130 | * @db |
||
131 | */ |
||
132 | protected $tillDate; |
||
133 | |||
134 | /** |
||
135 | * Counter amount. |
||
136 | * |
||
137 | * @var int |
||
138 | * @db |
||
139 | */ |
||
140 | protected $counterAmount; |
||
141 | |||
142 | /** |
||
143 | * Counter interval. |
||
144 | * |
||
145 | * @var int |
||
146 | * @db |
||
147 | */ |
||
148 | protected $counterInterval; |
||
149 | |||
150 | /** |
||
151 | * Recurrence. |
||
152 | * |
||
153 | * @var string |
||
154 | * @db |
||
155 | */ |
||
156 | protected $recurrence = self::RECURRENCE_NONE; |
||
157 | |||
158 | /** |
||
159 | * Day property. |
||
160 | * |
||
161 | * @var string |
||
162 | * @db |
||
163 | */ |
||
164 | protected $day = self::DAY_NONE; |
||
165 | |||
166 | /** |
||
167 | * Import ID if the item is based on an ICS structure. |
||
168 | * |
||
169 | * @var string |
||
170 | * @db |
||
171 | */ |
||
172 | protected $importId; |
||
173 | |||
174 | /** |
||
175 | * Configuration constructor. |
||
176 | */ |
||
177 | public function __construct() |
||
181 | |||
182 | /** |
||
183 | * Get type. |
||
184 | * |
||
185 | * @return string |
||
186 | */ |
||
187 | public function getType() |
||
191 | |||
192 | /** |
||
193 | * Set type. |
||
194 | * |
||
195 | * @param string $type |
||
196 | */ |
||
197 | public function setType($type) |
||
201 | |||
202 | /** |
||
203 | * Is all day. |
||
204 | * |
||
205 | * @return bool |
||
206 | */ |
||
207 | public function isAllDay() |
||
211 | |||
212 | /** |
||
213 | * Set all day. |
||
214 | * |
||
215 | * @param bool $allDay |
||
216 | */ |
||
217 | public function setAllDay($allDay) |
||
221 | |||
222 | /** |
||
223 | * Get end date. |
||
224 | * |
||
225 | * @return \DateTime |
||
226 | */ |
||
227 | public function getEndDate() |
||
235 | |||
236 | /** |
||
237 | * Set end date. |
||
238 | * |
||
239 | * @param \DateTime $endDate |
||
240 | */ |
||
241 | public function setEndDate($endDate) |
||
245 | |||
246 | /** |
||
247 | * Get end date dynamic. |
||
248 | * |
||
249 | * @return string |
||
250 | */ |
||
251 | public function getEndDateDynamic() |
||
255 | |||
256 | /** |
||
257 | * Set end date dynamic. |
||
258 | * |
||
259 | * @param string $endDateDynamic |
||
260 | */ |
||
261 | public function setEndDateDynamic($endDateDynamic) |
||
265 | |||
266 | /** |
||
267 | * Get end time. |
||
268 | * |
||
269 | * @return int |
||
270 | */ |
||
271 | public function getEndTime() |
||
275 | |||
276 | /** |
||
277 | * Set end time. |
||
278 | * |
||
279 | * @param int $endTime |
||
280 | */ |
||
281 | public function setEndTime($endTime) |
||
285 | |||
286 | /** |
||
287 | * Get start date. |
||
288 | * |
||
289 | * @return \DateTime |
||
290 | */ |
||
291 | public function getStartDate() |
||
299 | |||
300 | /** |
||
301 | * Set start date. |
||
302 | * |
||
303 | * @param \DateTime $startDate |
||
304 | */ |
||
305 | public function setStartDate($startDate) |
||
309 | |||
310 | /** |
||
311 | * Get start time. |
||
312 | * |
||
313 | * @return int |
||
314 | */ |
||
315 | public function getStartTime() |
||
319 | |||
320 | /** |
||
321 | * Set start time. |
||
322 | * |
||
323 | * @param int $startTime |
||
324 | */ |
||
325 | public function setStartTime($startTime) |
||
329 | |||
330 | /** |
||
331 | * Get groups. |
||
332 | * |
||
333 | * @return \TYPO3\CMS\Extbase\Persistence\ObjectStorage |
||
334 | */ |
||
335 | public function getGroups() |
||
343 | |||
344 | /** |
||
345 | * Set groups. |
||
346 | * |
||
347 | * @param \TYPO3\CMS\Extbase\Persistence\ObjectStorage $groups |
||
348 | */ |
||
349 | public function setGroups($groups) |
||
353 | |||
354 | /** |
||
355 | * Get frequency. |
||
356 | * |
||
357 | * @return string |
||
358 | */ |
||
359 | public function getFrequency() |
||
363 | |||
364 | /** |
||
365 | * Set frequency. |
||
366 | * |
||
367 | * @param string $frequency |
||
368 | */ |
||
369 | public function setFrequency($frequency) |
||
373 | |||
374 | /** |
||
375 | * Get till date. |
||
376 | * |
||
377 | * @return \DateTime |
||
378 | */ |
||
379 | public function getTillDate() |
||
383 | |||
384 | /** |
||
385 | * Set till date. |
||
386 | * |
||
387 | * @param \DateTime $tillDate |
||
388 | */ |
||
389 | public function setTillDate($tillDate) |
||
393 | |||
394 | /** |
||
395 | * Get counter amount. |
||
396 | * |
||
397 | * @return int |
||
398 | */ |
||
399 | public function getCounterAmount() |
||
403 | |||
404 | /** |
||
405 | * Set counter amount. |
||
406 | * |
||
407 | * @param int $counterAmount |
||
408 | */ |
||
409 | public function setCounterAmount($counterAmount) |
||
413 | |||
414 | /** |
||
415 | * Get counter interval. |
||
416 | * |
||
417 | * @return int |
||
418 | */ |
||
419 | public function getCounterInterval() |
||
423 | |||
424 | /** |
||
425 | * Set counter interval. |
||
426 | * |
||
427 | * @param int $counterInterval |
||
428 | */ |
||
429 | public function setCounterInterval($counterInterval) |
||
433 | |||
434 | /** |
||
435 | * Get external ICS URL. |
||
436 | * |
||
437 | * @return string |
||
438 | */ |
||
439 | public function getExternalIcsUrl() |
||
443 | |||
444 | /** |
||
445 | * Set external ICS URL. |
||
446 | * |
||
447 | * @param string $externalIcsUrl |
||
448 | */ |
||
449 | public function setExternalIcsUrl($externalIcsUrl) |
||
453 | |||
454 | /** |
||
455 | * Get day. |
||
456 | * |
||
457 | * @return string |
||
458 | */ |
||
459 | public function getDay() |
||
463 | |||
464 | /** |
||
465 | * Set day. |
||
466 | * |
||
467 | * @param string $day |
||
468 | */ |
||
469 | public function setDay($day) |
||
473 | |||
474 | /** |
||
475 | * Get recurrence. |
||
476 | * |
||
477 | * @return string |
||
478 | */ |
||
479 | public function getRecurrence() |
||
483 | |||
484 | /** |
||
485 | * Set recurrence. |
||
486 | * |
||
487 | * @param string $recurrence |
||
488 | */ |
||
489 | public function setRecurrence($recurrence) |
||
493 | |||
494 | /** |
||
495 | * Get handling. |
||
496 | * |
||
497 | * @return string |
||
498 | */ |
||
499 | public function getHandling() |
||
503 | |||
504 | /** |
||
505 | * Set handling. |
||
506 | * |
||
507 | * @param string $handling |
||
508 | */ |
||
509 | public function setHandling($handling) |
||
513 | |||
514 | /** |
||
515 | * Get state. |
||
516 | * |
||
517 | * @return string |
||
518 | */ |
||
519 | public function getState() |
||
523 | |||
524 | /** |
||
525 | * Set state. |
||
526 | * |
||
527 | * @param string $state |
||
528 | */ |
||
529 | public function setState($state) |
||
533 | |||
534 | /** |
||
535 | * @return bool |
||
536 | */ |
||
537 | public function isOpenEndTime() |
||
541 | |||
542 | /** |
||
543 | * @param bool $openEndTime |
||
544 | */ |
||
545 | public function setOpenEndTime(bool $openEndTime) |
||
549 | |||
550 | } |
||
551 |