ImportCommandController::execute() - Code Metrics - Inspection of "[Draft] New ical reader" - lochmueller/calendarize - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#443)

unknown

created 2020-10-13 07:15 UTC

ImportCommandController::execute() A

↳ Parent: ImportCommandController

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	52
rs	9.0472
c	0
b	0
f	0
cc	4
nc	4
nop	2

How to fix Long Method

<?php

/**
 * Import.
 */
declare(strict_types=1);

namespace HDNET\Calendarize\Command;

use HDNET\Calendarize\Service\ICalServiceInterface;
use HDNET\Calendarize\Service\IndexerService;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\MathUtility;
use TYPO3\CMS\Extbase\SignalSlot\Dispatcher;

/**
 * Import.
 */
class ImportCommandController extends Command
{

    /**
     * @var ICalServiceInterface $iCalService
     */
    private $iCalService;

    /**
     * ImportCommandController constructor.
     * @param ICalServiceInterface $iCalService
     */
    public function __construct(string $name = null, ICalServiceInterface $iCalService)
    {
        $this->iCalService = $iCalService;
        parent::__construct($name);
    }

    protected function configure()
    {
        $this->setDescription('Imports a iCalendar ICS into a page ID')
            ->addArgument('icsCalendarUri', InputArgument::REQUIRED, 'The URI of the iCalendar ICS')
            ->addArgument('pid', InputArgument::REQUIRED, 'The page ID to create new elements');
    }

    /**
     * Executes the command for importing a iCalendar ICS into a page ID.
     *
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int 0 if everything went fine, or an exit code
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $io = new SymfonyStyle($input, $output);

        $icsCalendarUri = $input->getArgument('icsCalendarUri');
        $pid = $input->getArgument('pid');

        if (!\filter_var($icsCalendarUri, FILTER_VALIDATE_URL)) {
            $io->error('You have to enter a valid URL to the iCalendar ICS');

            return 1;
        }
        if (!MathUtility::canBeInterpretedAsInteger($pid)) {
            $io->error('You have to enter a valid PID for the new created elements');

            return 2;
        }
        $pid = (int)$pid;

        // fetch external URI and write to file
        $io->section('Start to checkout the calendar: ' . $icsCalendarUri);
        $relativeIcalFile = 'typo3temp/ical.' . GeneralUtility::shortMD5($icsCalendarUri) . '.ical';
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $absoluteIcalFile = GeneralUtility::getFileAbsFileName($relativeIcalFile);
        $content = GeneralUtility::getUrl($icsCalendarUri);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        GeneralUtility::writeFile($absoluteIcalFile, $content);

        $events = $this->iCalService->getEvents($absoluteIcalFile);

        $io->text('Found ' . \count($events) . ' events in ' . $icsCalendarUri);

        $signalSlotDispatcher = GeneralUtility::makeInstance(Dispatcher::class);

        $io->section('Send the ' . __CLASS__ . '::importCommand signal for each event.');
        $io->progressStart(\count($events));
        foreach ($events as $event) {
            $arguments = [
                'event' => $event,
                'io' => $io,
                'pid' => $pid,
                'handled' => false,
            ];
            $signalSlotDispatcher->dispatch(__CLASS__, 'importCommand', $arguments);
            $io->progressAdvance();
        }
        $io->progressFinish();

        $io->section('Run Reindex proces after import');
        $indexer = GeneralUtility::makeInstance(IndexerService::class);
        $indexer->reindexAll();

        return 0;
    }

}


1			<?php
2
3			/**
4			* Import.
5			*/
6			declare(strict_types=1);
7
8			namespace HDNET\Calendarize\Command;
9
10			use HDNET\Calendarize\Service\ICalServiceInterface;
11			use HDNET\Calendarize\Service\IndexerService;
12			use Symfony\Component\Console\Command\Command;
13			use Symfony\Component\Console\Input\InputArgument;
14			use Symfony\Component\Console\Input\InputInterface;
15			use Symfony\Component\Console\Output\OutputInterface;
16			use Symfony\Component\Console\Style\SymfonyStyle;
17			use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
18			use TYPO3\CMS\Core\Utility\GeneralUtility;
19			use TYPO3\CMS\Core\Utility\MathUtility;
20			use TYPO3\CMS\Extbase\SignalSlot\Dispatcher;
21
22			/**
23			* Import.
24			*/
25			class ImportCommandController extends Command
26			{
27
28			/**
29			* @var ICalServiceInterface $iCalService
30			*/
31			private $iCalService;
32
33			/**
34			* ImportCommandController constructor.
35			* @param ICalServiceInterface $iCalService
36			*/
37			public function __construct(string $name = null, ICalServiceInterface $iCalService)
38			{
39			$this->iCalService = $iCalService;
40			parent::__construct($name);
41			}
42
43			protected function configure()
44			{
45			$this->setDescription('Imports a iCalendar ICS into a page ID')
46			->addArgument('icsCalendarUri', InputArgument::REQUIRED, 'The URI of the iCalendar ICS')
47			->addArgument('pid', InputArgument::REQUIRED, 'The page ID to create new elements');
48			}
49
50			/**
51			* Executes the command for importing a iCalendar ICS into a page ID.
52			*
53			* @param InputInterface $input
54			* @param OutputInterface $output
55			* @return int 0 if everything went fine, or an exit code
56			*/
57			protected function execute(InputInterface $input, OutputInterface $output)
58			{
59			$io = new SymfonyStyle($input, $output);
60
61			$icsCalendarUri = $input->getArgument('icsCalendarUri');
62			$pid = $input->getArgument('pid');
63
64			if (!\filter_var($icsCalendarUri, FILTER_VALIDATE_URL)) {
65			$io->error('You have to enter a valid URL to the iCalendar ICS');
66
67			return 1;
68			}
69			if (!MathUtility::canBeInterpretedAsInteger($pid)) {
70			$io->error('You have to enter a valid PID for the new created elements');
71
72			return 2;
73			}
74			$pid = (int)$pid;
75
76			// fetch external URI and write to file
77			$io->section('Start to checkout the calendar: ' . $icsCalendarUri);
78			$relativeIcalFile = 'typo3temp/ical.' . GeneralUtility::shortMD5($icsCalendarUri) . '.ical';
			0 ignored issues – show Bug introduced 2020-10-08 21:07 UTC by Report Bug Copy Issue Report It seems like `$icsCalendarUri` defined by `$input->getArgument('icsCalendarUri')` on line `61` can also be of type `array<integer,string>` or `null`; however, `TYPO3\CMS\Core\Utility\GeneralUtility::shortMD5()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
79			$absoluteIcalFile = GeneralUtility::getFileAbsFileName($relativeIcalFile);
80			$content = GeneralUtility::getUrl($icsCalendarUri);
			0 ignored issues – show Bug introduced 2020-10-08 21:07 UTC by Report Bug Copy Issue Report It seems like `$icsCalendarUri` defined by `$input->getArgument('icsCalendarUri')` on line `61` can also be of type `array<integer,string>` or `null`; however, `TYPO3\CMS\Core\Utility\GeneralUtility::getUrl()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
81			GeneralUtility::writeFile($absoluteIcalFile, $content);
82
83			$events = $this->iCalService->getEvents($absoluteIcalFile);
84
85			$io->text('Found ' . \count($events) . ' events in ' . $icsCalendarUri);
86
87			$signalSlotDispatcher = GeneralUtility::makeInstance(Dispatcher::class);
88
89			$io->section('Send the ' . __CLASS__ . '::importCommand signal for each event.');
90			$io->progressStart(\count($events));
91			foreach ($events as $event) {
92			$arguments = [
93			'event' => $event,
94			'io' => $io,
95			'pid' => $pid,
96			'handled' => false,
97			];
98			$signalSlotDispatcher->dispatch(__CLASS__, 'importCommand', $arguments);
99			$io->progressAdvance();
100			}
101			$io->progressFinish();
102
103			$io->section('Run Reindex proces after import');
104			$indexer = GeneralUtility::makeInstance(IndexerService::class);
105			$indexer->reindexAll();
106
107			return 0;
108			}
109
110			}
111

lochmueller / calendarize

Pull Request — master (#443)

ImportCommandController::execute() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like