RealUrl::isOldRealUrlVersion() - Code Metrics - Inspection of "Remove old realurl configuration" - lochmueller/calendarize - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b0495b...75f129 )

by Tim

created 2020-08-28 09:46 UTC

RealUrl::isOldRealUrlVersion() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

/**
 * RealUrl.
 */
declare(strict_types=1);

namespace HDNET\Calendarize\Service\Url;

use DmitryDulepov\Realurl\Configuration\ConfigurationReader;
use DmitryDulepov\Realurl\Utility;
use HDNET\Calendarize\Domain\Model\Index;
use HDNET\Calendarize\Service\IndexerService;
use HDNET\Calendarize\Utility\HelperUtility;
use TYPO3\CMS\Core\Database\ConnectionPool;
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\VersionNumberUtility;
use TYPO3\CMS\Extbase\Reflection\ObjectAccess;

/**
 * RealUrl.
 */
class RealUrl extends AbstractUrl
{
    /**
     * Convert the given information.
     *
     * @param $param1
     * @param $param2
     *
     * @return string
     */
    public function convert($param1, $param2)
    {
        return $this->main($param1, $param2);
    }

    /**
     * Build the realurl alias.
     *
     * @param $params
     * @param $ref
     *
     * @return string
     */
    public function main($params, $ref)

    {
        if ($params['decodeAlias']) {
            return $this->alias2id($params['value']);
        }
        $this->cleanupOldLinks();

        return $this->id2alias($params['value']);
    }

    /**
     * Cleanup old URL segments.
     */
    protected function cleanupOldLinks()
    {
        $removeIds = [];
        $q = HelperUtility::getDatabaseConnection(IndexerService::TABLE_NAME)->createQueryBuilder();

        $q->select('u.uid')
            ->from('tx_realurl_uniqalias', 'u')
            ->leftJoin('u', IndexerService::TABLE_NAME, 'i', 'u.value_id = i.uid')
            ->where(
                $q->expr()->andX(
                    $q->expr()->isNull('i.uid'),
                    $q->expr()->eq('u.tablename', $q->expr()->literal(IndexerService::TABLE_NAME))
                )
            );

        foreach ($q->execute()->fetchAll() as $row) {
            $removeIds[] = (int)$row['uid'];
        }

        if (empty($removeIds)) {
            return;
        }

        $q->resetQueryParts();

        $q->delete('tx_realurl_uniqalias')
            ->where(
                $q->expr()->in('uid', $removeIds)
            )
            ->execute();
    }

    /**
     * Handle the alias to index ID convert.
     *
     * @param $value
     *
     * @return int
     */
    protected function alias2id($value): int
    {
        $q = HelperUtility::getDatabaseConnection(IndexerService::TABLE_NAME)->createQueryBuilder();

        $row = $q->select('value_id')
            ->from('tx_realurl_uniqalias')
            ->where(
                $q->expr()->andX(
                    $q->expr()->eq('tablename', $q->expr()->literal(IndexerService::TABLE_NAME)),
                    $q->expr()->eq('value_alias', $q->createNamedParameter($value))
                )
            )
            ->execute()
            ->fetch();

        if (isset($row['value_id'])) {
            return (int)$row['value_id'];
        }

        $matches = [];
        if (\preg_match('/^idx-([0-9]+)$/', $value, $matches)) {
            return (int)$matches[1];
        }

        return 0;
    }

    /**
     * Handle the index ID to alias convert.
     *
     * @param $value
     *
     * @return string
     */
    protected function id2alias($value): string
    {
        $q = HelperUtility::getDatabaseConnection('tx_realurl_uniqalias')->createQueryBuilder();

        $row = $q->select('value_id')
            ->from('tx_realurl_uniqalias')
            ->where(
                $q->expr()->andX(
                    $q->expr()->eq('tablename', $q->expr()->literal(IndexerService::TABLE_NAME)),
                    $q->expr()->eq('value_id', $q->createNamedParameter((int)$value, \PDO::PARAM_INT))
                )
            )
            ->execute()
            ->fetch();

        if (isset($row['value_alias'])) {
            return (string)$row['value_alias'];
        }

        $alias = $this->getIndexBase((int)$value);
        $alias = $this->prepareBase($alias);
        $alias = $this->cleanUrl($alias);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $entry = [
            'tablename' => IndexerService::TABLE_NAME,
            'field_alias' => 'title',
            'field_id' => 'uid',
            'value_alias' => $alias,
            'value_id' => $value,
        ];
        if ($this->isOldRealUrlVersion()) {

            $entry['tstamp'] = (new \DateTime())->getTimestamp();
        }

        $aliasBase = $alias;
        for ($i = 0;; ++$i) {
            $alias = $i > 0 ? $aliasBase . '-' . $i : $aliasBase;
            if (!$this->aliasAlreadyExists($alias)) {
                $entry['value_alias'] = $alias;
                break;
            }
        }

        $q->resetQueryParts();
        $q->insert('tx_realurl_uniqalias')->values($entry)->execute();

        return (string)$alias;
    }

    /**
     * Check if alias already exists.
     *
     * @param string $alias
     *
     * @return bool
     */
    protected function aliasAlreadyExists($alias)
    {
        $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)->getQueryBuilderForTable('tx_realurl_uniqalias');

        $count = $queryBuilder
        ->count('uid')
        ->from('tx_realurl_uniqalias')
        ->where($queryBuilder->expr()->eq('value_alias', $queryBuilder->createNamedParameter($alias)))
        ->execute()
        ->fetchColumn(0);

        return (bool)$count;
    }

    /**
     * Generate the realurl part.
     *
     * @param string $alias
     *
     * @return string
     */
    protected function cleanUrl(string $alias): string
    {
        $configuration = GeneralUtility::makeInstance(ConfigurationReader::class, ConfigurationReader::MODE_ENCODE);
        // Init the internal utility by ObjectAccess because the property is
        // set by a protected method only. :( Perhaps this could be part of the construct (in realurl)
        $utility = GeneralUtility::makeInstance(Utility::class, $configuration);
        return (string)$utility->convertToSafeString($alias);
    }
}


1			<?php
2
3			/**
4			* RealUrl.
5			*/
6			declare(strict_types=1);
7
8			namespace HDNET\Calendarize\Service\Url;
9
10			use DmitryDulepov\Realurl\Configuration\ConfigurationReader;
11			use DmitryDulepov\Realurl\Utility;
12			use HDNET\Calendarize\Domain\Model\Index;
13			use HDNET\Calendarize\Service\IndexerService;
14			use HDNET\Calendarize\Utility\HelperUtility;
15			use TYPO3\CMS\Core\Database\ConnectionPool;
16			use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
17			use TYPO3\CMS\Core\Utility\GeneralUtility;
18			use TYPO3\CMS\Core\Utility\VersionNumberUtility;
19			use TYPO3\CMS\Extbase\Reflection\ObjectAccess;
20
21			/**
22			* RealUrl.
23			*/
24			class RealUrl extends AbstractUrl
25			{
26			/**
27			* Convert the given information.
28			*
29			* @param $param1
30			* @param $param2
31			*
32			* @return string
33			*/
34			public function convert($param1, $param2)
35			{
36			return $this->main($param1, $param2);
37			}
38
39			/**
40			* Build the realurl alias.
41			*
42			* @param $params
43			* @param $ref
44			*
45			* @return string
46			*/
47			public function main($params, $ref)
			0 ignored issues – show Unused Code introduced 2017-08-15 13:18 UTC by Report Bug Copy Issue Report The parameter `$ref` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
48			{
49			if ($params['decodeAlias']) {
50			return $this->alias2id($params['value']);
51			}
52			$this->cleanupOldLinks();
53
54			return $this->id2alias($params['value']);
55			}
56
57			/**
58			* Cleanup old URL segments.
59			*/
60			protected function cleanupOldLinks()
61			{
62			$removeIds = [];
63			$q = HelperUtility::getDatabaseConnection(IndexerService::TABLE_NAME)->createQueryBuilder();
64
65			$q->select('u.uid')
66			->from('tx_realurl_uniqalias', 'u')
67			->leftJoin('u', IndexerService::TABLE_NAME, 'i', 'u.value_id = i.uid')
68			->where(
69			$q->expr()->andX(
70			$q->expr()->isNull('i.uid'),
71			$q->expr()->eq('u.tablename', $q->expr()->literal(IndexerService::TABLE_NAME))
72			)
73			);
74
75			foreach ($q->execute()->fetchAll() as $row) {
76			$removeIds[] = (int)$row['uid'];
77			}
78
79			if (empty($removeIds)) {
80			return;
81			}
82
83			$q->resetQueryParts();
84
85			$q->delete('tx_realurl_uniqalias')
86			->where(
87			$q->expr()->in('uid', $removeIds)
88			)
89			->execute();
90			}
91
92			/**
93			* Handle the alias to index ID convert.
94			*
95			* @param $value
96			*
97			* @return int
98			*/
99			protected function alias2id($value): int
100			{
101			$q = HelperUtility::getDatabaseConnection(IndexerService::TABLE_NAME)->createQueryBuilder();
102
103			$row = $q->select('value_id')
104			->from('tx_realurl_uniqalias')
105			->where(
106			$q->expr()->andX(
107			$q->expr()->eq('tablename', $q->expr()->literal(IndexerService::TABLE_NAME)),
108			$q->expr()->eq('value_alias', $q->createNamedParameter($value))
109			)
110			)
111			->execute()
112			->fetch();
113
114			if (isset($row['value_id'])) {
115			return (int)$row['value_id'];
116			}
117
118			$matches = [];
119			if (\preg_match('/^idx-([0-9]+)$/', $value, $matches)) {
120			return (int)$matches[1];
121			}
122
123			return 0;
124			}
125
126			/**
127			* Handle the index ID to alias convert.
128			*
129			* @param $value
130			*
131			* @return string
132			*/
133			protected function id2alias($value): string
134			{
135			$q = HelperUtility::getDatabaseConnection('tx_realurl_uniqalias')->createQueryBuilder();
136
137			$row = $q->select('value_id')
138			->from('tx_realurl_uniqalias')
139			->where(
140			$q->expr()->andX(
141			$q->expr()->eq('tablename', $q->expr()->literal(IndexerService::TABLE_NAME)),
142			$q->expr()->eq('value_id', $q->createNamedParameter((int)$value, \PDO::PARAM_INT))
143			)
144			)
145			->execute()
146			->fetch();
147
148			if (isset($row['value_alias'])) {
149			return (string)$row['value_alias'];
150			}
151
152			$alias = $this->getIndexBase((int)$value);
153			$alias = $this->prepareBase($alias);
154			$alias = $this->cleanUrl($alias);
			0 ignored issues – show Bug introduced 2020-02-13 19:41 UTC by Report Bug Copy Issue Report It seems like `$alias` can also be of type `array<integer,string>` or `null`; however, `HDNET\Calendarize\Service\Url\RealUrl::cleanUrl()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
155			$entry = [
156			'tablename' => IndexerService::TABLE_NAME,
157			'field_alias' => 'title',
158			'field_id' => 'uid',
159			'value_alias' => $alias,
160			'value_id' => $value,
161			];
162			if ($this->isOldRealUrlVersion()) {
			0 ignored issues – show Bug introduced 2020-08-28 09:50 UTC by Report Bug Copy Issue Report The method `isOldRealUrlVersion()` does not seem to exist on `object<HDNET\Calendarize\Service\Url\RealUrl>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
163			$entry['tstamp'] = (new \DateTime())->getTimestamp();
164			}
165
166			$aliasBase = $alias;
167			for ($i = 0;; ++$i) {
168			$alias = $i > 0 ? $aliasBase . '-' . $i : $aliasBase;
169			if (!$this->aliasAlreadyExists($alias)) {
170			$entry['value_alias'] = $alias;
171			break;
172			}
173			}
174
175			$q->resetQueryParts();
176			$q->insert('tx_realurl_uniqalias')->values($entry)->execute();
177
178			return (string)$alias;
179			}
180
181			/**
182			* Check if alias already exists.
183			*
184			* @param string $alias
185			*
186			* @return bool
187			*/
188			protected function aliasAlreadyExists($alias)
189			{
190			$queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)->getQueryBuilderForTable('tx_realurl_uniqalias');
191
192			$count = $queryBuilder
193			->count('uid')
194			->from('tx_realurl_uniqalias')
195			->where($queryBuilder->expr()->eq('value_alias', $queryBuilder->createNamedParameter($alias)))
196			->execute()
197			->fetchColumn(0);
198
199			return (bool)$count;
200			}
201
202			/**
203			* Generate the realurl part.
204			*
205			* @param string $alias
206			*
207			* @return string
208			*/
209			protected function cleanUrl(string $alias): string
210			{
211			$configuration = GeneralUtility::makeInstance(ConfigurationReader::class, ConfigurationReader::MODE_ENCODE);
212			// Init the internal utility by ObjectAccess because the property is
213			// set by a protected method only. :( Perhaps this could be part of the construct (in realurl)
214			$utility = GeneralUtility::makeInstance(Utility::class, $configuration);
215			return (string)$utility->convertToSafeString($alias);
216			}
217			}
218

lochmueller / calendarize

Push — master ( b0495b...75f129 )

RealUrl::isOldRealUrlVersion() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like