ContentImporterTest::make_instance() - Code Metrics - Inspection of "Move old tests to legacy tests" - lloc/Multisite-Language-Switcher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6c0735...dd8543 )

by Dennis

created 2019-06-12 15:49 UTC

ContentImporterTest::make_instance() A

↳ Parent: ContentImporterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	7
rs	10
c	0
b	0
f	0

<?php

namespace lloc\Msls\ContentImport;

use lloc\Msls\ContentImport\Importers\Importer;
use lloc\Msls\MslsMain;
use lloc\Msls\MslsOptions;
use Prophecy\Argument;

class ContentImporterTest extends \Msls_UnitTestCase {

	/**
	 * @var \lloc\Msls\MslsMain
	 */
	protected $main;

	/**
	 * @var \lloc\Msls\ContentImport\ImportLogger
	 */
	protected $logger;

	/**
	 * @var \lloc\Msls\ContentImport\Relations
	 */
	protected $relations;

	/**
	 * @test
	 * it should be instantiatable
	 */
	public function it_should_be_instantiatable() {
		$sut = $this->make_instance();

		$this->assertInstanceOf( ContentImporter::class, $sut );
	}

	/**
	 * @return ContentImporter
	 */
	private function make_instance() {
		$instance = new ContentImporter( $this->main->reveal() );

		$instance->set_logger( $this->logger->reveal() );

		$instance->set_relations( $this->relations->reveal() );


		return $instance;
	}

	public function filter_empty_inputs() {
		return [
			// $input, $nonce_verified, $POST_vars, $expected
			[ 'foo', false, [ 'msls_import' => 'some-value' ], 'foo' ],
			[ 'foo', true, [], 'foo' ],
			[ 'foo', true, [ 'msls_import' => 'some-value' ], false ],
		];
	}

	/**
	 * @dataProvider filter_empty_inputs
	 */
	public function test_filter_empty( $input, $nonce_verified, $POST_vars, $expected ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		$this->main->verify_nonce()->willReturn( $nonce_verified );

		unset( $_POST['msls_import'] );

		$_POST = array_merge( $_POST, $POST_vars );


		$obj = $this->make_instance();

		$this->assertEquals( $expected, $obj->filter_empty( $input ) );
	}

	public function import_content_inputs() {
		return [
			[ 'en_US', 'de_DE' ],
			[ 'de_DE', 'en_US' ],
		];
	}

	/**
	 * @dataProvider import_content_inputs
	 */
	public function test_import_content( $source_lang, $dest_lang ) {
		$source_blog_id = $this->factory->blog->create();
		$dest_blog_id   = $this->factory->blog->create();

		switch_to_blog( $source_blog_id );

		$source_post    = $this->factory->post->create_and_get();
		$source_post_id = $source_post->ID;
		update_option( 'WPLANG', $source_lang );

		switch_to_blog( $dest_blog_id );

		$dest_post_id = $this->factory->post->create();
		update_option( 'WPLANG', $dest_lang );

		$import_coordinates                 = new ImportCoordinates();
		$import_coordinates->source_blog_id = $source_blog_id;
		$import_coordinates->source_post_id = $source_post_id;
		$import_coordinates->dest_blog_id   = $dest_blog_id;
		$import_coordinates->dest_post_id   = $dest_post_id;
		$import_coordinates->source_post    = $source_post;
		$import_coordinates->source_lang    = $source_lang;
		$import_coordinates->dest_lang      = $dest_lang;
		$data                               = [ 'foo' => 'bar' ];
		$importer                           = $this->prophesize( Importer::class );
		$importer->import( $data )
		         ->willReturn( $data );
		$importer->get_logger()->willReturn( null );
		$importer->get_relations()->willReturn( null );

		$this->relations->should_create( Argument::type( MslsOptions::class ), $dest_lang, $dest_post_id )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		                ->shouldBeCalled();
		$this->logger->merge( null )->shouldBeCalled();

		$this->logger->save()->shouldBeCalled();

		$this->relations->merge( null )->shouldBeCalled();

		$this->relations->create()->shouldBeCalled();


		add_filter( 'msls_content_import_importers', function () use ( $importer ) {
			return [
				'test-importer' => $importer->reveal(),
			];
		} );

		$obj          = $this->make_instance();
		$updated_data = $obj->import_content( $import_coordinates, $data );

		$this->assertEquals( $data, $updated_data );
	}

	public function test_import_content_with_wrong_coordinates() {
		$data               = [ 'foo' => 'bar' ];
		$obj                = $this->make_instance();
		$import_coordinates = $this->prophesize( ImportCoordinates::class );
		$import_coordinates->validate()->willReturn( false );

		$updated_data = $obj->import_content( $import_coordinates->reveal(), $data );

		$this->assertEquals( $data, $updated_data );
	}

	public function test_content_import_without_importers() {
		$source_lang = 'de_DE';
		$dest_lang   = 'en_US';

		$source_blog_id = $this->factory->blog->create();
		$dest_blog_id   = $this->factory->blog->create();

		switch_to_blog( $source_blog_id );

		$source_post    = $this->factory->post->create_and_get();
		$source_post_id = $source_post->ID;
		update_option( 'WPLANG', $source_lang );

		switch_to_blog( $dest_blog_id );

		$dest_post_id = $this->factory->post->create();
		update_option( 'WPLANG', $dest_lang );

		$import_coordinates                 = new ImportCoordinates();
		$import_coordinates->source_blog_id = $source_blog_id;
		$import_coordinates->source_post_id = $source_post_id;
		$import_coordinates->dest_blog_id   = $dest_blog_id;
		$import_coordinates->dest_post_id   = $dest_post_id;
		$import_coordinates->source_post    = $source_post;
		$import_coordinates->source_lang    = $source_lang;
		$import_coordinates->dest_lang      = $dest_lang;
		$data                               = [ 'foo' => 'bar' ];
		$importer                           = $this->prophesize( Importer::class );
		$this->relations->should_create( Argument::type( MslsOptions::class ), $dest_lang, $dest_post_id )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		                ->shouldNotBeCalled();
		$this->logger->merge( null )->shouldNotBeCalled();

		$this->logger->save()->shouldNotBeCalled();

		$this->relations->merge( null )->shouldNotBeCalled();

		$this->relations->create()->shouldNotBeCalled();


		add_filter( 'msls_content_import_importers', function () use ( $importer ) {
			return [];
		} );

		$obj          = $this->make_instance();
		$updated_data = $obj->import_content( $import_coordinates, $data );

		$this->assertEquals( $data, $updated_data );
	}

	public function parse_sources_inputs() {
		return [
			[ null, false ],
			[ 'foo', false ],
			[ 'foo|bar', false ],
			[ '23|bar', false ],
			[ 'foo|89', false ],
			[ '23|89', [ 23, 89 ] ],
		];
	}

	/**
	 * @dataProvider parse_sources_inputs
	 */
	public function test_parse_sources( $sources, $expected ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		$obj = $this->make_instance();

		unset( $_POST['msls_import'] );

		if ( null !== $sources ) {
			$_POST['msls_import'] = $sources;
		}

		$this->assertEquals( $expected, $obj->parse_sources() );
	}

	public function test_on_wp_insert_post_with_source_and_current_same() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		$source_lang = 'de_DE';
		$dest_lang   = 'en_US';

		$source_blog_id = $this->factory->blog->create();
		$dest_blog_id   = $this->factory->blog->create();

		switch_to_blog( $source_blog_id );

		$source_post    = $this->factory->post->create_and_get();
		$source_post_id = $source_post->ID;
		update_option( 'WPLANG', $source_lang );

		switch_to_blog( $dest_blog_id );

		$dest_post_id = $this->factory->post->create();
		update_option( 'WPLANG', $dest_lang );

		$data     = [ 'foo' => 'bar' ];
		$importer = $this->prophesize( Importer::class );

		$_POST['msls_import'] = "{$source_blog_id}|{$source_post_id}";

		$this->relations->should_create( Argument::type( MslsOptions::class ), $dest_lang, $dest_post_id )
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		                ->shouldNotBeCalled();
		$this->logger->merge( null )->shouldNotBeCalled();

		$this->logger->save()->shouldNotBeCalled();

		$this->relations->merge( null )->shouldNotBeCalled();

		$this->relations->create()->shouldNotBeCalled();


		add_filter( 'msls_content_import_importers', function () use ( $importer ) {
			return [
				'test-importer' => $importer->reveal(),
			];
		} );

		$obj = $this->make_instance();

		switch_to_blog( $source_blog_id );

		$updated_data = $obj->handle_import( $data );

		$this->assertEquals( $data, $updated_data );
	}

	function setUp() {

		parent::setUp();
		$this->main      = $this->prophesize( MslsMain::class );
		$this->logger    = $this->prophesize( ImportLogger::class );
		$this->relations = $this->prophesize( Relations::class );
	}
}


1			<?php
2
3			namespace lloc\Msls\ContentImport;
4
5			use lloc\Msls\ContentImport\Importers\Importer;
6			use lloc\Msls\MslsMain;
7			use lloc\Msls\MslsOptions;
8			use Prophecy\Argument;
9
10			class ContentImporterTest extends \Msls_UnitTestCase {
11
12			/**
13			* @var \lloc\Msls\MslsMain
14			*/
15			protected $main;
16
17			/**
18			* @var \lloc\Msls\ContentImport\ImportLogger
19			*/
20			protected $logger;
21
22			/**
23			* @var \lloc\Msls\ContentImport\Relations
24			*/
25			protected $relations;
26
27			/**
28			* @test
29			* it should be instantiatable
30			*/
31			public function it_should_be_instantiatable() {
32			$sut = $this->make_instance();
33
34			$this->assertInstanceOf( ContentImporter::class, $sut );
35			}
36
37			/**
38			* @return ContentImporter
39			*/
40			private function make_instance() {

lloc / Multisite-Language-Switcher

Push — master ( 6c0735...dd8543 )

ContentImporterTest::make_instance() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like