WP_Test_MslsGetSet - Code Metrics - Inspection of "Move old tests to legacy tests" - lloc/Multisite-Language-Switcher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6c0735...dd8543 )

by Dennis

created 2019-06-12 15:49 UTC

WP_Test_MslsGetSet A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	29
rs	10
c	0
b	0
f	0
wmc	1
lcom	0
cbo	2

1 Method

Rating	Name	Duplication	Size	Complexity
A	test_is_empty_method()	0	22	1

<?php
/**
 * Tests for MslsGetSet
 *
 * @author Dennis Ploetner <[email protected]>
 * @package Msls
 */

use lloc\Msls\MslsGetSet;

/**
 * WP_Test_MslsGetSet
 */
class WP_Test_MslsGetSet extends Msls_UnitTestCase {

	/**
	 * Verify the is_empty-method
	 */
	function test_is_empty_method() {

		$obj = new MslsGetSet();

		$this->assertTrue( $obj->is_empty() );
		$obj->abc = 'test';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

		$this->assertEquals( 'test' , $obj->abc );
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->assertTrue( isset( $obj->abc ) );
		$this->assertFalse( $obj->is_empty() );

		unset( $obj->abc );
		$this->assertTrue( $obj->is_empty() );

		$obj->temp = 'test';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

		$this->assertTrue( $obj->has_value( 'temp' ) );

		$this->assertEquals( array( 'temp' => 'test' ), $obj->get_arr() );

		$obj->reset();
		$this->assertEquals( array(), $obj->get_arr() );
	}

}


1			<?php
2			/**
3			* Tests for MslsGetSet
4			*
5			* @author Dennis Ploetner <[email protected]>
6			* @package Msls
7			*/
8
9			use lloc\Msls\MslsGetSet;
10
11			/**
12			* WP_Test_MslsGetSet
13			*/
14			class WP_Test_MslsGetSet extends Msls_UnitTestCase {
15
16			/**
17			* Verify the is_empty-method
18			*/
19			function test_is_empty_method() {
			0 ignored issues – show Best Practice introduced 2019-06-12 15:55 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
20			$obj = new MslsGetSet();
21
22			$this->assertTrue( $obj->is_empty() );
23			$obj->abc = 'test';
			0 ignored issues – show Documentation introduced 2019-06-12 15:55 UTC by Report Bug Copy Issue Report The property `abc` does not exist on `object<lloc\Msls\MslsGetSet>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
24
25			$this->assertEquals( 'test' , $obj->abc );
			0 ignored issues – show Documentation introduced 2019-06-12 15:55 UTC by Report Bug Copy Issue Report The property `abc` does not exist on `object<lloc\Msls\MslsGetSet>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
26			$this->assertTrue( isset( $obj->abc ) );
27			$this->assertFalse( $obj->is_empty() );
28
29			unset( $obj->abc );
30			$this->assertTrue( $obj->is_empty() );
31
32			$obj->temp = 'test';
			0 ignored issues – show Documentation introduced 2019-06-12 15:55 UTC by Report Bug Copy Issue Report The property `temp` does not exist on `object<lloc\Msls\MslsGetSet>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
33
34			$this->assertTrue( $obj->has_value( 'temp' ) );
35
36			$this->assertEquals( array( 'temp' => 'test' ), $obj->get_arr() );
37
38			$obj->reset();
39			$this->assertEquals( array(), $obj->get_arr() );
40			}
41
42			}
43

lloc / Multisite-Language-Switcher

Push — master ( 6c0735...dd8543 )

WP_Test_MslsGetSet A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like