Issues in MultisiteLanguageSwitcher.php - All Issues - Inspection of "Hotfix" - lloc/Multisite-Language-Switcher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a934dc...d6329c )

by Dennis

created 2020-04-10 15:00 UTC

MultisiteLanguageSwitcher.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
Plugin Name: Multisite Language Switcher
Plugin URI: http://msls.co/
Description: A simple but powerful plugin that will help you to manage the relations of your contents in a multilingual multisite-installation.
Version: 2.4.4
Author: Dennis Ploetner
Author URI: http://lloc.de/
Text Domain: multisite-language-switcher
*/

/*
Copyright 2013  Dennis Ploetner  (email : [email protected])

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License, version 2, as
published by the Free Software Foundation.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
*/

if ( file_exists( __DIR__ . '/vendor/autoload.php' ) ) {
	require __DIR__ . '/vendor/autoload.php';
}

/**
 * MultisiteLanguageSwitcher
 *
 * @author Dennis Ploetner <[email protected]>
 */
if ( ! defined( 'MSLS_PLUGIN_VERSION' ) ) {
	define( 'MSLS_PLUGIN_VERSION', '2.4.4' );
	define( 'MSLS_PLUGIN_PATH', plugin_basename( __FILE__ ) );
	define( 'MSLS_PLUGIN__FILE__', __FILE__ );

	lloc\Msls\MslsPlugin::init();

	/**
	 * Get the output for using the links to the translations in your code
	 *
	 * @package Msls
	 *
	 * @param array $arr
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 *
	 * @return string
	 */
	function get_the_msls( $attr ) {
		$arr = is_array( $attr ) ? $attr : [];
		$obj = apply_filters( 'msls_get_output', null );

		return ! is_null( $obj ) ? strval( $obj->set_tags( $arr ) ) : '';
	}

	add_shortcode( 'sc_msls', 'get_the_msls' );

	/**
	 * Output the links to the translations in your template
	 *
	 * You can call this function directly like that
	 *
	 *     if ( function_exists ( 'the_msls' ) )
	 *         the_msls();
	 *
	 * or just use it as shortcode [sc_msls]
	 *
	 * @package Msls
	 * @uses get_the_msls
	 *
	 * @param array $arr
	 */
	function the_msls( array $arr = [] ) {
		echo get_the_msls( $arr );
	}

	/**
	 * Gets the URL of the country flag-icon for a specific locale
	 *
	 * @param string $locale
	 *
	 * @return string
	 */
	function get_msls_flag_url( $locale ) {
		return ( new \lloc\Msls\MslsOptions )->get_flag_url( $locale );
	}

	/**
	 * Gets the description for a blog for a specific locale
	 *
	 * @param string $locale
	 *
	 * @return bool|string
	 */
	function get_msls_blog_description( $locale ) {
		$blog = \lloc\Msls\MslsBlogCollection::instance()->get_blog( $locale );

		return $blog->get_description();
	}

	/**
	 * Gets the permalink for a translation of the current post in a given language
	 *
	 * @param string $locale
	 *
	 * @return string
	 */
	function get_msls_permalink( $locale ) {
		$options = \lloc\Msls\MslsOptions::create();
		$blog    = \lloc\Msls\MslsBlogCollection::instance()->get_blog( $locale );

		return $blog->get_url( $options );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
	}

}


1			<?php
2
3			/*
4			Plugin Name: Multisite Language Switcher
5			Plugin URI: http://msls.co/
6			Description: A simple but powerful plugin that will help you to manage the relations of your contents in a multilingual multisite-installation.
7			Version: 2.4.4
8			Author: Dennis Ploetner
9			Author URI: http://lloc.de/
10			Text Domain: multisite-language-switcher
11			*/
12
13			/*
14			Copyright 2013 Dennis Ploetner (email : [email protected])
15
16			This program is free software; you can redistribute it and/or modify
17			it under the terms of the GNU General Public License, version 2, as
18			published by the Free Software Foundation.
19
20			This program is distributed in the hope that it will be useful,
21			but WITHOUT ANY WARRANTY; without even the implied warranty of
22			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23			GNU General Public License for more details.
24
25			You should have received a copy of the GNU General Public License
26			along with this program; if not, write to the Free Software
27			Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
28			*/
29
30			if ( file_exists( __DIR__ . '/vendor/autoload.php' ) ) {
31			require __DIR__ . '/vendor/autoload.php';
32			}
33
34			/**
35			* MultisiteLanguageSwitcher
36			*
37			* @author Dennis Ploetner <[email protected]>
38			*/
39			if ( ! defined( 'MSLS_PLUGIN_VERSION' ) ) {
40			define( 'MSLS_PLUGIN_VERSION', '2.4.4' );
41			define( 'MSLS_PLUGIN_PATH', plugin_basename( __FILE__ ) );
42			define( 'MSLS_PLUGIN__FILE__', __FILE__ );
43
44			lloc\Msls\MslsPlugin::init();
45
46			/**
47			* Get the output for using the links to the translations in your code
48			*
49			* @package Msls
50			*
51			* @param array $arr
			0 ignored issues – show Bug introduced 2018-12-11 17:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$arr`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
52			*
53			* @return string
54			*/
55			function get_the_msls( $attr ) {
56			$arr = is_array( $attr ) ? $attr : [];
57			$obj = apply_filters( 'msls_get_output', null );
58
59			return ! is_null( $obj ) ? strval( $obj->set_tags( $arr ) ) : '';
60			}
61
62			add_shortcode( 'sc_msls', 'get_the_msls' );
63
64			/**
65			* Output the links to the translations in your template
66			*
67			* You can call this function directly like that
68			*
69			* if ( function_exists ( 'the_msls' ) )
70			* the_msls();
71			*
72			* or just use it as shortcode [sc_msls]
73			*
74			* @package Msls
75			* @uses get_the_msls
76			*
77			* @param array $arr
78			*/
79			function the_msls( array $arr = [] ) {
80			echo get_the_msls( $arr );
81			}
82
83			/**
84			* Gets the URL of the country flag-icon for a specific locale
85			*
86			* @param string $locale
87			*
88			* @return string
89			*/
90			function get_msls_flag_url( $locale ) {
91			return ( new \lloc\Msls\MslsOptions )->get_flag_url( $locale );
92			}
93
94			/**
95			* Gets the description for a blog for a specific locale
96			*
97			* @param string $locale
98			*
99			* @return bool\|string
100			*/
101			function get_msls_blog_description( $locale ) {
102			$blog = \lloc\Msls\MslsBlogCollection::instance()->get_blog( $locale );
103
104			return $blog->get_description();
105			}
106
107			/**
108			* Gets the permalink for a translation of the current post in a given language
109			*
110			* @param string $locale
111			*
112			* @return string
113			*/
114			function get_msls_permalink( $locale ) {
115			$options = \lloc\Msls\MslsOptions::create();
116			$blog = \lloc\Msls\MslsBlogCollection::instance()->get_blog( $locale );
117
118			return $blog->get_url( $options );
			0 ignored issues – show Bug introduced 2020-03-31 21:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$options` defined by `\lloc\Msls\MslsOptions::create()` on line `115` can be `null`; however, `lloc\Msls\MslsBlog::get_url()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
119			}
120
121			}
122

lloc / Multisite-Language-Switcher

Push — master ( a934dc...d6329c )

MultisiteLanguageSwitcher.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like