Issues in PasswordRepository.php (master) - Issues in master - lizardmedia/password-migrator-magento2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Model/Data/PasswordRepository.php (3 issues)

Labels

Severity

Maciej Sławik 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);

/**
 * File:PasswordRepository.php
 *
 * @author Maciej Sławik <[email protected]>
 * @copyright Copyright (C) 2018 Lizard Media (http://lizardmedia.pl)
 */

namespace LizardMedia\PasswordMigrator\Model\Data;

use Exception;
use LizardMedia\PasswordMigrator\Api\Data\PasswordInterface;
use LizardMedia\PasswordMigrator\Api\Data\PasswordRepositoryInterface;
use LizardMedia\PasswordMigrator\Model\Password;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use LizardMedia\PasswordMigrator\Model\ResourceModel\Password\Collection;
use LizardMedia\PasswordMigrator\Model\ResourceModel\Password\CollectionFactory;
use LizardMedia\PasswordMigrator\Model\PasswordFactory;
use LizardMedia\PasswordMigrator\Model\ResourceModel\Password as PasswordResource;
use Magento\Framework\Exception\NoSuchEntityException;

/**
 * Class PasswordRepository
 * @package LizardMedia\PasswordMigrator\Model\Data
 */
class PasswordRepository implements PasswordRepositoryInterface
{
    const EXPIRED_PASSWORDS_PURGE_SIZE = 60000;

    /**
     * @var PasswordFactory
     */
    private $passwordFactory;

    /**
     * @var PasswordResource
     */
    private $passwordResource;

    /**
     * @var CollectionFactory
     */
    private $collectionFactory;

    /**
     * PasswordRepository constructor.
     * @param PasswordFactory $passwordFactory
     * @param PasswordResource $passwordResource
     * @param CollectionFactory $collectionFactory
     */
    public function __construct(
        PasswordFactory $passwordFactory,
        PasswordResource $passwordResource,
        CollectionFactory $collectionFactory
    ) {
        $this->passwordFactory = $passwordFactory;
        $this->passwordResource = $passwordResource;
        $this->collectionFactory = $collectionFactory;
    }

    /**
     * @param int $customerId
     * @return PasswordInterface
     * @throws NoSuchEntityException
     */
    public function getByCustomerId(int $customerId): PasswordInterface

    {
        /** @var Password $password */
        $password = $this->passwordFactory->create();
        $this->passwordResource->load($password, $customerId, Password::CUSTOMER_ID);
        if (!$password->getId()) {
            throw new NoSuchEntityException();
        }
        return $password->getDataModel();
    }

    /**
     * @param PasswordInterface $password
     * @return void
     * @throws Exception
     */
    public function save(PasswordInterface $password): void
    {
        /** @var Password $model */
        $model = $this->passwordFactory->create();
        if ($password->getId()) {
            $this->passwordResource->load($model, $password->getId());
        }

        $model->setData(Password::CUSTOMER_ID, $password->getCustomerId());
        $model->setData(Password::PASSWORD, $password->getPassword());
        $model->setData(Password::SALT, $password->getSalt());

        $this->passwordResource->save($model);
    }

    /**
     * @param PasswordInterface $password
     * @return void
     * @throws Exception
     */
    public function delete(PasswordInterface $password): void

    {
        if (!$password->getId()) {
            throw new NoSuchEntityException();
        }

        /** @var Password $model */
        $model = $this->passwordFactory->create();
        $this->passwordResource->load($model, $password->getId());
        $this->passwordResource->delete($model);
    }

    /**
     * @param string $dateTime
     * @return PasswordInterface[]
     */
    public function getOlderThan(string $dateTime): array
    {
        /** @var Collection $collection */
        $collection = $this->collectionFactory->create();
        $collection->addFieldToFilter(Password::CREATED_AT, ['lt' => $dateTime])
            ->setPageSize(self::EXPIRED_PASSWORDS_PURGE_SIZE)
            ->setCurPage(1);

        return array_map(function ($password) {
            /** @var Password $password */
            return $password->getDataModel();
        }, $collection->getItems());
    }
}


1		<?php
2		declare(strict_types=1);
3
4		/**
5		* File:PasswordRepository.php
6		*
7		* @author Maciej Sławik <[email protected]>
8		* @copyright Copyright (C) 2018 Lizard Media (http://lizardmedia.pl)
9		*/
10
11		namespace LizardMedia\PasswordMigrator\Model\Data;
12
13		use Exception;
14		use LizardMedia\PasswordMigrator\Api\Data\PasswordInterface;
15		use LizardMedia\PasswordMigrator\Api\Data\PasswordRepositoryInterface;
16		use LizardMedia\PasswordMigrator\Model\Password;
		0 ignored issues – show Bug introduced 2018-05-23 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `LizardMedia\PasswordMigrator\Model\Data\Password`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
17		use LizardMedia\PasswordMigrator\Model\ResourceModel\Password\Collection;
18		use LizardMedia\PasswordMigrator\Model\ResourceModel\Password\CollectionFactory;
19		use LizardMedia\PasswordMigrator\Model\PasswordFactory;
20		use LizardMedia\PasswordMigrator\Model\ResourceModel\Password as PasswordResource;
21		use Magento\Framework\Exception\NoSuchEntityException;
22
23		/**
24		* Class PasswordRepository
25		* @package LizardMedia\PasswordMigrator\Model\Data
26		*/
27		class PasswordRepository implements PasswordRepositoryInterface
28		{
29		const EXPIRED_PASSWORDS_PURGE_SIZE = 60000;
30
31		/**
32		* @var PasswordFactory
33		*/
34		private $passwordFactory;
35
36		/**
37		* @var PasswordResource
38		*/
39		private $passwordResource;
40
41		/**
42		* @var CollectionFactory
43		*/
44		private $collectionFactory;
45
46		/**
47		* PasswordRepository constructor.
48		* @param PasswordFactory $passwordFactory
49		* @param PasswordResource $passwordResource
50		* @param CollectionFactory $collectionFactory
51		*/
52		public function __construct(
53		PasswordFactory $passwordFactory,
54		PasswordResource $passwordResource,
55		CollectionFactory $collectionFactory
56		) {
57		$this->passwordFactory = $passwordFactory;
58		$this->passwordResource = $passwordResource;
59		$this->collectionFactory = $collectionFactory;
60		}
61
62		/**
63		* @param int $customerId
64		* @return PasswordInterface
65		* @throws NoSuchEntityException
66		*/
67	View Code Duplication	public function getByCustomerId(int $customerId): PasswordInterface
		0 ignored issues – show Duplication introduced 2018-05-23 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		{
69		/** @var Password $password */
70		$password = $this->passwordFactory->create();
71		$this->passwordResource->load($password, $customerId, Password::CUSTOMER_ID);
72		if (!$password->getId()) {
73		throw new NoSuchEntityException();
74		}
75		return $password->getDataModel();
76		}
77
78		/**
79		* @param PasswordInterface $password
80		* @return void
81		* @throws Exception
82		*/
83		public function save(PasswordInterface $password): void
84		{
85		/** @var Password $model */
86		$model = $this->passwordFactory->create();
87		if ($password->getId()) {
88		$this->passwordResource->load($model, $password->getId());
89		}
90
91		$model->setData(Password::CUSTOMER_ID, $password->getCustomerId());
92		$model->setData(Password::PASSWORD, $password->getPassword());
93		$model->setData(Password::SALT, $password->getSalt());
94
95		$this->passwordResource->save($model);
96		}
97
98		/**
99		* @param PasswordInterface $password
100		* @return void
101		* @throws Exception
102		*/
103	View Code Duplication	public function delete(PasswordInterface $password): void
		0 ignored issues – show Duplication introduced 2018-05-23 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
104		{
105		if (!$password->getId()) {
106		throw new NoSuchEntityException();
107		}
108
109		/** @var Password $model */
110		$model = $this->passwordFactory->create();
111		$this->passwordResource->load($model, $password->getId());
112		$this->passwordResource->delete($model);
113		}
114
115		/**
116		* @param string $dateTime
117		* @return PasswordInterface[]
118		*/
119		public function getOlderThan(string $dateTime): array
120		{
121		/** @var Collection $collection */
122		$collection = $this->collectionFactory->create();
123		$collection->addFieldToFilter(Password::CREATED_AT, ['lt' => $dateTime])
124		->setPageSize(self::EXPIRED_PASSWORDS_PURGE_SIZE)
125		->setCurPage(1);
126
127		return array_map(function ($password) {
128		/** @var Password $password */
129		return $password->getDataModel();
130		}, $collection->getItems());
131		}
132		}
133

lizardmedia / password-migrator-magento2

Issues (15)

Security Analysis no request data

Model/Data/PasswordRepository.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like