Issues in Mobile.php (master) - Issues in master - lizardmedia/cart-rule-mobile-magento2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Model/Rule/Condition/Mobile.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);

/**
 * File:Mobile.php
 *
 * @author Maciej Sławik <[email protected]>
 * @copyright Copyright (C) 2018 Lizard Media (http://lizardmedia.pl)
 */

namespace LizardMedia\CartRuleMobile\Model\Rule\Condition;

use LizardMedia\CartRuleMobile\Api\MobileDetectorInterface;
use Magento\Config\Model\Config\Source\Yesno;
use Magento\Framework\Model\AbstractModel;
use Magento\Rule\Model\Condition\AbstractCondition;
use Magento\Rule\Model\Condition\Context;

/**
 * Class Mobile
 * @package LizardMedia\CartRuleMobile\Model\Rule\Condition
 */
class Mobile extends AbstractCondition
{
    /**
     * @var Yesno
     */
    protected $sourceYesNo;

    /**
     * @var MobileDetectorInterface
     */
    private $mobileDetector;

    /**
     * Constructor
     * @param Context $context
     * @param Yesno $sourceYesNo
     * @param MobileDetectorInterface $mobileDetector
     * @param array $data
     */
    public function __construct(
        Context $context,
        Yesno $sourceYesNo,
        MobileDetectorInterface $mobileDetector,
        array $data = []
    ) {
        $this->callParentConstructor($context, $data);
        $this->sourceYesNo = $sourceYesNo;
        $this->mobileDetector = $mobileDetector;
    }

    /**
     * @param AbstractModel $model
     * @return bool
     */
    public function validate(AbstractModel $model)
    {
        $enabledOnMobile = (bool)$this->getValue();
        $isMobile = $this->mobileDetector->isMobileDevice();

        return $enabledOnMobile === $isMobile;
    }

    /**
     * @return string
     */
    public function getInputType()
    {
        return 'select';
    }

    /**
     * @return string
     */
    public function getValueElementType()
    {
        return 'select';
    }

    /**
     * @return array|mixed
     */
    public function getValueSelectOptions()
    {
        if (!$this->hasData('value_select_options')) {
            $this->setData(
                'value_select_options',
                $this->sourceYesNo->toOptionArray()
            );
        }
        return $this->getData('value_select_options');
    }

    /**
     * @return Mobile
     */
    public function loadAttributeOptions()
    {
        $this->setData(
            'attribute_option',
            [
                'is_mobile' => __('Mobile device')
            ]
        );
        return $this;
    }


    /**
     * @param Context $context
     * @param array $data
     * @codeCoverageIgnore
     */
    protected function callParentConstructor(Context $context, array $data): void
    {
        parent::__construct($context, $data);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2			declare(strict_types=1);
3
4			/**
5			* File:Mobile.php
6			*
7			* @author Maciej Sławik <[email protected]>
8			* @copyright Copyright (C) 2018 Lizard Media (http://lizardmedia.pl)
9			*/
10
11			namespace LizardMedia\CartRuleMobile\Model\Rule\Condition;
12
13			use LizardMedia\CartRuleMobile\Api\MobileDetectorInterface;
14			use Magento\Config\Model\Config\Source\Yesno;
15			use Magento\Framework\Model\AbstractModel;
16			use Magento\Rule\Model\Condition\AbstractCondition;
17			use Magento\Rule\Model\Condition\Context;
18
19			/**
20			* Class Mobile
21			* @package LizardMedia\CartRuleMobile\Model\Rule\Condition
22			*/
23			class Mobile extends AbstractCondition
24			{
25			/**
26			* @var Yesno
27			*/
28			protected $sourceYesNo;
29
30			/**
31			* @var MobileDetectorInterface
32			*/
33			private $mobileDetector;
34
35			/**
36			* Constructor
37			* @param Context $context
38			* @param Yesno $sourceYesNo
39			* @param MobileDetectorInterface $mobileDetector
40			* @param array $data
41			*/
42			public function __construct(
43			Context $context,
44			Yesno $sourceYesNo,
45			MobileDetectorInterface $mobileDetector,
46			array $data = []
47			) {
48			$this->callParentConstructor($context, $data);
49			$this->sourceYesNo = $sourceYesNo;
50			$this->mobileDetector = $mobileDetector;
51			}
52
53			/**
54			* @param AbstractModel $model
55			* @return bool
56			*/
57			public function validate(AbstractModel $model)
58			{
59			$enabledOnMobile = (bool)$this->getValue();
60			$isMobile = $this->mobileDetector->isMobileDevice();
61
62			return $enabledOnMobile === $isMobile;
63			}
64
65			/**
66			* @return string
67			*/
68			public function getInputType()
69			{
70			return 'select';
71			}
72
73			/**
74			* @return string
75			*/
76			public function getValueElementType()
77			{
78			return 'select';
79			}
80
81			/**
82			* @return array\|mixed
83			*/
84			public function getValueSelectOptions()
85			{
86			if (!$this->hasData('value_select_options')) {
87			$this->setData(
88			'value_select_options',
89			$this->sourceYesNo->toOptionArray()
90			);
91			}
92			return $this->getData('value_select_options');
93			}
94
95			/**
96			* @return Mobile
97			*/
98			public function loadAttributeOptions()
99			{
100			$this->setData(
101			'attribute_option',
102			[
103			'is_mobile' => __('Mobile device')
104			]
105			);
106			return $this;
107			}
108
109
110			/**
111			* @param Context $context
112			* @param array $data
113			* @codeCoverageIgnore
114			*/
115			protected function callParentConstructor(Context $context, array $data): void
116			{
117			parent::__construct($context, $data);
			0 ignored issues – show Comprehensibility Bug introduced 2018-07-31 15:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`__construct()` instead of `callParentConstructor()`). Are you sure this is correct? If so, you might want to change this to `$this->__construct()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
118			}
119			}
120

lizardmedia / cart-rule-mobile-magento2

Issues (3)

Security Analysis no request data

Model/Rule/Condition/Mobile.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like