GeneralSettingsSchema::buildSettings() - Code Metrics - liverbool/dos-settings-bundle - Measure and Improve Code Quality continuously with Scrutinizer

GeneralSettingsSchema::buildSettings() A
last analyzed 2016-01-13 11:50 UTC

↳ Parent: GeneralSettingsSchema

Complexity

Conditions	1
Paths	1

Size

Total Lines	23
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	3

Metric	Value
c	3
b	0
f	3
dl	0
loc	23
rs	9.0857
cc	1
eloc	19
nc	1
nop	1

<?php

namespace DoS\SettingsBundle\Schema;

use Sylius\Bundle\SettingsBundle\Schema\SettingsBuilderInterface;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Validator\Constraints\Locale;
use Symfony\Component\Validator\Constraints\NotBlank;

/**
 * General settings schema.
 */
class GeneralSettingsSchema implements SchemaInterface
{
    /**
     * @var array
     */
    protected $defaults;

    /**
     * @param array $defaults
     */
    public function __construct(array $defaults = array())
    {
        $this->defaults = $defaults;
    }

    /**
     * {@inheritdoc}
     */
    public function buildSettings(SettingsBuilderInterface $builder)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $builder
            ->setDefaults(array_merge(array(
                'domain' => $_SERVER['HTTP_HOST'],
                'title' => 'DoS - Modern dos for everyone',
                'meta_keywords' => 'DoS',
                'meta_description' => 'DoS is modern for everyone',
                'meta_robots' => 'index, follow',
                'locale' => 'th',
                'currency' => 'THB',
            ), $this->defaults))
            ->setAllowedTypes(array(
                'domain' => array('string'),
                'title' => array('string'),
                'meta_keywords' => array('string'),
                'meta_description' => array('string'),
                'meta_robots' => array('string'),
                'locale' => array('string'),
                'currency' => array('string'),
            ))
        ;
    }

    /**
     * {@inheritdoc}
     */
    public function buildForm(FormBuilderInterface $builder)
    {
        $builder
            ->add('domain', 'text', array(
                'label' => 'ui.trans.settings.general.form.domain',
                'constraints' => array(
                    new NotBlank(),
                ),
            ))
            ->add('title', 'text', array(
                'label' => 'ui.trans.settings.general.form.title',
                'constraints' => array(
                    new NotBlank(),
                ),
            ))
            ->add('meta_keywords', 'text', array(
                'label' => 'ui.trans.settings.general.form.meta_keywords',
                'constraints' => array(
                    new NotBlank(),
                ),
            ))
            ->add('meta_description', 'textarea', array(
                'label' => 'ui.trans.settings.general.form.meta_description',
                'constraints' => array(
                    new NotBlank(),
                ),
            ))
            ->add('meta_robots', 'text', array(
                'label' => 'ui.trans.settings.general.form.meta_robots',
                'constraints' => array(
                    new NotBlank(),
                ),
            ))
            ->add('locale', 'locale', array(
                'label' => 'ui.trans.settings.general.form.locale',
                'constraints' => array(
                    new NotBlank(),
                    new Locale(),
                ),
            ))
        ;
    }
}


1			<?php
2
3			namespace DoS\SettingsBundle\Schema;
4
5			use Sylius\Bundle\SettingsBundle\Schema\SettingsBuilderInterface;
6			use Symfony\Component\Form\FormBuilderInterface;
7			use Symfony\Component\Validator\Constraints\Locale;
8			use Symfony\Component\Validator\Constraints\NotBlank;
9
10			/**
11			* General settings schema.
12			*/
13			class GeneralSettingsSchema implements SchemaInterface
14			{
15			/**
16			* @var array
17			*/
18			protected $defaults;
19
20			/**
21			* @param array $defaults
22			*/
23			public function __construct(array $defaults = array())
24			{
25			$this->defaults = $defaults;
26			}
27
28			/**
29			* {@inheritdoc}
30			*/
31			public function buildSettings(SettingsBuilderInterface $builder)
			0 ignored issues – show Coding Style introduced 2015-12-18 16:34 UTC by Report Bug Copy Issue Report `buildSettings` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
32			{
33			$builder
34			->setDefaults(array_merge(array(
35			'domain' => $_SERVER['HTTP_HOST'],
36			'title' => 'DoS - Modern dos for everyone',
37			'meta_keywords' => 'DoS',
38			'meta_description' => 'DoS is modern for everyone',
39			'meta_robots' => 'index, follow',
40			'locale' => 'th',
41			'currency' => 'THB',
42			), $this->defaults))
43			->setAllowedTypes(array(
44			'domain' => array('string'),
45			'title' => array('string'),
46			'meta_keywords' => array('string'),
47			'meta_description' => array('string'),
48			'meta_robots' => array('string'),
49			'locale' => array('string'),
50			'currency' => array('string'),
51			))
52			;
53			}
54
55			/**
56			* {@inheritdoc}
57			*/
58			public function buildForm(FormBuilderInterface $builder)
59			{
60			$builder
61			->add('domain', 'text', array(
62			'label' => 'ui.trans.settings.general.form.domain',
63			'constraints' => array(
64			new NotBlank(),
65			),
66			))
67			->add('title', 'text', array(
68			'label' => 'ui.trans.settings.general.form.title',
69			'constraints' => array(
70			new NotBlank(),
71			),
72			))
73			->add('meta_keywords', 'text', array(
74			'label' => 'ui.trans.settings.general.form.meta_keywords',
75			'constraints' => array(
76			new NotBlank(),
77			),
78			))
79			->add('meta_description', 'textarea', array(
80			'label' => 'ui.trans.settings.general.form.meta_description',
81			'constraints' => array(
82			new NotBlank(),
83			),
84			))
85			->add('meta_robots', 'text', array(
86			'label' => 'ui.trans.settings.general.form.meta_robots',
87			'constraints' => array(
88			new NotBlank(),
89			),
90			))
91			->add('locale', 'locale', array(
92			'label' => 'ui.trans.settings.general.form.locale',
93			'constraints' => array(
94			new NotBlank(),
95			new Locale(),
96			),
97			))
98			;
99			}
100			}
101

liverbool / dos-settings-bundle

GeneralSettingsSchema::buildSettings() A last analyzed 2016-01-13 11:50 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

GeneralSettingsSchema::buildSettings() A
last analyzed 2016-01-13 11:50 UTC