DoS\ResourceBundle\AclDecoratedResolver\SingleResourceProvider

Complexity

Total Complexity

9

Size/Duplication

Total Lines	69
Duplicated Lines	17.39 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	requireOwnerCheck()	12	12	3
B	get()	0	18	5

<?php

namespace DoS\ResourceBundle\AclDecoratedResolver;

use Sylius\Bundle\ResourceBundle\Controller\RequestConfiguration;
use Sylius\Bundle\ResourceBundle\Controller\SingleResourceProviderInterface;
use Sylius\Component\Rbac\Authorization\AuthorizationCheckerInterface as SyliusAuthorizationCheckerInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Symfony\Component\Security\Core\Exception\AuthenticationCredentialsNotFoundException;

class SingleResourceProvider implements SingleResourceProviderInterface
{
    /**
     * @var SingleResourceProviderInterface
     */
    private $singleResourceDecorator;

    /**
     * @var AuthorizationCheckerInterface
     */
    private $authorizationChecker;

    /**
     * @var SyliusAuthorizationCheckerInterface
     */
    private $rbacAuthorizationChecker;

    /**
     * @var string
     */
    private $ignoreWhenHasRbacRole;

    public function __construct(
        SingleResourceProviderInterface $singleResourceDecorator,
        AuthorizationCheckerInterface $authorizationChecker,
        SyliusAuthorizationCheckerInterface $rbacAuthorizationChecker,
        $ignoreWhenHasRbacRole = 'admin'
    ) {
        $this->singleResourceDecorator = $singleResourceDecorator;
        $this->authorizationChecker = $authorizationChecker;
        $this->rbacAuthorizationChecker = $rbacAuthorizationChecker;
        $this->ignoreWhenHasRbacRole = $ignoreWhenHasRbacRole;
    }

    private function requireOwnerCheck(array $vars)

This method seems to be duplicated in your project.

    {
        if ($this->rbacAuthorizationChecker->isGranted($this->ignoreWhenHasRbacRole)) {
            return false;
        }

        if (!array_key_exists('acl_owner', $vars)) {
            return false;
        }

        return false !== $vars['acl_owner'];
    }

    /**
     * {@inheritdoc}
     */
    public function get(RequestConfiguration $requestConfiguration, RepositoryInterface $repository)
    {
        $resource = $this->singleResourceDecorator->get($requestConfiguration, $repository);

        if ($resource && $this->requireOwnerCheck($requestConfiguration->getVars())) {
            try {
                if ($this->authorizationChecker->isGranted('OWNER', $resource)) {
                    return $resource;
                }
            } catch (AuthenticationCredentialsNotFoundException $e) {
                throw new AccessDeniedException();
            }

            throw new AccessDeniedException();
        }

        return $resource;
    }
}