DoS\ResourceBundle\Controller\ResourceController

Complexity

Total Complexity

26

Size/Duplication

Total Lines	168
Duplicated Lines	8.33 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes	3
Bugs	0	Features	2

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getManager()	0	4	1
A	getEntityRepository()	0	12	3
A	stringToBoolean()	0	10	3
A	findOr404()	0	10	2
B	activeStateAction()	7	26	5
A	enableStateAction()	7	19	4
C	batchDeleteAction()	0	44	8

<?php

namespace DoS\ResourceBundle\Controller;

use Doctrine\ORM\EntityManager;
use DoS\ResourceBundle\Doctrine\ORM\EntityRepository;
use Sylius\Bundle\ResourceBundle\Controller\ResourceController as BaseResourceController;
use Sylius\Component\Resource\Event\ResourceEvent;
use Sylius\Component\Resource\Exception\UnexpectedTypeException;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\PropertyAccess\PropertyAccess;

class ResourceController extends BaseResourceController
{
    protected $activedPath = 'actived';
    protected $enabledPath = 'enabled';

    /**
     * @return EntityManager
     */
    protected function getManager()
    {
        return $this->get($this->config->getServiceName('manager'));
    }

    /**
     * @param $resource
     * @param bool|true $dosRepository
     *
     * @return \Doctrine\ORM\EntityRepository|EntityRepository
     */
    protected function getEntityRepository($resource, $dosRepository = true)
    {
        $er = $this->getManager()->getRepository(get_class($resource));

        if ($dosRepository) {
            if (!$er instanceof EntityRepository) {
                throw new UnexpectedTypeException($er, EntityRepository::class);
            }
        }

        return $er;
    }

    /**
     * @param $string
     *
     * @return bool
     */
    protected function stringToBoolean($string)
    {
        $string = is_string($string) ? strtolower($string) : $string;

        if (in_array($string, array(true, 1, '1', 'yes', 'true'), true)) {
            return true;
        }

        return false;
    }

    /**
     * @inheritdoc
     */
    public function findOr404(Request $request, array $criteria = array())
    {
        $resource = parent::findOr404($request, $criteria);

        if ($roles = $this->config->getParameters()->get('is_granted')) {
            $this->denyAccessUnlessGranted((array) $roles, $resource);
        }

        return $resource;
    }

    /**
     * @param Request $request
     * @param $state
     * @param null $path
     *
     * @return RedirectResponse|Response
     */
    public function activeStateAction(Request $request, $state, $path = null)
    {
        $path = $path ?: $this->activedPath;
        $resource = $this->findOr404($request);
        $accessor = PropertyAccess::createPropertyAccessor();
        $accessor->setValue($resource, $path, $this->stringToBoolean($state));

        $this->getManager()->transactional(function () use ($state, $resource, $path) {
            if ($state) {
                // reset other to false
                $this->getEntityRepository($resource)->bulkUpdate(array($path => false));
            }

            $this->domainManager->update($resource);
        });

        if ($this->config->isApiRequest()) {

This code seems to be duplicated across your project.

            if ($resource instanceof ResourceEvent) {
                throw new HttpException($resource->getErrorCode(), $resource->getMessage());
            }

            return $this->handleView($this->view($resource, 204));
        }

        return $this->redirectHandler->redirectToReferer();
    }

    /**
     * @param Request $request
     * @param $state
     * @param null $path
     *
     * @return RedirectResponse|Response
     */
    public function enableStateAction(Request $request, $state, $path = null)
    {
        $path = $path ?: $this->enabledPath;
        $resource = $this->findOr404($request);
        $accessor = PropertyAccess::createPropertyAccessor();
        $accessor->setValue($resource, $path, $this->stringToBoolean($state));

        $this->domainManager->update($resource);

It seems like $resource can also be of type array; however, Sylius\Bundle\ResourceBundle\Controller\DomainManager::update() does only seem to accept object, maybe add an additional type check?

        if ($this->config->isApiRequest()) {

This code seems to be duplicated across your project.

            if ($resource instanceof ResourceEvent) {
                throw new HttpException($resource->getErrorCode(), $resource->getMessage());
            }

            return $this->handleView($this->view($resource, 204));
        }

        return $this->redirectHandler->redirectToReferer();
    }

    public function batchDeleteAction(Request $request, array $ids = null)
    {
        if (null == $ids) {
            $ids = $request->get('ids');
        }

        if (is_string($ids)) {
            $ids = explode( ',', $ids);
        }

        $this->isGrantedOr403('delete');

        $resources = $this->get('toro.repository.match')->findBy(array(
            'id' => $ids
        ));

        if (!count($resources)) {
            throw new NotFoundHttpException(
                sprintf(
                    'Requested %s does not exist with these ids: %s.',
                    $this->config->getResourceName(),
                    json_encode($this->config->getCriteria($ids))
                )
            );
        }

        /** @var MatchInterface $resource */
        foreach ($resources as $resource) {
            /** @var ResourceEvent $resource */
            $resource = $this->domainManager->delete($resource);

            if ($this->config->isApiRequest()) {
                if ($resource instanceof ResourceEvent) {
                    throw new HttpException($resource->getErrorCode(), $resource->getMessage());
                }
            }
        }

        if ($this->config->isApiRequest()) {
            return $this->handleView($this->view());
        }

        return $this->redirectHandler->redirectToIndex();
    }
}