DoS\ResourceBundle\Form\Type\AbstractResourceType

Complexity

Total Complexity

3

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	2
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getName()	0	4	1
A	setObjectManager()	0	5	1
A	__construct()	0	6	1

<?php

namespace DoS\ResourceBundle\Form\Type;

use Doctrine\Common\Persistence\ObjectManager;
use Doctrine\Common\Persistence\ObjectRepository;
use Sylius\Bundle\ResourceBundle\Form\Type\AbstractResourceType as BaseAbstractResourceType;

abstract class AbstractResourceType extends BaseAbstractResourceType
{
    /**
     * @var string
     */
    protected $name;

    /**
     * @var ObjectManager
     */
    protected $manager;

    /**
     * @var ObjectRepository
     */
    protected $repository;

    /**
     * @param ObjectManager|null $manager
     */
    public function setObjectManager(ObjectManager $manager = null)
    {
        $this->manager = $manager;
        $this->repository = $manager->getRepository($this->dataClass);

It seems like $manager is not always an object, but can also be of type null. Maybe add an additional type check?

    }

    /**
     * {@inheritdoc}
     */
    public function __construct($dataClass, array $validationGroups = array(), $name = null)
    {
        parent::__construct($dataClass, $validationGroups);

        $this->name = $name;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return $this->name;
    }
}