list_groups() - Code Metrics - Inspection of "manipulate data in its own class" - live627/smf-ultimate-menu - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( da58ee...4c81df )

by John

created 2020-11-12 14:03 UTC

list_groups() C

↳ Parent: Project

Complexity

Conditions	13
Paths	144

Size

Total Lines	65
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	13
eloc	40
nc	144
nop	5
dl	0
loc	65
rs	6.25
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	um_admin_areas()	0	15	1

How to fix Long Method Complexity

<?php

/**
 * @package Ultimate Menu mod
 * @version 1.0.3
 * @author John Rayes <[email protected]>
 * @copyright Copyright (c) 2014, John Rayes
 * @license http://opensource.org/licenses/MIT MIT
 */

if (!defined('SMF'))
	die('Hacking attempt...');

function um_load_menu(&$menu_buttons)
{
	global $smcFunc, $user_info, $scripturl, $context, $modSettings;

	// Make damn sure we ALWAYS load last. Priority: 100!
	if (substr($modSettings['integrate_menu_buttons'], -12) === 'um_load_menu')
	{
		remove_integration_function('integrate_menu_buttons', 'um_load_menu');
		add_integration_function('integrate_menu_buttons', 'um_load_menu');
	}

	$num_buttons = isset($modSettings['um_count'])
		? $modSettings['um_count']
		: 0;

	for ($i = 1; $i <= $num_buttons; $i++)
	{
		$key = 'um_button_' . $i;
		if (!isset($modSettings[$key]))
			break;
		$row = json_decode($modSettings[$key], true);
		$temp_menu = array(
			'title' => $row['name'],
			'href' => ($row['type'] == 'forum' ? $scripturl . '?' : '') . $row['link'],
			'target' => $row['target'],
			'show' => (allowedTo('admin_forum') || count(array_intersect($user_info['groups'], explode(',', $row['permissions']))) >= 1) && $row['status'] == 'active',
		);

		foreach ($menu_buttons as $area => &$info)
		{
			if ($area == $row['parent'])
			{
				if ($row['position'] == 'before' || $row['position'] == 'after')
				{
					if (array_key_exists($row['parent'], $menu_buttons))
					{
						insert_button(array($key => $temp_menu), $menu_buttons, $row['parent'], $row['position']);
						break;
					}
				}
				elseif ($row['position'] == 'child_of')
				{
					$info['sub_buttons'][$key] = $temp_menu;
					break;
				}
			}
			elseif (isset($info['sub_buttons'][$row['parent']]))
			{
				if ($row['position'] == 'before' || $row['position'] == 'after')
				{
					insert_button(array($key => $temp_menu), $info['sub_buttons'], $row['parent'], $row['position']);
					break;
				}
				elseif ($row['position'] == 'child_of')
				{
					$info['sub_buttons'][$row['parent']]['sub_buttons'][$key] = $temp_menu;
					break;
				}
			}
		}
	}
}

function insert_button($needle, &$haystack, $insertion_point, $where = 'after')
{
	if (array_key_exists($insertion_point, $haystack))
	{
		$offset = 0;

		foreach ($haystack as $area => $dummy)
			if (++$offset && $area == $insertion_point)
				break;

		if ($where == 'before')
			$offset--;

		$haystack = array_slice($haystack, 0, $offset, true) + $needle + array_slice($haystack, $offset, null, true);
	}
	else
		foreach ($haystack as $stack)
			if (array_key_exists($insertion_point, $haystack[$stack]))
			{
				$offset = 0;

				foreach ($haystack[$stack] as $area => $dummy)
					if (++$offset && $area == $insertion_point)
						break;

				if ($where == 'before')
					$offset--;

				$haystack[$stack] = array_slice($haystack[$stack], 0, $offset, true) + $needle + array_slice($haystack[$stack], $offset, null, true);
				break;
			}
}

function um_admin_areas(&$admin_areas)
{
	global $txt;

	loadLanguage('ManageUltimateMenu');
	$admin_areas['config']['areas']['umen'] = array(
		'label' => $txt['um_admin_menu'],
		'file' => 'ManageUltimateMenu.php',
		'function' => function () {
			new ManageUltimateMenu;
		},
		'icon' => 'umen.png',
		'subsections' => array(
			'manmenu' => array($txt['um_admin_manage_menu'], ''),
			'addbutton' => array($txt['um_admin_add_button'], ''),
		),
	);
}

?>


1			<?php
2
3			/**
4			* @package Ultimate Menu mod
5			* @version 1.0.3
6			* @author John Rayes <[email protected]>
7			* @copyright Copyright (c) 2014, John Rayes
8			* @license http://opensource.org/licenses/MIT MIT
9			*/
10
11			if (!defined('SMF'))
12			die('Hacking attempt...');
13
14			function um_load_menu(&$menu_buttons)
15			{
16			global $smcFunc, $user_info, $scripturl, $context, $modSettings;
17
18			// Make damn sure we ALWAYS load last. Priority: 100!
19			if (substr($modSettings['integrate_menu_buttons'], -12) === 'um_load_menu')
20			{
21			remove_integration_function('integrate_menu_buttons', 'um_load_menu');
22			add_integration_function('integrate_menu_buttons', 'um_load_menu');
23			}
24
25			$num_buttons = isset($modSettings['um_count'])
26			? $modSettings['um_count']
27			: 0;
28
29			for ($i = 1; $i <= $num_buttons; $i++)
30			{
31			$key = 'um_button_' . $i;
32			if (!isset($modSettings[$key]))
33			break;
34			$row = json_decode($modSettings[$key], true);
35			$temp_menu = array(
36			'title' => $row['name'],
37			'href' => ($row['type'] == 'forum' ? $scripturl . '?' : '') . $row['link'],
38			'target' => $row['target'],
39			'show' => (allowedTo('admin_forum') \|\| count(array_intersect($user_info['groups'], explode(',', $row['permissions']))) >= 1) && $row['status'] == 'active',
40			);
41
42			foreach ($menu_buttons as $area => &$info)
43			{
44			if ($area == $row['parent'])
45			{
46			if ($row['position'] == 'before' \|\| $row['position'] == 'after')
47			{
48			if (array_key_exists($row['parent'], $menu_buttons))
49			{
50			insert_button(array($key => $temp_menu), $menu_buttons, $row['parent'], $row['position']);
51			break;
52			}
53			}
54			elseif ($row['position'] == 'child_of')
55			{
56			$info['sub_buttons'][$key] = $temp_menu;
57			break;
58			}
59			}
60			elseif (isset($info['sub_buttons'][$row['parent']]))
61			{
62			if ($row['position'] == 'before' \|\| $row['position'] == 'after')
63			{
64			insert_button(array($key => $temp_menu), $info['sub_buttons'], $row['parent'], $row['position']);
65			break;
66			}
67			elseif ($row['position'] == 'child_of')
68			{
69			$info['sub_buttons'][$row['parent']]['sub_buttons'][$key] = $temp_menu;
70			break;
71			}
72			}
73			}
74			}
75			}
76
77			function insert_button($needle, &$haystack, $insertion_point, $where = 'after')
78			{
79			if (array_key_exists($insertion_point, $haystack))
80			{
81			$offset = 0;
82
83			foreach ($haystack as $area => $dummy)
84			if (++$offset && $area == $insertion_point)
85			break;
86
87			if ($where == 'before')
88			$offset--;
89
90			$haystack = array_slice($haystack, 0, $offset, true) + $needle + array_slice($haystack, $offset, null, true);
91			}
92			else
93			foreach ($haystack as $stack)
94			if (array_key_exists($insertion_point, $haystack[$stack]))
95			{
96			$offset = 0;
97
98			foreach ($haystack[$stack] as $area => $dummy)
99			if (++$offset && $area == $insertion_point)
100			break;
101
102			if ($where == 'before')
103			$offset--;
104
105			$haystack[$stack] = array_slice($haystack[$stack], 0, $offset, true) + $needle + array_slice($haystack[$stack], $offset, null, true);
106			break;
107			}
108			}
109
110			function um_admin_areas(&$admin_areas)
111			{
112			global $txt;
113
114			loadLanguage('ManageUltimateMenu');
115			$admin_areas['config']['areas']['umen'] = array(
116			'label' => $txt['um_admin_menu'],
117			'file' => 'ManageUltimateMenu.php',
118			'function' => function () {
119			new ManageUltimateMenu;
120			},
121			'icon' => 'umen.png',
122			'subsections' => array(
123			'manmenu' => array($txt['um_admin_manage_menu'], ''),
124			'addbutton' => array($txt['um_admin_add_button'], ''),
125			),
126			);
127			}
128
129			?>
130

live627 / smf-ultimate-menu

Push — master ( da58ee...4c81df )

list_groups() C

Complexity

Size

Duplication

Importance

1 Method

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like